drm/i915: Spinlocks in tasklets can use spin_(un)lock_irq
Subsystems (2)
Tvrtko Ursulin
maintainerPATCH 1/1 drm/i915: Spinlocks in tasklets can use spin_(un)lock_irq
From: Tvrtko Ursulin <[email protected]>
The tasklets callbacks are only called from tasklet context so it is safe do to this.
--- drivers/gpu/drm/i915/i915_guc_submission.c | 5 ++--- drivers/gpu/drm/i915/intel_lrc.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_guc_submission.c +2 -3
@@ -573,7 +573,6 @@ static bool i915_guc_dequeue(struct intel_engine_cs *engine) {struct execlist_port *port = engine->execlist_port;struct drm_i915_gem_request *last = port[0 ].request; -unsigned long flags;struct rb_node *rb;bool submit = false;
@@ -589,7 +588,7 @@ static bool i915_guc_dequeue(struct intel_engine_cs *engine)if (!READ_ONCE (engine->execlist_first))return false; -spin_lock_irqsave (&engine->timeline->lock, flags); +spin_lock_irq (&engine->timeline->lock); rb = engine->execlist_first;while (rb) { struct drm_i915_gem_request *rq =
@@ -619,7 +618,7 @@ static bool i915_guc_dequeue(struct intel_engine_cs *engine)nested_enable_signaling (last); engine->execlist_first = rb; } -spin_unlock_irqrestore (&engine->timeline->lock, flags); +spin_unlock_irq (&engine->timeline->lock);return submit; }
drivers/gpu/drm/i915/intel_lrc.c +2 -3
@@ -399,7 +399,6 @@ static void execlists_dequeue(struct intel_engine_cs *engine) {struct drm_i915_gem_request *last;struct execlist_port *port = engine->execlist_port; -unsigned long flags;struct rb_node *rb;bool submit = false;
@@ -448,7 +447,7 @@ static void execlists_dequeue(struct intel_engine_cs *engine)* and context switches) submission. */ -spin_lock_irqsave (&engine->timeline->lock, flags); +spin_lock_irq (&engine->timeline->lock); rb = engine->execlist_first;while (rb) { struct drm_i915_gem_request *cursor =
@@ -500,7 +499,7 @@ static void execlists_dequeue(struct intel_engine_cs *engine)i915_gem_request_assign (&port->request, last); engine->execlist_first = rb; } -spin_unlock_irqrestore (&engine->timeline->lock, flags); +spin_unlock_irq (&engine->timeline->lock);if (submit)execlists_submit_ports (engine);
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
The tasklets callbacks are only called from tasklet context so it is safe do to this.
Indeed.
Quoted 2 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Chris Wilson <[email protected]>
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Spinlocks in tasklets can use spin_(un)lock_irq
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Spinlocks in tasklets can use spin_(un)lock_irq
URL : https://patchwork.freedesktop.org/series/21600/
State : success
== Summary ==
Series 21600v1 drm/i915: Spinlocks in tasklets can use spin_(un)lock_irq
https://patchwork.freedesktop.org/api/1.0/series/21600/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
dmesg-warn -> PASS (fi-bxt-t5700) fdo#100125fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 457s fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 571s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 541s fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time: 556s fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 497s fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 495s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 444s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 433s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 434s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 519s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 486s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 486s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 480s fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 595s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 482s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 519s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 548s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time: 420s
84b98c6d4f5f6ce0ce17b8fd07629dfc71e7d829 drm-tip: 2017y-03m-21d-11h-08m-23s UTC integration manifest f838fa3 drm/i915: Spinlocks in tasklets can use spin_(un)lock_irq
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4246/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for drm/i915: Spinlocks in tasklets can use spin_(un)lock_irq
Quoted 36 lines · Patchwork
== Series Details ==
Series: drm/i915: Spinlocks in tasklets can use spin_(un)lock_irq
URL : https://patchwork.freedesktop.org/series/21600/
State : success== Summary ==
Series 21600v1 drm/i915: Spinlocks in tasklets can use spin_(un)lock_irq
https://patchwork.freedesktop.org/api/1.0/series/21600/revisions/1/mbox/Test
gem_exec_suspend:Subgroup basic-s4-devices: dmesg-warn -> PASS (fi-bxt-t5700) fdo#100125fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 457s fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 571s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 541s fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time: 556s fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 497s fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 495s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 444s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 433s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 434s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 519s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 486s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 486s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 480s fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 595s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 482s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 519s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 548s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time: 420s
Quoted 2 lines
84b98c6d4f5f6ce0ce17b8fd07629dfc71e7d829drm-tip: 2017y-03m-21d-11h-08m-23s UTC integration manifest f838fa3 drm/i915: Spinlocks in tasklets can use spin_(un)lock_irq
Pushed, thanks for the review!
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx