Revert "extcon: usb-gpio: add support for ACPI gpio interface"
PATCH 1/1 Revert "extcon: usb-gpio: add support for ACPI gpio interface"
The commit 942c7924a51e introduced a check for ACPI handle for the device that never appears on any ACPI-enabled platform so far. It seems a confusion with extcon-intel-int3496 which does support ACPI-enabled platforms.
Revert commit 942c7924a51e to avoid any confusion in the future.
--- drivers/extcon/extcon-usb-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/extcon/extcon-usb-gpio.c +1 -2
@@ -26,7 +26,6 @@#include <linux/platform_device.h> #include <linux/slab.h> #include <linux/workqueue.h> -#include <linux/acpi.h> #include <linux/pinctrl/consumer.h> #define USB_GPIO_DEBOUNCE_MS 20/* ms */
@@ -111,7 +110,7 @@ static int usb_extcon_probe(struct platform_device *pdev)struct usb_extcon_info *info;int ret; -if (!np && !ACPI_HANDLE (dev)) +if (!np)return -EINVAL ; info =devm_kzalloc (&pdev->dev,sizeof (*info),GFP_KERNEL );
Signature · 1 line
2.11.0
Chanwoo Choi
maintainerHi,
Quoted 4 lines · Andy Shevchenko
The commit
942c7924a51eintroduced a check for ACPI handle for the device that never appears on any ACPI-enabled platform so far. It seems a confusion with extcon-intel-int3496 which does support ACPI-enabled platforms.
Only for the reason that there is no any usecase until now, and remove the confusion between extcon-usb-gpio and extcon-intel-int3496. Should we revert it?
I think that both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly. Also, the filename of extcon-intel-int3496 has specific name. Instead, extcon-usb-gpio.c is more common device driver.
Can the extcon-intel-int3496.c support the everything on acpi side?
Quoted 31 lines
Revert commit
942c7924a51eto avoid any confusion in the future.Cc Lu Baolu <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/extcon/extcon-usb-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/extcon/extcon-usb-gpio.c +1
-2@@ -26,7 +26,6 @@#include <linux/platform_device.h> #include <linux/slab.h> #include <linux/workqueue.h> -#include <linux/acpi.h> #include <linux/pinctrl/consumer.h> #define USB_GPIO_DEBOUNCE_MS 20/* ms */ @@ -111,7 +110,7 @@ static int usb_extcon_probe(struct platform_device *pdev)struct usb_extcon_info *info;int ret; -if (!np && !ACPI_HANDLE (dev)) +if (!np)return -EINVAL ; info =devm_kzalloc (&pdev->dev,sizeof (*info),GFP_KERNEL );
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Quoted 17 lines · Chanwoo Choi
Hi,
Quoted 6 lines · Andy Shevchenko
The commit
942c7924a51eintroduced a check for ACPI handle for the device that never appears on any ACPI-enabled platform so far. It seems
a confusion with extcon-intel-int3496 which does support ACPI- enabled
platforms.Only for the reason that there is no any usecase until now, and remove the confusion between extcon-usb-gpio and extcon-intel- int3496.
Should we revert it?
Quoted 6 lines
I think that both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly. Also, the filename of extcon-intel-int3496 has specific name. Instead,
extcon-usb-gpio.cis more common device driver.Can the
extcon-intel-int3496.csupport the everything on acpi side?
For my understanding we have the only driver for now for USB mux in the kernel for ACPI-enabled platforms.
Besides confusion, it makes harder to fix a real bugs in at least GPIO ACPI library since we need to amend any user of it first. While confusion is here, I can't do anything to not possible break the functionality of the driver in a real use case if any (I doubt there is any in this particular case).
So, my opinion here is "yes, we should revert it until we have a confirmation that there is a product which is using this among with ACPI" (which I doubt ever exists).
Quoted 36 lines
Quoted 34 lines
Revert commit
942c7924a51eto avoid any confusion in the future.Cc Lu Baolu <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>---
drivers/extcon/extcon-usb-gpio.c | 3 +--1 file changed, 1 insertion(+), 2 deletions(-)drivers/extcon/extcon-usb-gpio.c +0
-1@@ -26,7 +26,6 @@ #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/workqueue.h> -#include <linux/acpi.h> #include <linux/pinctrl/consumer.h>
#defineUSB_GPIO_DEBOUNCE_MS20 /* ms */drivers/extcon/extcon-usb-gpio.c +0
-0@@ -111,7 +110,7 @@ static int usb_extcon_probe(struct platform_device *pdev) struct usb_extcon_info *info; int ret;drivers/extcon/extcon-usb-gpio.c +1
-1-if (!np && !ACPI_HANDLE (dev)) +if (!np)return
-EINVAL;
info =devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Chanwoo Choi
maintainerHi,
Quoted 34 lines · Andy Shevchenko
Quoted 17 lines · Chanwoo Choi
Hi,
Quoted 6 lines · Andy Shevchenko
The commit
942c7924a51eintroduced a check for ACPI handle for the device that never appears on any ACPI-enabled platform so far. It seems
a confusion with extcon-intel-int3496 which does support ACPI- enabled
platforms.Only for the reason that there is no any usecase until now, and remove the confusion between extcon-usb-gpio and extcon-intel- int3496.
Should we revert it?Quoted 6 lines
I think that both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly. Also, the filename of extcon-intel-int3496 has specific name. Instead,
extcon-usb-gpio.cis more common device driver.Can the
extcon-intel-int3496.csupport the everything on acpi side?For my understanding we have the only driver for now for USB mux in the kernel for ACPI-enabled platforms.
Besides confusion, it makes harder to fix a real bugs in at least GPIO ACPI library since we need to amend any user of it first. While confusion is here, I can't do anything to not possible break the functionality of the driver in a real use case if any (I doubt there is any in this particular case).
Quoted 3 lines
So, my opinion here is "yes, we should revert it until we have a confirmation that there is a product which is using this among with ACPI" (which I doubt ever exists).
Because you told me there was not any use case of extcon-usb-gpioc.c on acpi side. But, I think that it is not enough as the reason.
Because I already mentioned,
1.
"The both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly." It two driver are same operation and there is no use case on acpi side, I may agree your suggestion. But, in this case, they are different between two drivers.
2.
Also, extcon-intel-int3496 has the specific name 'int3496'. I think that it only depends on the specific device driver on acpi side. I don't think it cover all of use case on acpi side.
Quoted 38 lines
Quoted 37 lines
Quoted 35 lines
Revert commit
942c7924a51eto avoid any confusion in the future.Cc Lu Baolu <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/extcon/extcon-usb-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/extcon/extcon-usb-gpio.c +1
-2@@ -26,7 +26,6 @@#include <linux/platform_device.h> #include <linux/slab.h> #include <linux/workqueue.h> -#include <linux/acpi.h> #include <linux/pinctrl/consumer.h> #define USB_GPIO_DEBOUNCE_MS 20/* ms */ @@ -111,7 +110,7 @@ static int usb_extcon_probe(struct platform_device *pdev)struct usb_extcon_info *info;int ret; -if (!np && !ACPI_HANDLE (dev)) +if (!np)return -EINVAL ;info =
devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Quoted 55 lines · Chanwoo Choi
Quoted 40 lines · Andy Shevchenko
Quoted 18 lines · Chanwoo Choi
Quoted 8 lines · Andy Shevchenko
The commit
942c7924a51eintroduced a check for ACPI handle for the
device that never appears on any ACPI-enabled platform so far. It
seems
a confusion with extcon-intel-int3496 which does support ACPI- enabled
platforms.Only for the reason that there is no any usecase until now, and remove the confusion between extcon-usb-gpio and extcon-intel- int3496.
Should we revert it?Quoted 8 lines
I think that both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly. Also, the filename of extcon-intel-int3496 has specific name. Instead, extcon-usb-
gpio.c
is more common device driver.Can the
extcon-intel-int3496.csupport the everything on acpi side?For my understanding we have the only driver for now for USB mux in the
kernel for ACPI-enabled platforms.Besides confusion, it makes harder to fix a real bugs in at least GPIO
ACPI library since we need to amend any user of it first. While confusion is here, I can't do anything to not possible break the functionality of the driver in a real use case if any (I doubt there is
any in this particular case).Quoted 3 lines
So, my opinion here is "yes, we should revert it until we have a confirmation that there is a product which is using this among with ACPI" (which I doubt ever exists).
Because you told me there was not any use case of
extcon-usb-gpioc.con acpi side. But, I think that it is not enough as the reason.Because I already mentioned,
1.
"The both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly." It two driver are same operation and there is no use case on acpi side, I may agree your suggestion. But, in this case, they are different between two drivers.
Quoted 5 lines
2.
Also, extcon-intel-int3496 has the specific name 'int3496'. I think that it only depends on the specific device driver on acpi side.
I don't think it cover all of use case on acpi side.
Just one question: is there *real* existing device where ACPI table contains something related to extcon-usb-gpio?
I'm pretty sure the answer is no. Moreover, Lu pointed me out to the series which tried to update the driver in question to support int3496. Though it comes as a separate driver, thus that series was abandoned IIUC.
I really don't care if some dead confusing code will be left in some poor driver, at the end it's not my call.
P.S. We already spent enough time making a mountain out of a molehill. I rest my case.
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Chanwoo Choi
maintainerHi Lu Baolu,
Quoted 70 lines · Andy Shevchenko
Quoted 55 lines · Chanwoo Choi
Quoted 40 lines · Andy Shevchenko
Quoted 18 lines · Chanwoo Choi
Quoted 8 lines · Andy Shevchenko
The commit
942c7924a51eintroduced a check for ACPI handle for the
device that never appears on any ACPI-enabled platform so far. It
seems
a confusion with extcon-intel-int3496 which does support ACPI- enabled
platforms.Only for the reason that there is no any usecase until now, and remove the confusion between extcon-usb-gpio and extcon-intel- int3496.
Should we revert it?Quoted 8 lines
I think that both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly. Also, the filename of extcon-intel-int3496 has specific name. Instead, extcon-usb-
gpio.c
is more common device driver.Can the
extcon-intel-int3496.csupport the everything on acpi side?For my understanding we have the only driver for now for USB mux in the
kernel for ACPI-enabled platforms.Besides confusion, it makes harder to fix a real bugs in at least GPIO
ACPI library since we need to amend any user of it first. While confusion is here, I can't do anything to not possible break the functionality of the driver in a real use case if any (I doubt there is
any in this particular case).Quoted 3 lines
So, my opinion here is "yes, we should revert it until we have a confirmation that there is a product which is using this among with ACPI" (which I doubt ever exists).
Because you told me there was not any use case of
extcon-usb-gpioc.con acpi side. But, I think that it is not enough as the reason.Because I already mentioned,
1.
"The both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly." It two driver are same operation and there is no use case on acpi side, I may agree your suggestion. But, in this case, they are different between two drivers.Quoted 5 lines
2.
Also, extcon-intel-int3496 has the specific name 'int3496'. I think that it only depends on the specific device driver on acpi side.
I don't think it cover all of use case on acpi side.Just one question: is there *real* existing device where ACPI table contains something related to extcon-usb-gpio?
I'm pretty sure the answer is no. Moreover, Lu pointed me out to the series which tried to update the driver in question to support int3496. Though it comes as a separate driver, thus that series was abandoned IIUC.
Quoted 6 lines
I really don't care if some dead confusing code will be left in some poor driver, at the end it's not my call.
P.S. We already spent enough time making a mountain out of a molehill. I rest my case.
OK. Just I want to receive the reply from Lu Baolu.
In the "extcon-usb-gpio ACPI support" mail thread,
I understood that Lu Baolu said that the related patches were abandoned.
To Lu Baolu,
Don't you ever use the extcon-usb-gpio.c in the future on acpi side? If you agree it, I'll revert it.
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Hi,
Quoted 72 lines · Chanwoo Choi
Hi Lu Baolu,
Quoted 63 lines · Andy Shevchenko
Quoted 49 lines · Chanwoo Choi
Quoted 35 lines · Andy Shevchenko
Quoted 14 lines · Chanwoo Choi
Quoted 8 lines · Andy Shevchenko
The commit
942c7924a51eintroduced a check for ACPI handle for the
device that never appears on any ACPI-enabled platform so far. It
seems
a confusion with extcon-intel-int3496 which does support ACPI- enabled
platforms.Only for the reason that there is no any usecase until now, and remove the confusion between extcon-usb-gpio and extcon-intel- int3496.
Should we revert it?Quoted 8 lines
I think that both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly. Also, the filename of extcon-intel-int3496 has specific name. Instead, extcon-usb-
gpio.c
is more common device driver.Can the
extcon-intel-int3496.csupport the everything on acpi side?For my understanding we have the only driver for now for USB mux in the
kernel for ACPI-enabled platforms.Besides confusion, it makes harder to fix a real bugs in at least GPIO
ACPI library since we need to amend any user of it first. While confusion is here, I can't do anything to not possible break the functionality of the driver in a real use case if any (I doubt there is
any in this particular case).Quoted 3 lines
So, my opinion here is "yes, we should revert it until we have a confirmation that there is a product which is using this among with ACPI" (which I doubt ever exists).
Because you told me there was not any use case of
extcon-usb-gpioc.con acpi side. But, I think that it is not enough as the reason.Because I already mentioned,
1.
"The both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly." It two driver are same operation and there is no use case on acpi side, I may agree your suggestion. But, in this case, they are different between two drivers.Quoted 5 lines
2.
Also, extcon-intel-int3496 has the specific name 'int3496'. I think that it only depends on the specific device driver on acpi side.
I don't think it cover all of use case on acpi side.Just one question: is there *real* existing device where ACPI table contains something related to extcon-usb-gpio?
I'm pretty sure the answer is no. Moreover, Lu pointed me out to the series which tried to update the driver in question to support int3496. Though it comes as a separate driver, thus that series was abandoned IIUC.
Quoted 6 lines
I really don't care if some dead confusing code will be left in some poor driver, at the end it's not my call.
P.S. We already spent enough time making a mountain out of a molehill. I rest my case.
Quoted 9 lines
OK. Just I want to receive the reply from Lu Baolu.
In the "extcon-usb-gpio ACPI support" mail thread,
I understood that Lu Baolu said that the related patches were abandoned.To Lu Baolu,
Don't you ever use theextcon-usb-gpio.cin the future on acpi side? If you agree it, I'll revert it.
I will not use extcon-usb-gpio.c in the future on acpi side AFAICS.
Best regards,
Lu Baolu
Hi Andy,
Quoted 5 lines · Andy Shevchenko
The commit
942c7924a51eintroduced a check for ACPI handle for the device that never appears on any ACPI-enabled platform so far. It seems a confusion with extcon-intel-int3496 which does support ACPI-enabled platforms.
Quoted 8 lines
Revert commit
942c7924a51eto avoid any confusion in the future.Cc Lu Baolu <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/extcon/extcon-usb-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Applied it on extcon-fixes branch.
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Quoted 12 lines · Chanwoo Choi
Hi Andy,
Quoted 9 lines · Andy Shevchenko
The commit
942c7924a51eintroduced a check for ACPI handle for the device that never appears on any ACPI-enabled platform so far. It seems
a confusion with extcon-intel-int3496 which does support ACPI- enabled
platforms.Revert commit
942c7924a51eto avoid any confusion in the future.
Quoted 8 lines
Quoted 6 lines
Cc Lu Baolu <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>---
drivers/extcon/extcon-usb-gpio.c | 3 +--1 file changed, 1 insertion(+), 2 deletions(-)Applied it on extcon-fixes branch.
Thanks!
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy