raid5-ppl: silence a misleading warning message
Subsystems (2)
PATCH 1/1 raid5-ppl: silence a misleading warning message
The "need_cache_flush" variable is never set to false. When the variable is true that means we print a warning message at the end of the function.
Fixes 3418d036c81d ("raid5-ppl: Partial Parity Log write logging implementation")
Signed-off-by Dan Carpenter <[email protected]>
drivers/md/raid5-ppl.c +1 -1
@@ -1070,7 +1070,7 @@ int ppl_init_log(struct r5conf *conf)struct mddev *mddev = conf->mddev;int ret =0 ;int i; -bool need_cache_flush; +bool need_cache_flush = false;pr_debug ("md/raid:%s: enabling distributed Partial Parity Log\n" ,mdname (conf->mddev));
Quoted 6 lines · Dan Carpenter
The "
need_cache_flush" variable is never set to false. When the variable is true that means we print a warning message at the end of the function.Fixes 3418d036c81d ("raid5-ppl: Partial Parity Log write logging implementation")Signed-off-by Dan Carpenter <[email protected]>
Good catch, thanks. I thought gcc would warn about such issues, I'll have to be more careful.
Reviewed-by Artur Paszkiewicz <[email protected]>
Shaohua Li
AppliedQuoted 6 lines · Dan Carpenter
The "
need_cache_flush" variable is never set to false. When the variable is true that means we print a warning message at the end of the function.Fixes 3418d036c81d ("raid5-ppl: Partial Parity Log write logging implementation")Signed-off-by Dan Carpenter <[email protected]>
applied, thanks!
Quoted 13 lines
drivers/md/raid5-ppl.c +1
-1@@ -1070,7 +1070,7 @@ int ppl_init_log(struct r5conf *conf)struct mddev *mddev = conf->mddev;int ret =0 ;int i; -bool need_cache_flush; +bool need_cache_flush = false;pr_debug ("md/raid:%s: enabling distributed Partial Parity Log\n" ,mdname (conf->mddev));