Skip to contentSkip to conversation

ARM: dts: add arm/arm64 include symlinks

PATCH New Heiko Stuebner 3 participants 4 messages Feb 26, 2017 – Mar 22, 2017

Subsystems (2)
Device tree bindings Arm Rockchip
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

PATCH 1/2 ARM: dts: add arm/arm64 include symlinks

Allow including of dtsi files in an architecture-independent manner. Some dtsi files may be shared between architectures and one suggestion was to have symlinks and let these includes get accessed via a

    #include <arm64/foo.dtsi>

So add the necessary symlinks for arm32.

Suggested-by Olof Johansson <[email protected]>
Signed-off-by Heiko Stuebner <[email protected]>

---
Suggested by Olof in response to the patch adding direct symlinks for cros-ec includes.

 arch/arm/boot/dts/include/arm   | 1 +
 arch/arm/boot/dts/include/arm64 | 1 +
 2 files changed, 2 insertions(+)
 create mode 120000 arch/arm/boot/dts/include/arm
 create mode 120000 arch/arm/boot/dts/include/arm64
arch/arm/boot/dts/include/arm new file +1 -0
new file mode 120000
index 000000000000..a96aa0ea9d8c
@@ -0,0 +1 @@
+..
\ No newline at end of file
arch/arm/boot/dts/include/arm64 new file +1 -0
new file mode 120000
index 000000000000..074a835fca3e
@@ -0,0 +1 @@
+../../../../arm64/boot/dts
\ No newline at end of file
Signature · 1 line
2.11.0
author maintainer
#1 lore raw

PATCH 2/2 arm64: dts: add arm/arm64 include symlinks

Allow including of dtsi files in an architecture-independent manner. Some dtsi files may be shared between architectures and one suggestion was to have symlinks and let these includes get accessed via a

    #include <arm64/foo.dtsi>

So add the necessary symlinks for arm32.

Suggested-by Olof Johansson <[email protected]>
Signed-off-by Heiko Stuebner <[email protected]>

---
Suggested by Olof in response to the patch adding direct symlinks for cros-ec includes.

Tested with adapted rk3399-Gru dtsi files and while we only need this arm64 version right now, it might make sense to already have both the arm32 and arm64 versions ready.

 arch/arm64/boot/dts/include/arm   | 1 +
 arch/arm64/boot/dts/include/arm64 | 1 +
 2 files changed, 2 insertions(+)
 create mode 120000 arch/arm64/boot/dts/include/arm
 create mode 120000 arch/arm64/boot/dts/include/arm64
arch/arm64/boot/dts/include/arm new file +1 -0
new file mode 120000
index 000000000000..cf63d80e2b93
@@ -0,0 +1 @@
+../../../../arm/boot/dts
\ No newline at end of file
arch/arm64/boot/dts/include/arm64 new file +1 -0
new file mode 120000
index 000000000000..a96aa0ea9d8c
@@ -0,0 +1 @@
+..
\ No newline at end of file
Signature · 1 line
2.11.0
#2 lore raw

PATCH 2/2 arm64: dts: add arm/arm64 include symlinks

Hi,

Quoted 8 lines · Heiko Stuebner

Allow including of dtsi files in an architecture-independent manner. Some dtsi files may be shared between architectures and one suggestion was to have symlinks and let these includes get accessed via a

    #include <arm64/foo.dtsi>

So add the necessary symlinks for arm32.

Suggested-by Olof Johansson <[email protected]>
Signed-off-by Heiko Stuebner <[email protected]>
Quoted 7 lines

---
Suggested by Olof in response to the patch adding direct symlinks for cros-ec includes.

Tested with adapted rk3399-Gru dtsi files and while we only need this arm64 version right now, it might make sense to already have both the arm32 and arm64 versions ready.

FWIW, tested fine here too (for the same platform).

I guess this works fine, if it makes people happy. It also allows some weird #include paths. e.g.:

#include <arm64/include/arm/include/arm64/rockchip/rk3399.dtsi>

I guess we can call that an entertaining feature, and not a bug?

Reviewed-by Brian Norris <[email protected]>
Tested-by Brian Norris <[email protected]>

Where should this go? I'd like not to wait another few months before sending my Gru/Kevin DTS again.

Brian

Quoted 25 lines
 arch/arm64/boot/dts/include/arm   | 1 +
 arch/arm64/boot/dts/include/arm64 | 1 +
 2 files changed, 2 insertions(+)
 create mode 120000 arch/arm64/boot/dts/include/arm
 create mode 120000 arch/arm64/boot/dts/include/arm64
arch/arm64/boot/dts/include/arm new file +1 -0
new file mode 120000
index 000000000000..cf63d80e2b93
@@ -0,0 +1 @@
+../../../../arm/boot/dts
\ No newline at end of file
arch/arm64/boot/dts/include/arm64 new file +1 -0
new file mode 120000
index 000000000000..a96aa0ea9d8c
@@ -0,0 +1 @@
+..
\ No newline at end of file
Signature · 1 line
2.11.0
#3 lore raw

PATCH 2/2 arm64: dts: add arm/arm64 include symlinks

Quoted 26 lines · Brian Norris

Hi,

Quoted 8 lines · Heiko Stuebner

Allow including of dtsi files in an architecture-independent manner. Some dtsi files may be shared between architectures and one suggestion was to have symlinks and let these includes get accessed via a

    #include <arm64/foo.dtsi>

So add the necessary symlinks for arm32.

Suggested-by Olof Johansson <[email protected]>
Signed-off-by Heiko Stuebner <[email protected]>
Quoted 7 lines

---
Suggested by Olof in response to the patch adding direct symlinks for cros-ec includes.

Tested with adapted rk3399-Gru dtsi files and while we only need this arm64 version right now, it might make sense to already have both the arm32 and arm64 versions ready.

FWIW, tested fine here too (for the same platform).

I guess this works fine, if it makes people happy. It also allows some weird #include paths. e.g.:

#include <arm64/include/arm/include/arm64/rockchip/rk3399.dtsi>

Quoted 7 lines

I guess we can call that an entertaining feature, and not a bug?

Reviewed-by Brian Norris <[email protected]>
Tested-by Brian Norris <[email protected]>

Where should this go? I'd like not to wait another few months before sending my Gru/Kevin DTS again.

Checked into shared/dt-symlinks on the arm-soc repo now (and merged into next/dt and next/dt64). Please use that branch as a base for DT material that will use this.

-Olof