Skip to contentSkip to conversation

sfc: cleanup a condition in efx_udp_tunnel_del()

PATCH In review Dan Carpenter 3 participants 3 messages Mar 22, 2017 – Mar 23, 2017

Subsystems (4)
Networking Network drivers Kernel janitors Sfc network driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 sfc: cleanup a condition in efx_udp_tunnel_del()

Presumably if there is an "add" function, there is also a "del" function. But it causes a static checker warning because it looks like a common cut and paste bug.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/sfc/efx.c +1 -1
index 8c4c273643dc..203c8c3752e7 100644
@@ -2404,7 +2404,7 @@ static void efx_udp_tunnel_del(struct net_device *dev, struct udp_tunnel_info *t
 	tnl.type = (u16)efx_tunnel_type;
 	tnl.port = ti->port;
 
-	if (efx->type->udp_tnl_add_port)
+	if (efx->type->udp_tnl_del_port)
 		(void)efx->type->udp_tnl_del_port(efx, tnl);
 }