Skip to contentSkip to conversation

drm/i915/gvt: replace the gvt_err with gvt_vgpu_err

bug report Dan Carpenter 1 participant 1 message Mar 22, 2017

lore
Share & tools
lore
#0 lore raw

Hello Tina Zhang,

This is a semi-automatic email about new static checker warnings.

The patch 695fbc08d80f: "drm/i915/gvt: replace the gvt_err with gvt_vgpu_err" from Mar 10, 2017, leads to the following Smatch complaint:

drivers/gpu/drm/i915/gvt/kvmgt.c:1344 kvmgt_guest_exit()
warn: variable dereferenced before check 'info' (see line 1342)

drivers/gpu/drm/i915/gvt/kvmgt.c
1341 {

  1342		struct intel_vgpu *vgpu = info->vgpu;
                                          ^^^^^^^^^^

Patch adds a new dereference.

1343

  1344		if (!info) {
                    ^^^^^

Existing check.

  1345			gvt_vgpu_err("kvmgt_guest_info invalid\n");
  1346			return false;

regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx