Skip to contentSkip to conversation

tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

PATCH Superseded Timur Tabi 2 participants 4 messages Feb 28, 2017 – Mar 22, 2017

Subsystems (2)
ACPI TTY layer and serial drivers
lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH v2 1/1 tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44, the ACPI oem_revision field is actually set to 1, not 0.

Fixes d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
Tested-by Manoj Iyer <[email protected]>
Signed-off-by Timur Tabi <[email protected]>
---
 drivers/acpi/spcr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/spcr.c +1 -1
index 2b5d0fa..2051a8c 100644
@@ -30,7 +30,7 @@ static bool qdf2400_erratum_44_present(struct acpi_table_header *h)
 		return true;
 
 	if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
-			h->oem_revision == 0)
+			h->oem_revision == 1)
 		return true;
 
 	return false;
Signature · 3 lines
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
author
#1 lore raw

PATCH v2 1/1 tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Quoted 7 lines · Timur Tabi

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44, the ACPI oem_revision field is actually set to 1, not 0.

Fixes d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
Tested-by Manoj Iyer <[email protected]>
Signed-off-by Timur Tabi <[email protected]>

Greg, this is a critical fix for our platform. Can you please pick it up for 4.11-rc3? Thank you.

Signature · 3 lines
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
author
#2 lore raw

PATCH v2 1/1 tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Quoted 11 lines · Timur Tabi
Quoted 7 lines · Timur Tabi

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44, the ACPI oem_revision field is actually set to 1, not 0.

Fixes d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
Tested-by Manoj Iyer <[email protected]>
Signed-off-by Timur Tabi <[email protected]>

Greg, this is a critical fix for our platform. Can you please pick it up for 4.11-rc3? Thank you.

Ok, how about 4.11-rc4?

Signature · 3 lines
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
#3 lore raw

PATCH v2 1/1 tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Quoted 7 lines · Timur Tabi
Quoted 6 lines · Timur Tabi
Quoted 5 lines · Timur Tabi

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44, the ACPI oem_revision field is actually set to 1, not 0.

Fixes d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Tested-by Manoj Iyer <[email protected]>
Signed-off-by Timur Tabi <[email protected]>

Greg, this is a critical fix for our platform. Can you please pick it up for 4.11-rc3? Thank you.

Ok, how about 4.11-rc4?

It's in the queue in tty-linus, right? If so, that should make it into 4.11-final.

thanks,

greg k-h