Skip to contentSkip to conversation

leptonica: make package description more accurate

PATCH New Gilles Talis 2 participants 4 messages Mar 22, 2017 – Mar 23, 2017

lore
Share & tools
lore

Gilles Talis

author
#0 lore raw

PATCH 1/2 leptonica: make package description more accurate

Signed-off-by Gilles Talis <[email protected]>
---
 package/leptonica/Config.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
package/leptonica/Config.in +1 -3
index a4053a3..ec4920c 100644
@@ -1,8 +1,6 @@
 config BR2_PACKAGE_LEPTONICA
 	bool "leptonica"
 	help
-	  Leptonica is a pedagogically-oriented open source site containing
-	  software that is broadly useful for image processing and image
-	  analysis applications.
+	  Leptonica is an image processing and image analysis library.
 
 	  http://www.leptonica.org/
Signature · 1 line
2.5.0
author
#1 lore raw

PATCH 2/2 tesseract-ocr: needs wchar support

Fixes:
http://autobuild.buildroot.net/results/66e44564aac79c1c47755f6d158663317a5ffe09

Signed-off-by Gilles Talis <[email protected]>
---
 package/tesseract-ocr/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/tesseract-ocr/Config.in +3 -2
index d4c23fb..3afaca7 100644
@@ -1,7 +1,7 @@
-comment "tesseract-ocr needs a toolchain w/ threads, C++, gcc >= 4.8, dynamic library"
+comment "tesseract-ocr needs a toolchain w/ threads, C++, gcc >= 4.8, dynamic library, wchar"
 	depends on BR2_USE_MMU
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || BR2_STATIC_LIBS
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
 
 menuconfig BR2_PACKAGE_TESSERACT_OCR
 	bool "tesseract-ocr"

@@ -10,6 +10,7 @@ menuconfig BR2_PACKAGE_TESSERACT_OCR
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
 	depends on BR2_USE_MMU # fork()
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_USE_WCHAR
 	select BR2_PACKAGE_LEPTONICA
 	help
 	  Tesseract is an OCR (Optical Character Recognition) engine,
Signature · 1 line
2.5.0
#2 lore raw

PATCH 1/2 leptonica: make package description more accurate

In reply to Gilles Talis

Hello,

Quoted 4 lines · Gilles Talis
Signed-off-by Gilles Talis <[email protected]>
---
 package/leptonica/Config.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Both patches applied, thanks!

Note that we have a number of build failures on the leptonica package:

http://autobuild.buildroot.net/?reason=leptonica-1.74.1

These occur in static linking scenarios, because leptonica configure script is not using pkg-config to find the TIFF library, so it doesn't know about the transitive dependencies of the TIFF library. Switching to PKG_CHECK_MODULES() to discover the TIFF library would solve this I believe.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#3 lore raw

PATCH 1/2 leptonica: make package description more accurate

Hi,

2017-03-22 22:45 GMT+01:00 Thomas Petazzoni
<[email protected]>:

Quoted 12 lines

Hello,

Quoted 4 lines · Gilles Talis
Signed-off-by Gilles Talis <[email protected]>
---
 package/leptonica/Config.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Both patches applied, thanks!

Note that we have a number of build failures on the leptonica package:

Quoted 7 lines

http://autobuild.buildroot.net/?reason=leptonica-1.74.1

These occur in static linking scenarios, because leptonica configure script is not using pkg-config to find the TIFF library, so it doesn't know about the transitive dependencies of the TIFF library. Switching to PKG_CHECK_MODULES() to discover the TIFF library would solve this I believe.

Will check this. Thanks for the tip!

Best regards,
Gilles