Skip to contentSkip to conversation

ARM: dts: aspeed: zaius: Enable 12V Delta Power Brick.

PATCH In review Peter Hanson 2 participants 3 messages Mar 23, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: zaius: Enable 12V Delta Power Brick.

---
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +7 -1
index 3bd70ed810af..4fd27617bb3a 100644
@@ -269,7 +269,13 @@
 	/* Master selector PCA9541A @70h (other master: CPU0)
 	 *   LM5066I PMBUS @10h
 	 */
-	/* 12V SMPS Q54SH12050NNDH @61h */
+
+	/* 12V SMPS Q54SJ12050 @61h */
+	q54sj12050@61 {
+		compatible = "delta,dps800";
+		reg = <0x61>;
+	};
+
 	/* CPU0 VR ISL68137 0.7V, 0.96V PMBUS @64h */
 	/* CPU0 VR ISL68137 1.2V CH03 PMBUS @40h */
 	/* CPU0 VR ISL68137 0.8V PMBUS @60h */
Signature · 1 line
2.12.1.500.gab5fba24ee-goog
maintainer
#1 lore raw

Hello Peter,

Welcome to the project. Congrats on your success with the git tools, v2 looks much better. There's some tips and tricks on the wiki for next time:

https://github.com/openbmc/linux/wiki/SubmittingPatches#use-the-git-tools

Quoted 10 lines · Peter Hanson
---
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +0 -0
index 3bd70ed810af..4fd27617bb3a 100644

arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts line 274

Quoted 7 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +3 -1
@@ -269,7 +269,13 @@
        /* Master selector PCA9541A @70h (other master: CPU0)
         *   LM5066I PMBUS @10h
         */
-       /* 12V SMPS Q54SH12050NNDH @61h */
+
+       /* 12V SMPS Q54SJ12050 @61h */
+       q54sj12050@61 {

This is an interesting name. I assume it means something to you? My favourite search engine came up empty.

You're free to use whatever name you think is appropriate for the node, so if you want to make it name like "power-brick" you could.

If you're happy with this name then that's fine too. I'll wait for Xo's ack and apply it.

Cheers,

Joel

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +4 -1
+               compatible = "delta,dps800";
+               reg = <0x61>;
+       };
+
        /* CPU0 VR ISL68137 0.7V, 0.96V PMBUS @64h */
        /* CPU0 VR ISL68137 1.2V CH03 PMBUS @40h */
        /* CPU0 VR ISL68137 0.8V PMBUS @60h */
--

2.12.1.500.gab5fba24ee-goog

#2 lore raw
Quoted 30 lines · Joel Stanley

Hello Peter,

Welcome to the project. Congrats on your success with the git tools, v2 looks much better. There's some tips and tricks on the wiki for next time:

https://github.com/openbmc/linux/wiki/SubmittingPatches#use-the-git-tools

Quoted 10 lines · Peter Hanson
---
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +0 -0
index 3bd70ed810af..4fd27617bb3a 100644

arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts line 274

Quoted 7 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +3 -1
@@ -269,7 +269,13 @@
        /* Master selector PCA9541A @70h (other master: CPU0)
         *   LM5066I PMBUS @10h
         */
-       /* 12V SMPS Q54SH12050NNDH @61h */
+
+       /* 12V SMPS Q54SJ12050 @61h */
+       q54sj12050@61 {

This is an interesting name. I assume it means something to you? My favourite search engine came up empty.

Quoted 2 lines

You're free to use whatever name you think is appropriate for the node, so if you want to make it name like "power-brick" you could.

It is (allegedly) the part number I tested with.

I prefer your idea. The Delta site references to quite a few related parts, any of which should work the same, as far as pmbus is concerned. Incoming!

Quoted 17 lines

If you're happy with this name then that's fine too. I'll wait for Xo's ack and apply it.

Cheers,

Joel

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +4 -1
+               compatible = "delta,dps800";
+               reg = <0x61>;
+       };
+
        /* CPU0 VR ISL68137 0.7V, 0.96V PMBUS @64h */
        /* CPU0 VR ISL68137 1.2V CH03 PMBUS @40h */
        /* CPU0 VR ISL68137 0.8V PMBUS @60h */
--

2.12.1.500.gab5fba24ee-goog