Skip to contentSkip to conversation

fix udma_to_device_barrier on aarch64

PATCH In review Jarod Wilson 2 participants 2 messages Mar 23, 2017 1 message not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix udma_to_device_barrier on aarch64

The definition for udma_to_device_barrier on aarch64 is missing. Looks like an oversight in the commit that removed the old barrier macros and added this one.

Fixes 85a5529dead5 ("Remove the old barrier macros")
CC Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
 util/udma_barrier.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
util/udma_barrier.h +1 -1
index 86578af5..9932a687 100644
@@ -93,7 +93,7 @@
 #elif defined(__sparc_v9__)
 #define udma_to_device_barrier() asm volatile("membar #StoreStore" ::: "memory")
 #elif defined(__aarch64__)
-#define wmb() asm volatile("dsb st" ::: "memory");
+#define udma_to_device_barrier() asm volatile("dsb st" ::: "memory");
 #elif defined(__sparc__) || defined(__s390x__)
 #define udma_to_device_barrier() asm volatile("" ::: "memory")
 #else
Signature · 6 lines
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20170323021224.35722-1-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org

#2 lore raw
Quoted 14 lines · Jarod Wilson

The definition for udma_to_device_barrier on aarch64 is missing. Looks like an oversight in the commit that removed the old barrier macros and added this one.

Fixes 85a5529dead5 ("Remove the old barrier macros")
CC Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
 util/udma_barrier.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
util/udma_barrier.h +1 -0
index 86578af5..9932a687 100644
+++ b/util/udma_barrier.h

util/udma_barrier.h line 99

Quoted 8 lines
util/udma_barrier.h +1 -1
@@ -93,7 +93,7 @@
 #elif defined(__sparc_v9__)
 #define udma_to_device_barrier() asm volatile("membar #StoreStore" ::: "memory")
 #elif defined(__aarch64__)
-#define wmb() asm volatile("dsb st" ::: "memory");
+#define udma_to_device_barrier() asm volatile("dsb st" ::: "memory");
 #elif defined(__sparc__) || defined(__s390x__)
 #define udma_to_device_barrier() asm volatile("" ::: "memory")
 #else

Doh, yep my bad.

https://github.com/linux-rdma/rdma-core/pull/106

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html