Skip to contentSkip to conversation

ARC patch suggestion

PATCH Waldemar Brodkorb 3 participants 4 messages Mar 23, 2017 – Mar 24, 2017 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

Hi,

I want to success following change:

Quoted 1 line

From cde74b83f9b204bf56f304224654e4993dc56efc Mon Sep 17 00:00:00 2001

From: Waldemar Brodkorb <[email protected]>
Date: Tue, 21 Mar 2017 20:04:21 +0100
Subject: [PATCH 2/2] ARC: remove special CFLAGS/LDFLAGS handling

Either toolchain defaults or buildsystems should provide the architecture specific CFLAGS and LDFLAGS.

Signed-off-by Waldemar Brodkorb <wbx at openadk.org>
---
 Rules.mak                |  6 ------
 extra/Configs/Config.arc | 18 ------------------
 2 files changed, 24 deletions(-)
Rules.mak +0 -6
index ae78f44..9c481c3 100644
@@ -508,12 +508,6 @@ ifeq ($(TARGET_ARCH),c6x)
 	CPU_LDFLAGS-y += $(CPU_CFLAGS)
 endif
 
-ifeq ($(TARGET_ARCH),arc)
-	CPU_CFLAGS-$(CONFIG_ARC_CPU_700) += -mA7
-	CPU_CFLAGS-$(CONFIG_ARC_CPU_HS) += -mcpu=archs
-	CPU_LDFLAGS-y += $(CPU_CFLAGS) -marclinux
-endif
-
 $(eval $(call check-gcc-var,$(PIEFLAG_NAME)))
 PIEFLAG := $(CFLAG_$(PIEFLAG_NAME))
 ifeq ($(PIEFLAG),)
extra/Configs/Config.arc +0 -18
index c263dbf..ebbde2e 100644
@@ -10,24 +10,6 @@ config FORCE_OPTIONS_FOR_ARCH
 	default y
 	select ARCH_ANY_ENDIAN
 
-choice
-	prompt "Target Processor Type"
-	default CONFIG_ARC_CPU_700
-
-config CONFIG_ARC_CPU_700
-	bool "ARC700"
-	select ARCH_HAS_MMU
-	help
-	  ARCompact ISA based ARC CPU
-
-config CONFIG_ARC_CPU_HS
-	bool "ARC-HS"
-	select ARCH_HAS_MMU
-	help
-	  Next Generation ARCv2 ISA based Processors
-
-endchoice
-
 config CONFIG_ARC_HAS_ATOMICS
 	bool "Support for LLOCK/SCOND instructions"
 	default y
Signature · 7 lines
2.1.4


Okay to push?

best regards
 Waldemar
Acked-by
#1 lore raw

+CC ARC gnu folks, Anton who maintains an internal build system

Quoted 11 lines · Waldemar Brodkorb

Hi,

I want to success following change:

From cde74b83f9b204bf56f304224654e4993dc56efc Mon Sep 17 00:00:00 2001
From: Waldemar Brodkorb <wbx at openadk.org>
Date: Tue, 21 Mar 2017 20:04:21 +0100
Subject: [PATCH 2/2] ARC: remove special CFLAGS/LDFLAGS handling

Either toolchain defaults or buildsystems should provide the architecture specific CFLAGS and LDFLAGS.

Seems a decent cleanup to me !

Acked-by Vineet Gupta <vgupta at synopsys.com>

@Anton, @Claudiu, @Cupertino any thoughts : for / against

Quoted 53 lines
Signed-off-by Waldemar Brodkorb <wbx at openadk.org>
---
 Rules.mak                |  6 ------
 extra/Configs/Config.arc | 18 ------------------
 2 files changed, 24 deletions(-)
Rules.mak +0 -6
index ae78f44..9c481c3 100644
@@ -508,12 +508,6 @@ ifeq ($(TARGET_ARCH),c6x)
 	CPU_LDFLAGS-y += $(CPU_CFLAGS)
 endif
 
-ifeq ($(TARGET_ARCH),arc)
-	CPU_CFLAGS-$(CONFIG_ARC_CPU_700) += -mA7
-	CPU_CFLAGS-$(CONFIG_ARC_CPU_HS) += -mcpu=archs
-	CPU_LDFLAGS-y += $(CPU_CFLAGS) -marclinux
-endif
-
 $(eval $(call check-gcc-var,$(PIEFLAG_NAME)))
 PIEFLAG := $(CFLAG_$(PIEFLAG_NAME))
 ifeq ($(PIEFLAG),)
extra/Configs/Config.arc +0 -18
index c263dbf..ebbde2e 100644
@@ -10,24 +10,6 @@ config FORCE_OPTIONS_FOR_ARCH
 	default y
 	select ARCH_ANY_ENDIAN
 
-choice
-	prompt "Target Processor Type"
-	default CONFIG_ARC_CPU_700
-
-config CONFIG_ARC_CPU_700
-	bool "ARC700"
-	select ARCH_HAS_MMU
-	help
-	  ARCompact ISA based ARC CPU
-
-config CONFIG_ARC_CPU_HS
-	bool "ARC-HS"
-	select ARCH_HAS_MMU
-	help
-	  Next Generation ARCv2 ISA based Processors
-
-endchoice
-
 config CONFIG_ARC_HAS_ATOMICS
 	bool "Support for LLOCK/SCOND instructions"
 	default y
#2 lore raw

Hi,

Quoted 15 lines

+CC ARC gnu folks, Anton who maintains an internal build system

Quoted 5 lines · Waldemar Brodkorb

Hi,

I want to success following change:

From cde74b83f9b204bf56f304224654e4993dc56efc Mon Sep 17 00:00:00

2001

Quoted 4 lines

From: Waldemar Brodkorb <wbx at openadk.org>
Date: Tue, 21 Mar 2017 20:04:21 +0100
Subject: [PATCH 2/2] ARC: remove special CFLAGS/LDFLAGS handling

Quoted 9 lines
Quoted 2 lines

Either toolchain defaults or buildsystems should provide the architecture specific CFLAGS and LDFLAGS.

Seems a decent cleanup to me !

Acked-by Vineet Gupta <vgupta at synopsys.com>

@Anton, @Claudiu, @Cupertino any thoughts : for / against

AK: No issue by me, but I haven't tried to build test this.

Anton

#3 lore raw

Hi,

I am preparing for next release.
I want to push attached cleanup of defconfigs as discussed earlier on the uClibc-ng mailinglist.

@Anton: so you need to use your own defconfig for your toolchain builds. I suggest to be similar to the Buildroot config.

best regards
Waldemar

Anton Kolesov wrote,

Quoted 22 lines

Hi,

Quoted 20 lines

+CC ARC gnu folks, Anton who maintains an internal build system

Quoted 5 lines · Waldemar Brodkorb

Hi,

I want to success following change:

From cde74b83f9b204bf56f304224654e4993dc56efc Mon Sep 17 00:00:00

2001

Quoted 6 lines

From: Waldemar Brodkorb <wbx at openadk.org>
Date: Tue, 21 Mar 2017 20:04:21 +0100
Subject: [PATCH 2/2] ARC: remove special CFLAGS/LDFLAGS handling

Either toolchain defaults or buildsystems should provide the architecture specific CFLAGS and LDFLAGS.

Seems a decent cleanup to me !

Quoted 8 lines
Quoted 4 lines
Acked-by Vineet Gupta <vgupta at synopsys.com>

@Anton, @Claudiu, @Cupertino any thoughts : for / against

AK: No issue by me, but I haven't tried to build test this.

Anton

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-unify-defconfigs.patch
Type: text/x-diff
Size: 15004 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-snps-arc/attachments/20170324/0455b589/attachment.bin>