ALSA: au88x0: avoid theoretical uninitialized access
PATCH 1/1 ALSA: au88x0: avoid theoretical uninitialized access
The latest gcc-7.0.1 snapshot points out that we if nr_ch is zero, we never initialize some variables:
sound/pci/au88x0/au88x0_core.c: In function 'vortex_adb_allocroute':sound/pci/au88x0/au88x0_core.c:2304:68: error: 'mix[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized] sound/pci/au88x0/au88x0_core.c:2305:58: error: 'src[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
I assume this can never happen in practice, but adding a check here doesn't hurt either and avoids the warning. The code has been unchanged since the start of git history.
--- sound/pci/au88x0/au88x0_core.c | 3 +++ 1 file changed, 3 insertions(+)
sound/pci/au88x0/au88x0_core.c +3 -0
@@ -2279,6 +2279,9 @@ vortex_adb_allocroute(vortex_t *vortex, int dma, int nr_ch, int dir, } else { int src[2], mix[2]; + if (nr_ch < 1) + return -EINVAL; + /* Get SRC and MIXER hardware resources. */ for (i = 0; i < nr_ch; i++) { if ((mix[i] =
Signature · 1 line
2.9.0
Quoted 8 lines · Arnd Bergmann
The latest gcc-7.0.1 snapshot points out that we if
nr_chis zero, we never initialize some variables:
sound/pci/au88x0/au88x0_core.c: In function 'vortex_adb_allocroute':sound/pci/au88x0/au88x0_core.c:2304:68: error: 'mix[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]sound/pci/au88x0/au88x0_core.c:2305:58: error: 'src[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Quoted 5 lines
I assume this can never happen in practice, but adding a check here doesn't hurt either and avoids the warning. The code has been unchanged since the start of git history.
Signed-off-by Arnd Bergmann <[email protected]>
Yeah, this shouldn't happen in practice, but better to cover. I applied the patch now. Thanks.
Takashi
Quoted 21 lines
--- sound/pci/au88x0/au88x0_core.c | 3 +++ 1 file changed, 3 insertions(+)sound/pci/au88x0/au88x0_core.c +3
-0@@ -2279,6 +2279,9 @@ vortex_adb_allocroute(vortex_t *vortex, int dma, int nr_ch, int dir, } else { int src[2], mix[2]; + if (nr_ch < 1) + return -EINVAL; + /* Get SRC and MIXER hardware resources. */ for (i = 0; i < nr_ch; i++) { if ((mix[i] =Signature · 1 line
2.9.0