Skip to contentSkip to conversation

drivers/staging/wilc1000: Fixing dev_err and removing dev_dbg calls for tracing

PATCH In review Pushkar Jambhlekar 2 participants 2 messages Mar 24, 2017 Staging

lore
Share & tools
lore

Pushkar Jambhlekar

author
#0 lore raw

PATCH 1/1 drivers/staging/wilc1000: Fixing dev_err and removing dev_dbg calls for tracing

dev_err: replacing function name with '%s' and __func__
dev_dbg: Removing calls which are used for tracing a function.

Signed-off-by Pushkar Jambhlekar <[email protected]>
---
 drivers/staging/wilc1000/wilc_sdio.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/staging/wilc1000/wilc_sdio.c +2 -6
index ad4eb0f..20dbc21 100644
@@ -74,7 +74,7 @@ static int wilc_sdio_cmd52(struct wilc *wilc, struct sdio_cmd52 *cmd)
 	sdio_release_host(func);
 
 	if (ret)
-		dev_err(&func->dev, "wilc_sdio_cmd52..failed, err(%d)\n", ret);
+		dev_err(&func->dev, "%s..failed, err(%d)\n", __func__, ret);
 	return ret;
 }
 

@@ -103,7 +103,7 @@ static int wilc_sdio_cmd53(struct wilc *wilc, struct sdio_cmd53 *cmd)
 	sdio_release_host(func);
 
 	if (ret)
-		dev_err(&func->dev, "wilc_sdio_cmd53..failed, err(%d)\n", ret);
+		dev_err(&func->dev, "%s..failed, err(%d)\n", __func__, ret);
 
 	return ret;
 }

@@ -243,15 +243,11 @@ static void wilc_sdio_disable_interrupt(struct wilc *dev)
 	struct sdio_func *func = container_of(dev->dev, struct sdio_func, dev);
 	int ret;
 
-	dev_dbg(&func->dev, "wilc_sdio_disable_interrupt IN\n");
-
 	sdio_claim_host(func);
 	ret = sdio_release_irq(func);
 	if (ret < 0)
 		dev_err(&func->dev, "can't release sdio_irq, err(%d)\n", ret);
 	sdio_release_host(func);
-
-	dev_info(&func->dev, "wilc_sdio_disable_interrupt OUT\n");
 }
 
 /********************************************
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 2 lines · Pushkar Jambhlekar

dev_err: replacing function name with '%s' and __func__
dev_dbg: Removing calls which are used for tracing a function.

That's two different things, so you need to send two different patches.

thanks,

greg k-h