mfd: cpcap: Add missing include dependencies

PATCH In review Sebastian Reichel 3 participants 10 messages Mar 24, 2017 – Mar 29, 2017

Subsystems (3)

Device tree bindings Multifunction devices (MFD) LED

lore

Share & tools

lore

Sebastian Reichel

author

2017-03-24 08:47 UTC #0 lore raw

PATCH v3 1/2 mfd: cpcap: Add missing include dependencies

This fixes compilation for files, that try to include the cpcap header in alphabetically sorted #include lists.

Acked-by Pavel Machek <[email protected]>

Acked-by Tony Lindgren <[email protected]>

Signed-off-by Sebastian Reichel <[email protected]>

---
Changes since PATCHv2:
- Add Acked-by from Tony & Pavel

---
 include/linux/mfd/motorola-cpcap.h | 3 +++
 1 file changed, 3 insertions(+)

include/linux/mfd/motorola-cpcap.h +3 -0

index 793aa695faa0..aefc49cb7ba9 100644
@@ -14,6 +14,9 @@
  * published by the Free Software Foundation.
  */
 
+#include <linux/device.h>
+#include <linux/regmap.h>
+
 #define CPCAP_VENDOR_ST		0
 #define CPCAP_VENDOR_TI		1

Signature · 1 line

2.11.0

Sebastian Reichel

author

2017-03-24 08:47 UTC #1 lore raw

PATCH v3 2/2 leds: cpcap: new driver

Motorola CPCAP is a PMIC (power management integrated circuit) found in multiple smartphones. This driver adds support for the chip's LED controllers. This introduces support for all controllers used by the Droid 4. According to Motorola's driver (no datasheets available) there a couple of more LED controllers. I did not add support for them, since I cannot verify that they work with my modifications.

Acked-by Pavel Machek <[email protected]>

Signed-off-by Sebastian Reichel <[email protected]>

---
Changes since PATCHv1:
- binding: reference common led binding for label
- drop DEBUG define (leftover)
- s/led/LED/g in debug prints
- order includes alphabetically
- introduce mutex, since led API is not atomic
- register led class after initial register setup
- use GPLv2+ in header
- drop unsupported leds from driver

Changes since PATCHv2:
- use standard defines instead CPCAP_LED_OFF and CPCAP_LED_ON

Notes:
- The "motorola" vendor-prefix is added via rtc-next

---
 .../devicetree/bindings/leds/cpcap-leds.txt        |  29 +++
 drivers/leds/Kconfig                               |   9 +
 drivers/leds/Makefile                              |   1 +
 drivers/leds/leds-cpcap.c                          | 239 +++++++++++++++++++++
 4 files changed, 278 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/cpcap-leds.txt
 create mode 100644 drivers/leds/leds-cpcap.c

Documentation/devicetree/bindings/leds/cpcap-leds.txt new file +29 -0

new file mode 100644
index 000000000000..ebf7cdc7f70c
@@ -0,0 +1,29 @@
+Motorola CPCAP PMIC LEDs
+------------------------
+
+This module is part of the CPCAP. For more details about the whole
+chip see Documentation/devicetree/bindings/mfd/motorola-cpcap.txt.
+
+Requires node properties:
+- compatible: should be one of
+   * "motorola,cpcap-led-mdl"		(Main Display Lighting)
+   * "motorola,cpcap-led-kl"		(Keyboard Lighting)
+   * "motorola,cpcap-led-adl"		(Aux Display Lighting)
+   * "motorola,cpcap-led-red"		(Red Triode)
+   * "motorola,cpcap-led-green"		(Green Triode)
+   * "motorola,cpcap-led-blue"		(Blue Triode)
+   * "motorola,cpcap-led-cf"		(Camera Flash)
+   * "motorola,cpcap-led-bt"		(Bluetooth)
+   * "motorola,cpcap-led-cp"		(Camera Privacy LED)
+- label: see Documentation/devicetree/bindings/leds/common.txt
+- vdd-supply: A phandle to the regulator powering the LED
+
+Example:
+
+&cpcap {
+	cpcap_led_red: red-led {
+		compatible = "motorola,cpcap-led-red";
+		label = "cpcap:red";
+		vdd-supply = <&sw5>;
+	};
+};

drivers/leds/Kconfig +9 -0

index 275f467956ee..043f02a4fe73 100644
@@ -76,6 +76,15 @@ config LEDS_BCM6358
 	  This option enables support for LEDs connected to the BCM6358
 	  LED HW controller accessed via MMIO registers.
 
+config LEDS_CPCAP
+	tristate "LED Support for Motorola CPCAP"
+	depends on LEDS_CLASS
+	depends on MFD_CPCAP
+	depends on OF
+	help
+	  This option enables support for LEDs offered by Motorola's
+	  CPCAP PMIC.
+
 config LEDS_LM3530
 	tristate "LCD Backlight driver for LM3530"
 	depends on LEDS_CLASS

drivers/leds/Makefile +1 -0

index 6b8273736478..333e84ce5d3b 100644
@@ -11,6 +11,7 @@ obj-$(CONFIG_LEDS_AAT1290)		+= leds-aat1290.o
 obj-$(CONFIG_LEDS_BCM6328)		+= leds-bcm6328.o
 obj-$(CONFIG_LEDS_BCM6358)		+= leds-bcm6358.o
 obj-$(CONFIG_LEDS_BD2802)		+= leds-bd2802.o
+obj-$(CONFIG_LEDS_CPCAP)		+= leds-cpcap.o
 obj-$(CONFIG_LEDS_LOCOMO)		+= leds-locomo.o
 obj-$(CONFIG_LEDS_LM3530)		+= leds-lm3530.o
 obj-$(CONFIG_LEDS_LM3533)		+= leds-lm3533.o

drivers/leds/leds-cpcap.c new file +239 -0

239 lines not on this page · raw message

Signature · 1 line

2.11.0

Jacek Anaszewski

2017-03-29 19:12 UTC #2 lore raw

Re: [PATCHv3 2/2] leds: cpcap: new driver

Hi Sebastian,

Documentation/devicetree/bindings/leds/cpcap-leds.txt

Quoted 39 lines · Sebastian Reichel

Motorola CPCAP is a PMIC (power management integrated circuit) found in multiple smartphones. This driver adds support for the chip's LED controllers. This introduces support for all controllers used by the Droid 4. According to Motorola's driver (no datasheets available) there a couple of more LED controllers. I did not add support for them, since I cannot verify that they work with my modifications.
Acked-by Pavel Machek <[email protected]>
Signed-off-by Sebastian Reichel <[email protected]>
---
Changes since PATCHv1:
- binding: reference common led binding for label
- drop DEBUG define (leftover)
- s/led/LED/g in debug prints
- order includes alphabetically
- introduce mutex, since led API is not atomic
- register led class after initial register setup
- use GPLv2+ in header
- drop unsupported leds from driver
Changes since PATCHv2:
- use standard defines instead CPCAP_LED_OFF and CPCAP_LED_ON
Notes:
- The "motorola" vendor-prefix is added via rtc-next
---
 .../devicetree/bindings/leds/cpcap-leds.txt        |  29 +++
 drivers/leds/Kconfig                               |   9 +
 drivers/leds/Makefile                              |   1 +
 drivers/leds/leds-cpcap.c                          | 239 +++++++++++++++++++++
 4 files changed, 278 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/cpcap-leds.txt
 create mode 100644 drivers/leds/leds-cpcap.c
Documentation/devicetree/bindings/leds/cpcap-leds.txt new file +0 -0
new file mode 100644
index 000000000000..ebf7cdc7f70c

I've changed cpcap-leds.txt to leds-cpcap.txt to match the prevailing pattern for LED DT bindings file names.

Please let me know if you have any objections.

Signature · 6 lines

Best regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Sebastian Reichel

author Acked-by

2017-03-29 21:38 UTC #3 lore raw

Re: [PATCHv3 2/2] leds: cpcap: new driver

Hi,

Quoted 44 lines · Jacek Anaszewski

Documentation/devicetree/bindings/leds/cpcap-leds.txt
Quoted 39 lines · Sebastian Reichel
Motorola CPCAP is a PMIC (power management integrated circuit) found in multiple smartphones. This driver adds support for the chip's LED controllers. This introduces support for all controllers used by the Droid 4. According to Motorola's driver (no datasheets available) there a couple of more LED controllers. I did not add support for them, since I cannot verify that they work with my modifications.
Acked-by Pavel Machek <[email protected]>
Signed-off-by Sebastian Reichel <[email protected]>
---
Changes since PATCHv1:
- binding: reference common led binding for label
- drop DEBUG define (leftover)
- s/led/LED/g in debug prints
- order includes alphabetically
- introduce mutex, since led API is not atomic
- register led class after initial register setup
- use GPLv2+ in header
- drop unsupported leds from driver
Changes since PATCHv2:
- use standard defines instead CPCAP_LED_OFF and CPCAP_LED_ON
Notes:
- The "motorola" vendor-prefix is added via rtc-next
---
 .../devicetree/bindings/leds/cpcap-leds.txt        |  29 +++
 drivers/leds/Kconfig                               |   9 +
 drivers/leds/Makefile                              |   1 +
 drivers/leds/leds-cpcap.c                          | 239 +++++++++++++++++++++
 4 files changed, 278 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/cpcap-leds.txt
 create mode 100644 drivers/leds/leds-cpcap.c
Documentation/devicetree/bindings/leds/cpcap-leds.txt new file +0 -0
new file mode 100644
index 000000000000..ebf7cdc7f70c
I've changed cpcap-leds.txt to leds-cpcap.txt to match the prevailing pattern for LED DT bindings file names.

Quoted 1 line

Please let me know if you have any objections.

Acked-by Sebastian Reichel <[email protected]>

-- Sebastian

Jacek Anaszewski

2017-03-24 20:44 UTC #4 lore raw

In reply to Sebastian Reichel

Hi Sebastianm

Quoted 19 lines · Sebastian Reichel

This fixes compilation for files, that try to include the cpcap header in alphabetically sorted #include lists.
Acked-by Pavel Machek <[email protected]>
Acked-by Tony Lindgren <[email protected]>
Signed-off-by Sebastian Reichel <[email protected]>
---
Changes since PATCHv2:
- Add Acked-by from Tony & Pavel
---
 include/linux/mfd/motorola-cpcap.h | 3 +++
 1 file changed, 3 insertions(+)
include/linux/mfd/motorola-cpcap.h +0 -0
index 793aa695faa0..aefc49cb7ba9 100644

include/linux/mfd/motorola-cpcap.h line 22

Quoted 9 lines

include/linux/mfd/motorola-cpcap.h +3 -0

@@ -14,6 +14,9 @@
  * published by the Free Software Foundation.
  */
 
+#include <linux/device.h>
+#include <linux/regmap.h>
+
 #define CPCAP_VENDOR_ST		0
 #define CPCAP_VENDOR_TI		1

Both patches applied to the for-next branch of linux-leds.git, thanks.

Signature · 2 lines

Best regards,
Jacek Anaszewski

Lee Jones

2017-03-27 14:26 UTC #5 lore raw

Quoted 22 lines · Jacek Anaszewski

Quoted 21 lines · Sebastian Reichel
This fixes compilation for files, that try to include the cpcap header in alphabetically sorted #include lists.
Acked-by Pavel Machek <[email protected]>
Acked-by Tony Lindgren <[email protected]>
Signed-off-by Sebastian Reichel <[email protected]>
---
Changes since PATCHv2:
- Add Acked-by from Tony & Pavel
---
 include/linux/mfd/motorola-cpcap.h | 3 +++
 1 file changed, 3 insertions(+)
include/linux/mfd/motorola-cpcap.h +0 -0
index 793aa695faa0..aefc49cb7ba9 100644
@@ -14,6 +14,9 @@
  * published by the Free Software Foundation.
  */
 

Quoted 7 lines

include/linux/mfd/motorola-cpcap.h line 21
Quoted 5 lines
include/linux/mfd/motorola-cpcap.h +3 -0
+#include <linux/device.h>
+#include <linux/regmap.h>
+
 #define CPCAP_VENDOR_ST		0
 #define CPCAP_VENDOR_TI		1
Both patches applied to the for-next branch of linux-leds.git, thanks.

Que?

Signature · 8 lines

Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jacek Anaszewski

2017-03-27 18:38 UTC #6 lore raw

Quoted 31 lines · Lee Jones

Quoted 22 lines · Jacek Anaszewski
Quoted 21 lines · Sebastian Reichel
This fixes compilation for files, that try to include the cpcap header in alphabetically sorted #include lists.
Acked-by Pavel Machek <[email protected]>
Acked-by Tony Lindgren <[email protected]>
Signed-off-by Sebastian Reichel <[email protected]>
---
Changes since PATCHv2:
- Add Acked-by from Tony & Pavel
---
 include/linux/mfd/motorola-cpcap.h | 3 +++
 1 file changed, 3 insertions(+)
include/linux/mfd/motorola-cpcap.h +0 -0
index 793aa695faa0..aefc49cb7ba9 100644
@@ -14,6 +14,9 @@
  * published by the Free Software Foundation.
  */
 
Quoted 7 lines
include/linux/mfd/motorola-cpcap.h line 21
Quoted 5 lines
include/linux/mfd/motorola-cpcap.h +3 -0
+#include <linux/device.h>
+#include <linux/regmap.h>
+
 #define CPCAP_VENDOR_ST		0
 #define CPCAP_VENDOR_TI		1
Both patches applied to the for-next branch of linux-leds.git, thanks.

Quoted 1 line

Que?

Ah, sorry, for some reason I silently assumed that Tony gave ack on your behalf :-) Probably due to lack of your activity in the subject and Tony's understanding thereof [0].

Can I have your ack for this patch going through LED tree then?

[0] https://lkml.org/lkml/2017/3/23/413

Signature · 2 lines

Best regards,
Jacek Anaszewski

Lee Jones

2017-03-28 08:16 UTC #7 lore raw

Quoted 32 lines · Jacek Anaszewski

Quoted 31 lines · Lee Jones
Quoted 29 lines · Jacek Anaszewski
Quoted 18 lines · Sebastian Reichel
This fixes compilation for files, that try to include the cpcap header in alphabetically sorted #include lists.
Acked-by Pavel Machek <[email protected]>
Acked-by Tony Lindgren <[email protected]>
Signed-off-by Sebastian Reichel <[email protected]>
---
Changes since PATCHv2:
- Add Acked-by from Tony & Pavel
---
 include/linux/mfd/motorola-cpcap.h | 3 +++
 1 file changed, 3 insertions(+)
include/linux/mfd/motorola-cpcap.h +0 -0
index 793aa695faa0..aefc49cb7ba9 100644
include/linux/mfd/motorola-cpcap.h line 21
Quoted 8 lines
include/linux/mfd/motorola-cpcap.h +3 -0
@@ -14,6 +14,9 @@
  * published by the Free Software Foundation.
  */
 
+#include <linux/device.h>
+#include <linux/regmap.h>
+
 #define CPCAP_VENDOR_ST		0
 #define CPCAP_VENDOR_TI		1
Both patches applied to the for-next branch of linux-leds.git, thanks.

Quoted 5 lines

Quoted 1 line
Que?
Ah, sorry, for some reason I silently assumed that Tony gave ack on your behalf :-) Probably due to lack of your activity in the subject and Tony's understanding thereof [0].

Right, but you still need to align with other Maintainers despite expert reviews, since they are in a better position to help avoid potential merge conflicts.

Quoted 1 line

Can I have your ack for this patch going through LED tree then?

I've gone one better and provided you with a pull-request. It's the best way to avoid merge conflict, subsequently upsetting the Big Penguin.

Signature · 4 lines

Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Lee Jones

2017-03-28 08:13 UTC #8 lore raw

[GIT PULL] Immutable branch between MFD and LEDS due for the v4.12 merge window

In reply to Sebastian Reichel

Enjoy!

The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201:

Linux 4.11-rc1 (2017-03-05 12:59:56 -0800)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-leds-v4.12

for you to fetch changes up to 4f9ab0c1570800002e77515888600ca2e3dce4a9:

mfd: cpcap: Add missing include dependencies (2017-03-28 09:09:50 +0100)

----------------------------------------------------------------
Immutable branch between MFD and LEDS due for the v4.12 merge window

----------------------------------------------------------------
Sebastian Reichel (1):
mfd: cpcap: Add missing include dependencies

 include/linux/mfd/motorola-cpcap.h | 3 +++
 1 file changed, 3 insertions(+)

Signature · 8 lines

Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jacek Anaszewski

2017-03-28 19:37 UTC #9 lore raw

Re: [GIT PULL] Immutable branch between MFD and LEDS due for the v4.12 merge window

Quoted 17 lines · Lee Jones

Enjoy!
The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201:
Linux 4.11-rc1 (2017-03-05 12:59:56 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-leds-v4.12
for you to fetch changes up to 4f9ab0c1570800002e77515888600ca2e3dce4a9:
mfd: cpcap: Add missing include dependencies (2017-03-28 09:09:50 +0100)
----------------------------------------------------------------
Immutable branch between MFD and LEDS due for the v4.12 merge window

Quoted 7 lines

----------------------------------------------------------------
Sebastian Reichel (1):
mfd: cpcap: Add missing include dependencies
 include/linux/mfd/motorola-cpcap.h | 3 +++
 1 file changed, 3 insertions(+)

Pulled, thanks.

Signature · 6 lines

Best regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html