Skip to contentSkip to conversation

staging: media: lirc: coding style fix use octal instead of symbolic permission

PATCH In review Chetan Sethi 2 participants 2 messages Feb 12, 2017 – Mar 24, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: media: lirc: coding style fix use octal instead of symbolic permission

This is a patch to the lirc_sir.c file that fixes coding style warning found by checkpatch.pl

---
 drivers/staging/media/lirc/lirc_sir.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/media/lirc/lirc_sir.c +4 -4
index c75ae43..426753e 100644
@@ -826,14 +826,14 @@ MODULE_AUTHOR("Milan Pikula");
 #endif
 MODULE_LICENSE("GPL");
 
-module_param(io, int, S_IRUGO);
+module_param(io, int, 0444);
 MODULE_PARM_DESC(io, "I/O address base (0x3f8 or 0x2f8)");
 
-module_param(irq, int, S_IRUGO);
+module_param(irq, int, 0444);
 MODULE_PARM_DESC(irq, "Interrupt (4 or 3)");
 
-module_param(threshold, int, S_IRUGO);
+module_param(threshold, int, 0444);
 MODULE_PARM_DESC(threshold, "space detection threshold (3)");
 
-module_param(debug, bool, S_IRUGO | S_IWUSR);
+module_param(debug, bool, 0644);
 MODULE_PARM_DESC(debug, "Enable debugging messages");
Signature · 1 line
2.7.4
#1 lore raw
Quoted 4 lines · Chetan Sethi

This is a patch to the lirc_sir.c file that fixes coding style warning found by checkpatch.pl

Another patch was merged which already fixed this, I'm sorry.

Sean

Quoted 29 lines
---
 drivers/staging/media/lirc/lirc_sir.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/media/lirc/lirc_sir.c +4 -4
index c75ae43..426753e 100644
@@ -826,14 +826,14 @@ MODULE_AUTHOR("Milan Pikula");
 #endif
 MODULE_LICENSE("GPL");
 
-module_param(io, int, S_IRUGO);
+module_param(io, int, 0444);
 MODULE_PARM_DESC(io, "I/O address base (0x3f8 or 0x2f8)");
 
-module_param(irq, int, S_IRUGO);
+module_param(irq, int, 0444);
 MODULE_PARM_DESC(irq, "Interrupt (4 or 3)");
 
-module_param(threshold, int, S_IRUGO);
+module_param(threshold, int, 0444);
 MODULE_PARM_DESC(threshold, "space detection threshold (3)");
 
-module_param(debug, bool, S_IRUGO | S_IWUSR);
+module_param(debug, bool, 0644);
 MODULE_PARM_DESC(debug, "Enable debugging messages");
Signature · 1 line
2.7.4