staging: media: davinci_vpfe: Replace a bit shift.
Subsystems (2)
PATCH v3 1/1 staging: media: davinci_vpfe: Replace a bit shift.
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by Arushi Singhal <[email protected]>
---
changes in v3
- change the subject.
- remove extra parenthesis.
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +- drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +- drivers/staging/media/davinci_vpfe/dm365_isif.c | 10 +++++----- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 6 +++--- 4 files changed, 10 insertions(+), 10 deletions(-)
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +1 -1
@@ -1815,7 +1815,7 @@ vpfe_ipipe_init(struct vpfe_ipipe_device *ipipe, struct platform_device *pdev)v4l2_subdev_init (sd, &ipipe_v4l2_ops); sd->internal_ops = &ipipe_v4l2_internal_ops;strlcpy (sd->name,"DAVINCI IPIPE" ,sizeof (sd->name)); - sd->grp_id =1 <<16 ;/* group ID for davinci subdevs */ + sd->grp_id =BIT (16 );/* group ID for davinci subdevs */ v4l2_set_subdevdata (sd, ipipe); sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ;
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c +1 -1
@@ -1021,7 +1021,7 @@ int vpfe_ipipeif_init(struct vpfe_ipipeif_device *ipipeif, sd->internal_ops = &ipipeif_v4l2_internal_ops;strlcpy (sd->name,"DAVINCI IPIPEIF" ,sizeof (sd->name)); - sd->grp_id =1 <<16 ;/* group ID for davinci subdevs */ + sd->grp_id =BIT (16 );/* group ID for davinci subdevs */ v4l2_set_subdevdata (sd, ipipeif);
drivers/staging/media/davinci_vpfe/dm365_isif.c +5 -5
@@ -821,7 +821,7 @@ isif_config_dfc(struct vpfe_isif_device *isif, struct vpfe_isif_dfc *vdfc)/* Correct whole line or partial */ if (vdfc->corr_whole_line) - val |=1 <<ISIF_VDFC_CORR_WHOLE_LN_SHIFT ; + val |=BIT (ISIF_VDFC_CORR_WHOLE_LN_SHIFT );/* level shift value */ val |= (vdfc->def_level_shift & ISIF_VDFC_LEVEL_SHFT_MASK) <<
@@ -849,7 +849,7 @@ isif_config_dfc(struct vpfe_isif_device *isif, struct vpfe_isif_dfc *vdfc) val =isif_read (isif->isif_cfg.base_addr,DFCMEMCTL );/* set DFCMARST and set DFCMWR */ - val |=1 <<ISIF_DFCMEMCTL_DFCMARST_SHIFT ; + val |=BIT (ISIF_DFCMEMCTL_DFCMARST_SHIFT ); val |=1 ;isif_write (isif->isif_cfg.base_addr, val,DFCMEMCTL );
@@ -880,7 +880,7 @@ isif_config_dfc(struct vpfe_isif_device *isif, struct vpfe_isif_dfc *vdfc) } val =isif_read (isif->isif_cfg.base_addr,DFCMEMCTL );/* clear DFCMARST and set DFCMWR */ - val &= ~(1 <<ISIF_DFCMEMCTL_DFCMARST_SHIFT ); + val &= ~BIT (ISIF_DFCMEMCTL_DFCMARST_SHIFT ); val |=1 ;isif_write (isif->isif_cfg.base_addr, val,DFCMEMCTL );
@@ -1140,7 +1140,7 @@ static int isif_config_raw(struct v4l2_subdev *sd, int mode)isif_write (isif->isif_cfg.base_addr, val,CGAMMAWD );/* Configure DPCM compression settings */ if (params->v4l2_pix_fmt ==V4L2_PIX_FMT_SGRBG10DPCM8 ) { - val =1 <<ISIF_DPCM_EN_SHIFT ; + val =BIT (ISIF_DPCM_EN_SHIFT ); val |= (params->dpcm_predictor &ISIF_DPCM_PREDICTOR_MASK ) <<ISIF_DPCM_PREDICTOR_SHIFT ; }
@@ -2044,7 +2044,7 @@ int vpfe_isif_init(struct vpfe_isif_device *isif, struct platform_device *pdev)v4l2_subdev_init (sd, &isif_v4l2_ops); sd->internal_ops = &isif_v4l2_internal_ops;strlcpy (sd->name,"DAVINCI ISIF" ,sizeof (sd->name)); - sd->grp_id =1 <<16 ;/* group ID for davinci subdevs */ + sd->grp_id =BIT (16 );/* group ID for davinci subdevs */ v4l2_set_subdevdata (sd, isif); sd->flags |=V4L2_SUBDEV_FL_HAS_EVENTS |V4L2_SUBDEV_FL_HAS_DEVNODE ; pads[ISIF_PAD_SINK ].flags =MEDIA_PAD_FL_SINK ;
drivers/staging/media/davinci_vpfe/dm365_resizer.c +3 -3
@@ -1903,7 +1903,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,v4l2_subdev_init (sd, &resizer_v4l2_ops); sd->internal_ops = &resizer_v4l2_internal_ops;strlcpy (sd->name,"DAVINCI RESIZER CROP" ,sizeof (sd->name)); - sd->grp_id =1 <<16 ;/* group ID for davinci subdevs */ + sd->grp_id =BIT (16 );/* group ID for davinci subdevs */ v4l2_set_subdevdata (sd, vpfe_rsz); sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ;
@@ -1927,7 +1927,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,v4l2_subdev_init (sd, &resizer_v4l2_ops); sd->internal_ops = &resizer_v4l2_internal_ops;strlcpy (sd->name,"DAVINCI RESIZER A" ,sizeof (sd->name)); - sd->grp_id =1 <<16 ;/* group ID for davinci subdevs */ + sd->grp_id =BIT (16 );/* group ID for davinci subdevs */ v4l2_set_subdevdata (sd, vpfe_rsz); sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ;
@@ -1949,7 +1949,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,v4l2_subdev_init (sd, &resizer_v4l2_ops); sd->internal_ops = &resizer_v4l2_internal_ops;strlcpy (sd->name,"DAVINCI RESIZER B" ,sizeof (sd->name)); - sd->grp_id =1 <<16 ;/* group ID for davinci subdevs */ + sd->grp_id =BIT (16 );/* group ID for davinci subdevs */ v4l2_set_subdevdata (sd, vpfe_rsz); sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ;
Signature · 1 line
2.11.0