Skip to contentSkip to conversation

pinctrl: core: Make pinctrl_init_controller() static

PATCH In review Andy Shevchenko 2 participants 2 messages Mar 27, 2017 – Apr 24, 2017

Subsystems (2)
GPIO Pin control
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 pinctrl: core: Make pinctrl_init_controller() static

pinctrl_init_controller() is not used outside core.c, thus make it static and prevent compiler to warn.

drivers/pinctrl/core.c:1943:21: warning: no previous prototype for ‘pinctrl_init_controller’ [-Wmissing-prototypes]
struct pinctrl_dev *pinctrl_init_controller(struct pinctrl_desc *pctldesc,

                     ^~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/pinctrl/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/core.c +3 -3
index ddefdac7dd20..2892fe2a036c 100644
@@ -1940,9 +1940,9 @@ static int pinctrl_check_ops(struct pinctrl_dev *pctldev)
  * @dev: parent device for this pin controller
  * @driver_data: private pin controller data for this pin controller
  */
-struct pinctrl_dev *pinctrl_init_controller(struct pinctrl_desc *pctldesc,
-					    struct device *dev,
-					    void *driver_data)
+static struct pinctrl_dev *
+pinctrl_init_controller(struct pinctrl_desc *pctldesc, struct device *dev,
+			void *driver_data)
 {
 	struct pinctrl_dev *pctldev;
 	int ret;
Signature · 1 line
2.11.0
#1 lore raw
Quoted 8 lines · Andy Shevchenko

pinctrl_init_controller() is not used outside core.c, thus make it static and prevent compiler to warn.

drivers/pinctrl/core.c:1943:21: warning: no previous prototype for ‘pinctrl_init_controller’ [-Wmissing-prototypes]
struct pinctrl_dev *pinctrl_init_controller(struct pinctrl_desc *pctldesc,

                     ^~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by Andy Shevchenko <[email protected]>

Patch applied.

Yours,
Linus Walleij