Skip to contentSkip to conversation

f2f2-tools 1.4.0 -> 1.8.0

PATCH In review Yong, Jonathan 4 participants 6 messages Mar 28, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 f2f2-tools 1.4.0 -> 1.8.0

Upgrade f2fs-tools, now supports encryption.

Yong, Jonathan (1):
f2fs-tools: Update to Version 1.8.0

 .../0002-Fix-mkfs-out-of-tree-builds.patch         | 27 ++++++++++++++++++++++
 .../{f2fs-tools_1.4.0.bb => f2fs-tools_1.8.0.bb}   |  5 ++--
 2 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch
 rename meta-filesystems/recipes-utils/f2fs-tools/{f2fs-tools_1.4.0.bb => f2fs-tools_1.8.0.bb} (81%)
Signature · 1 line
2.10.2
#1 lore raw

PATCH 1/1 f2fs-tools: Update to Version 1.8.0

---
 .../0002-Fix-mkfs-out-of-tree-builds.patch         | 27 ++++++++++++++++++++++
 .../{f2fs-tools_1.4.0.bb => f2fs-tools_1.8.0.bb}   |  5 ++--
 2 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch
 rename meta-filesystems/recipes-utils/f2fs-tools/{f2fs-tools_1.4.0.bb => f2fs-tools_1.8.0.bb} (81%)
meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch new file +27 -0
new file mode 100644
index 0000000..3aadf3c
@@ -0,0 +1,27 @@
+From 1d4f6b6a945eabb364a2035d5ef0b69f68a87f74 Mon Sep 17 00:00:00 2001
+From: "Yong, Jonathan" <[email protected]>
+Date: Mon, 27 Mar 2017 08:34:06 +0000
+Subject: [PATCH] Fix mkfs out of tree builds
+
+Libraries are built in builddir, not srcdir, fix Makefile.am
+accordingly.
+
+Signed-off-by: Yong, Jonathan <[email protected]>
+---
+ mkfs/Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
+index 8b4c16c..ae211b2 100644
+--- a/mkfs/Makefile.am
++++ b/mkfs/Makefile.am
+@@ -10,5 +10,5 @@ lib_LTLIBRARIES = libf2fs_format.la
+ libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c f2fs_format_utils.c
+ libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
+ libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include
+-libf2fs_format_la_LDFLAGS = -luuid -L$(top_srcdir)/lib -lf2fs \
++libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \
+ 	-version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
+-- 
+2.10.2
+
meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.8.0.bb renamed from meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb +3 -2
similarity index 81%
rename from meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb
rename to meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.8.0.bb
index 1a558e7..691cb6e 100644
@@ -7,9 +7,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=362b4b2594cd362b874a97718faa51d3"
 # to provide libuuid
 DEPENDS = "util-linux"
 
-SRCREV = "baac4b4e6f41ceb02511da49dd3707674f3fea21"
+SRCREV = "1e7aedf99b85d16f94d1d8ad2fcf846403bb2174"
 SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git \
-    file://0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch"
+    file://0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch \
+    file://0002-Fix-mkfs-out-of-tree-builds.patch"
 S = "${WORKDIR}/git"
 
 inherit pkgconfig autotools
Signature · 1 line
2.10.2
#2 lore raw

PATCH 1/1 f2fs-tools: Update to Version 1.8.0

In reply to Yong, Jonathan
---
 .../0002-Fix-mkfs-out-of-tree-builds.patch         | 27 ++++++++++++++++++++++
 .../{f2fs-tools_1.4.0.bb => f2fs-tools_1.8.0.bb}   |  5 ++--
 2 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch
 rename meta-filesystems/recipes-utils/f2fs-tools/{f2fs-tools_1.4.0.bb => f2fs-tools_1.8.0.bb} (81%)
meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch new file +27 -0
new file mode 100644
index 0000000..3aadf3c
@@ -0,0 +1,27 @@
+From 1d4f6b6a945eabb364a2035d5ef0b69f68a87f74 Mon Sep 17 00:00:00 2001
+From: "Yong, Jonathan" <[email protected]>
+Date: Mon, 27 Mar 2017 08:34:06 +0000
+Subject: [PATCH] Fix mkfs out of tree builds
+
+Libraries are built in builddir, not srcdir, fix Makefile.am
+accordingly.
+
+Signed-off-by: Yong, Jonathan <[email protected]>
+---
+ mkfs/Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
+index 8b4c16c..ae211b2 100644
+--- a/mkfs/Makefile.am
++++ b/mkfs/Makefile.am
+@@ -10,5 +10,5 @@ lib_LTLIBRARIES = libf2fs_format.la
+ libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c f2fs_format_utils.c
+ libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
+ libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include
+-libf2fs_format_la_LDFLAGS = -luuid -L$(top_srcdir)/lib -lf2fs \
++libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \
+ 	-version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
+-- 
+2.10.2
+
meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.8.0.bb renamed from meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb +3 -2
similarity index 81%
rename from meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb
rename to meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.8.0.bb
index 1a558e7..691cb6e 100644
@@ -7,9 +7,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=362b4b2594cd362b874a97718faa51d3"
 # to provide libuuid
 DEPENDS = "util-linux"
 
-SRCREV = "baac4b4e6f41ceb02511da49dd3707674f3fea21"
+SRCREV = "1e7aedf99b85d16f94d1d8ad2fcf846403bb2174"
 SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git \
-    file://0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch"
+    file://0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch \
+    file://0002-Fix-mkfs-out-of-tree-builds.patch"
 S = "${WORKDIR}/git"
 
 inherit pkgconfig autotools
Signature · 1 line
2.10.2
#3 lore raw

Re: [PATCH] f2fs-tools: Update to Version 1.8.0

This should go to [email protected], as per the README in meta-filesystems.

Ross

Quoted 80 lines · Jonathan
---
 .../0002-Fix-mkfs-out-of-tree-builds.patch         | 27
++++++++++++++++++++++
 .../{f2fs-tools_1.4.0.bb => f2fs-tools_1.8.0.bb}   |  5 ++--
 2 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/
0002-Fix-mkfs-out-of-tree-builds.patch
 rename meta-filesystems/recipes-utils/f2fs-tools/{f2fs-tools_1.4.0.bb =>

f2fs-tools_1.8.0.bb} (81%)

(quoted diff) +0 -0

0002-Fix-mkfs-out-of-tree-builds.patch b/meta-filesystems/recipes- utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch new file mode 100644
index 0000000..3aadf3c

meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/ new file +0 -0

0002-Fix-mkfs-out-of-tree-builds.patch

meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/ new file +19 -0
@@ -0,0 +1,27 @@
+From 1d4f6b6a945eabb364a2035d5ef0b69f68a87f74 Mon Sep 17 00:00:00 2001
+From: "Yong, Jonathan" <[email protected]>
+Date: Mon, 27 Mar 2017 08:34:06 +0000
+Subject: [PATCH] Fix mkfs out of tree builds
+
+Libraries are built in builddir, not srcdir, fix Makefile.am
+accordingly.
+
+Signed-off-by: Yong, Jonathan <[email protected]>
+---
+ mkfs/Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
+index 8b4c16c..ae211b2 100644
+--- a/mkfs/Makefile.am
++++ b/mkfs/Makefile.am
+@@ -10,5 +10,5 @@ lib_LTLIBRARIES = libf2fs_format.la
+ libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c

f2fs_format_utils.c
+ libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
+ libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include +-libf2fs_format_la_LDFLAGS = -luuid -L$(top_srcdir)/lib -lf2fs \
++libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \

meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/ new file +4 -0
+       -version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
+--
+2.10.2
+
meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.8.0.bb renamed from meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb +0 -0
similarity index 81%
rename from meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb
rename to meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.8.0.bb
index 1a558e7..691cb6e 100644
@@ -7,9 +7,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=

362b4b2594cd362b874a97718faa51d3"

 # to provide libuuid
 DEPENDS = "util-linux"
meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.8.0.bb renamed from meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb +1 -1
-SRCREV = "baac4b4e6f41ceb02511da49dd3707674f3fea21"
+SRCREV = "1e7aedf99b85d16f94d1d8ad2fcf846403bb2174"
 SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-

tools.git \

meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.8.0.bb renamed from meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb +2 -2
-    file://0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch"
+    file://0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch \
+    file://0002-Fix-mkfs-out-of-tree-builds.patch"
 S = "${WORKDIR}/git"
 
 inherit pkgconfig autotools
--

2.10.2

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw

Re: [PATCH] f2fs-tools: Update to Version 1.8.0

In reply to Yong, Jonathan
Quoted 14 lines · Jonathan
---
 .../0002-Fix-mkfs-out-of-tree-builds.patch         | 27 ++++++++++++++++++++++
 .../{f2fs-tools_1.4.0.bb => f2fs-tools_1.8.0.bb}   |  5 ++--
 2 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch
 rename meta-filesystems/recipes-utils/f2fs-tools/{f2fs-tools_1.4.0.bb => f2fs-tools_1.8.0.bb} (81%)
meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch new file +0 -0
new file mode 100644
index 0000000..3aadf3c

meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch line 7

Quoted 7 lines
meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch new file +7 -0
@@ -0,0 +1,27 @@
+From 1d4f6b6a945eabb364a2035d5ef0b69f68a87f74 Mon Sep 17 00:00:00 2001
+From: "Yong, Jonathan" <[email protected]>
+Date: Mon, 27 Mar 2017 08:34:06 +0000
+Subject: [PATCH] Fix mkfs out of tree builds
+
+Libraries are built in builddir, not srcdir, fix Makefile.am
+accordingly.

This patch should also be upstreamed into f2fs

Quoted 41 lines
meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch new file +20 -0
+
+Signed-off-by: Yong, Jonathan <[email protected]>
+---
+ mkfs/Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
+index 8b4c16c..ae211b2 100644
+--- a/mkfs/Makefile.am
++++ b/mkfs/Makefile.am
+@@ -10,5 +10,5 @@ lib_LTLIBRARIES = libf2fs_format.la
+ libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c f2fs_format_utils.c
+ libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
+ libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include
+-libf2fs_format_la_LDFLAGS = -luuid -L$(top_srcdir)/lib -lf2fs \
++libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \
+ 	-version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
+-- 
+2.10.2
+
meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.8.0.bb renamed from meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb +3 -2
similarity index 81%
rename from meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.4.0.bb
rename to meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools_1.8.0.bb
index 1a558e7..691cb6e 100644
@@ -7,9 +7,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=362b4b2594cd362b874a97718faa51d3"
 # to provide libuuid
 DEPENDS = "util-linux"
 
-SRCREV = "baac4b4e6f41ceb02511da49dd3707674f3fea21"
+SRCREV = "1e7aedf99b85d16f94d1d8ad2fcf846403bb2174"
 SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git \
-    file://0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch"
+    file://0001-Remove-AC_CHECK_FILE-for-cross-compilation.patch \
+    file://0002-Fix-mkfs-out-of-tree-builds.patch"
 S = "${WORKDIR}/git"
 
 inherit pkgconfig autotools
#5 lore raw

✗ patchtest: failure for f2fs-tools: Update to Version 1.8.0

In reply to Yong, Jonathan

== Series Details ==

Series: f2fs-tools: Update to Version 1.8.0
Revision: 1
URL : https://patchwork.openembedded.org/series/6013/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Added patch file is missing Upstream-Status in the header [test_upstream_status_presence]
Suggested fix Add Upstream-Status: <status> to the header of meta-filesystems/recipes-utils/f2fs-tools/f2fs-tools/0002-Fix-mkfs-out-of-tree-builds.patch (possible values: Pending, Submitted, Accepted, Backport, Denied, Inappropriate)

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 9c948d3de0)

* Issue Series sent to the wrong mailing list [test_target_mailing_list]
Suggested fix Send the series again to the correct mailing list (ML)
Suggested ML [email protected] [http://git.openembedded.org/meta-openembedded/]

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe