lkdtm: turn off kcov for lkdtm_rodata_do_nothing:
Arnd Bergmann
maintainerPATCH 1/1 lkdtm: turn off kcov for lkdtm_rodata_do_nothing:
I ran into a link error on ARM64 for lkdtm_rodata_do_nothing:
drivers/misc/built-in.o: In function `lkdtm_rodata_do_nothing':
:(.rodata+0x68c8): relocation truncated to fit: R_AARCH64_CALL26 against symbol `__sanitizer_cov_trace_pc' defined in .text section in kernel/built-in.o
I did not analyze this further, but my theory is that we would need a trampoline to call __sanitizer_cov_trace_pc(), but the linker (correctly) only adds trampolines for callers in executable sections.
Disabling KCOV for this one file avoids the build failure with no other practical downsides I can think of.
The problem can only happen on kernels that contain both kcov and lkdtm, so if we want to backport this, it should be in the earliest version that has both (v4.8).
--- drivers/misc/Makefile | 2 ++ 1 file changed, 2 insertions(+)
drivers/misc/Makefile +2 -0
@@ -63,6 +63,8 @@ lkdtm-$(CONFIG_LKDTM) += lkdtm_perms.o lkdtm-$(CONFIG_LKDTM) += lkdtm_rodata_objcopy.o lkdtm-$(CONFIG_LKDTM) += lkdtm_usercopy.o +KCOV_INSTRUMENT_lkdtm_rodata.o := n + OBJCOPYFLAGS := OBJCOPYFLAGS_lkdtm_rodata_objcopy.o := \ --set-section-flags .text=alloc,readonly \
Signature · 1 line
2.9.0
Quoted 39 lines · Arnd Bergmann
I ran into a link error on ARM64 for
lkdtm_rodata_do_nothing:
drivers/misc/built-in.o: In function `lkdtm_rodata_do_nothing':
:(.rodata+0x68c8): relocation truncated to fit:R_AARCH64_CALL26against symbol `__sanitizer_cov_trace_pc' defined in .text section inkernel/built-in.oI did not analyze this further, but my theory is that we would need a trampoline to call
__sanitizer_cov_trace_pc(), but the linker (correctly) only adds trampolines for callers in executable sections.Disabling KCOV for this one file avoids the build failure with no other practical downsides I can think of.
The problem can only happen on kernels that contain both kcov and lkdtm, so if we want to backport this, it should be in the earliest version that has both (v4.8).
Cc Dmitry Vyukov <[email protected]>Cc Kees Cook <[email protected]>Fixes 5c9a8750a640 ("kernel: add kcov code coverage")Fixes 9a49a528dcf3 ("lkdtm: add function for testing .rodata section")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/misc/Makefile | 2 ++ 1 file changed, 2 insertions(+)drivers/misc/Makefile +2
-1@@ -63,6 +63,8 @@ lkdtm-$(CONFIG_LKDTM) += lkdtm_perms.o lkdtm-$(CONFIG_LKDTM) += lkdtm_rodata_objcopy.o lkdtm-$(CONFIG_LKDTM) += lkdtm_usercopy.o +KCOV_INSTRUMENT_lkdtm_rodata.o := n + OBJCOPYFLAGS := OBJCOPYFLAGS_lkdtm_rodata_objcopy.o := \ --set-section-flags .text=alloc,readonly \ --
Quoted 1 line
2.9.0
Hi,
Quoted 9 lines · Dmitry Vyukov
Quoted 8 lines · Arnd Bergmann
I ran into a link error on ARM64 for
lkdtm_rodata_do_nothing:
drivers/misc/built-in.o: In function `lkdtm_rodata_do_nothing':
:(.rodata+0x68c8): relocation truncated to fit:R_AARCH64_CALL26against symbol `__sanitizer_cov_trace_pc' defined in .text section inkernel/built-in.oI did not analyze this further, but my theory is that we would need a trampoline to call
__sanitizer_cov_trace_pc(), but the linker (correctly) only adds trampolines for callers in executable sections.
For reference, is this a "large" config, e.g. allyesconfig?
I'm aware that at least as recently as GCC 6 there were issues with veneer generation for calls across sections (which I personally saw with calls from .init.text to .text) when the kernel was sufficiently large.
FWIW, I have no problem building a v4.11-rc3 kernel with both KCOV and LKDTM using the Linaro 15.08 aarch64-linux-gnu GCC 5 toolchain. Which toolchain are you using?
No strong feelings on this patch, but it may be indicative of a larger problem, and we probably don't want to play whack-a-mole to fix relocation truncation more generally.
Thanks,
Mark.
Quoted 34 lines
Quoted 30 lines
Disabling KCOV for this one file avoids the build failure with no other practical downsides I can think of.
The problem can only happen on kernels that contain both kcov and lkdtm, so if we want to backport this, it should be in the earliest version that has both (v4.8).
Cc Dmitry Vyukov <[email protected]>Cc Kees Cook <[email protected]>Fixes 5c9a8750a640 ("kernel: add kcov code coverage")Fixes 9a49a528dcf3 ("lkdtm: add function for testing .rodata section")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/misc/Makefile | 2 ++ 1 file changed, 2 insertions(+)drivers/misc/Makefile +2
-1@@ -63,6 +63,8 @@ lkdtm-$(CONFIG_LKDTM) += lkdtm_perms.o lkdtm-$(CONFIG_LKDTM) += lkdtm_rodata_objcopy.o lkdtm-$(CONFIG_LKDTM) += lkdtm_usercopy.o +KCOV_INSTRUMENT_lkdtm_rodata.o := n + OBJCOPYFLAGS := OBJCOPYFLAGS_lkdtm_rodata_objcopy.o := \ --set-section-flags .text=alloc,readonly \ --Quoted 1 line
2.9.0
Acked-by Dmitry Vyukov <[email protected]>
Arnd Bergmann
maintainerQuoted 6 lines · Mark Rutland
Hi,
Quoted 3 lines · Dmitry Vyukov
Quoted 2 lines · Arnd Bergmann
I ran into a link error on ARM64 for
lkdtm_rodata_do_nothing:
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
drivers/misc/built-in.o: In function `lkdtm_rodata_do_nothing':
:(.rodata+0x68c8): relocation truncated to fit:R_AARCH64_CALL26against symbol `__sanitizer_cov_trace_pc' defined in .text section inkernel/built-in.oI did not analyze this further, but my theory is that we would need a trampoline to call
__sanitizer_cov_trace_pc(), but the linker (correctly) only adds trampolines for callers in executable sections.For reference, is this a "large" config, e.g. allyesconfig?
It's a randconfig build, and I'm guessing that it's large, but I have not checked
the size of the sections. This was the first time I ran into it after months of building randconfig kernels without anything having triggered it recently.
Quoted 3 lines
I'm aware that at least as recently as GCC 6 there were issues with veneer generation for calls across sections (which I personally saw with calls from .init.text to .text) when the kernel was sufficiently large.
We have had problems with veneers no arm32 in the past, and ld definitely doesn't create them for calls from inside of non-executable sections, so the typical fix was to put all code that needs veneers into executable sections.
Clearly that cannot work for this particular case.
Quoted 3 lines
FWIW, I have no problem building a v4.11-rc3 kernel with both KCOV and LKDTM using the Linaro 15.08 aarch64-linux-gnu GCC 5 toolchain. Which toolchain are you using?
This is a gcc-7.0.1 snapshot from last week, and a somewhat older
binutils: GNU ld (GNU Binutils) 2.27.51.20161215
Quoted 3 lines
No strong feelings on this patch, but it may be indicative of a larger problem, and we probably don't want to play whack-a-mole to fix relocation truncation more generally.
I have not seen this problem in allyesconfig or any other randconfig build, so it's certainly likely that some other setting must be there to trigger this.
I've recreated the problem using an allyesconfig build with this change to turn off -mcmodel=large:
@@ -283,7 +283,6 @@
CONFIG_HAVE_IRQ_TIME_ACCOUNTING=y
CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE=y
CONFIG_HAVE_ARCH_HUGE_VMAP=y
-CONFIG_HAVE_MOD_ARCH_SPECIFIC=y
CONFIG_MODULES_USE_ELF_RELA=y
CONFIG_ARCH_HAS_ELF_RANDOMIZE=y
CONFIG_HAVE_ARCH_MMAP_RND_BITS=y
@@ -529,7 +528,7 @@
CONFIG_ARM64_ERRATUM_832075=y
CONFIG_ARM64_ERRATUM_834220=y
CONFIG_ARM64_ERRATUM_845719=y
-CONFIG_ARM64_ERRATUM_843419=y
+# CONFIG_ARM64_ERRATUM_843419 is not set
CONFIG_CAVIUM_ERRATUM_22375=y
CONFIG_CAVIUM_ERRATUM_23144=y
CONFIG_CAVIUM_ERRATUM_23154=y
@@ -643,10 +642,7 @@
# ARMv8.2 architectural features
#
CONFIG_ARM64_UAO=y
-CONFIG_ARM64_MODULE_CMODEL_LARGE=y
-CONFIG_ARM64_MODULE_PLTS=y
-CONFIG_RELOCATABLE=y
-CONFIG_RANDOMIZE_BASE=y
+# CONFIG_RANDOMIZE_BASE is not set
#
# Boot options
Arnd
Kees Cook
Acked-byQuoted 9 lines · Dmitry Vyukov
Quoted 8 lines · Arnd Bergmann
I ran into a link error on ARM64 for
lkdtm_rodata_do_nothing:
drivers/misc/built-in.o: In function `lkdtm_rodata_do_nothing':
:(.rodata+0x68c8): relocation truncated to fit:R_AARCH64_CALL26against symbol `__sanitizer_cov_trace_pc' defined in .text section inkernel/built-in.oI did not analyze this further, but my theory is that we would need a trampoline to call
__sanitizer_cov_trace_pc(), but the linker (correctly) only adds trampolines for callers in executable sections.
Yup, this function should be inherently uncallable (which is what lkdtm is testing), so it makes sense to turn off kcov for it.
Quoted 25 lines
Quoted 25 lines
Disabling KCOV for this one file avoids the build failure with no other practical downsides I can think of.
The problem can only happen on kernels that contain both kcov and lkdtm, so if we want to backport this, it should be in the earliest version that has both (v4.8).
Cc Dmitry Vyukov <[email protected]>Cc Kees Cook <[email protected]>Fixes 5c9a8750a640 ("kernel: add kcov code coverage")Fixes 9a49a528dcf3 ("lkdtm: add function for testing .rodata section")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/misc/Makefile | 2 ++ 1 file changed, 2 insertions(+)drivers/misc/Makefile +0
-0@@ -63,6 +63,8 @@ lkdtm-$(CONFIG_LKDTM) += lkdtm_perms.o lkdtm-$(CONFIG_LKDTM) += lkdtm_rodata_objcopy.o lkdtm-$(CONFIG_LKDTM) += lkdtm_usercopy.o
Quoted 10 lines
Quoted 7 lines
drivers/misc/Makefile +2
-1+KCOV_INSTRUMENT_lkdtm_rodata.o := n + OBJCOPYFLAGS := OBJCOPYFLAGS_lkdtm_rodata_objcopy.o := \ --set-section-flags .text=alloc,readonly \ --2.9.0
Acked-by Dmitry Vyukov <[email protected]>
Greg, can you please add this to the drivers/misc tree when you get a chance?
Thanks!
-Kees
Signature · 2 lines
Kees Cook Pixel Security
Greg Kroah-Hartman
maintainerQuoted 50 lines · Kees Cook
Quoted 9 lines · Dmitry Vyukov
Quoted 8 lines · Arnd Bergmann
I ran into a link error on ARM64 for
lkdtm_rodata_do_nothing:
drivers/misc/built-in.o: In function `lkdtm_rodata_do_nothing':
:(.rodata+0x68c8): relocation truncated to fit:R_AARCH64_CALL26against symbol `__sanitizer_cov_trace_pc' defined in .text section inkernel/built-in.oI did not analyze this further, but my theory is that we would need a trampoline to call
__sanitizer_cov_trace_pc(), but the linker (correctly) only adds trampolines for callers in executable sections.Yup, this function should be inherently uncallable (which is what lkdtm is testing), so it makes sense to turn off kcov for it.
Quoted 25 lines
Quoted 25 lines
Disabling KCOV for this one file avoids the build failure with no other practical downsides I can think of.
The problem can only happen on kernels that contain both kcov and lkdtm, so if we want to backport this, it should be in the earliest version that has both (v4.8).
Cc Dmitry Vyukov <[email protected]>Cc Kees Cook <[email protected]>Fixes 5c9a8750a640 ("kernel: add kcov code coverage")Fixes 9a49a528dcf3 ("lkdtm: add function for testing .rodata section")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/misc/Makefile | 2 ++ 1 file changed, 2 insertions(+)drivers/misc/Makefile +0
-0@@ -63,6 +63,8 @@ lkdtm-$(CONFIG_LKDTM) += lkdtm_perms.o lkdtm-$(CONFIG_LKDTM) += lkdtm_rodata_objcopy.o lkdtm-$(CONFIG_LKDTM) += lkdtm_usercopy.oQuoted 10 lines
Quoted 7 lines
drivers/misc/Makefile +2
-1+KCOV_INSTRUMENT_lkdtm_rodata.o := n + OBJCOPYFLAGS := OBJCOPYFLAGS_lkdtm_rodata_objcopy.o := \ --set-section-flags .text=alloc,readonly \ --2.9.0
Acked-by Dmitry Vyukov <[email protected]>
Quoted 3 lines
Acked-by Kees Cook <[email protected]>Greg, can you please add this to the
drivers/misctree when you get a chance?
Will do.
thanks,
greg k-h