Skip to contentSkip to conversation

coding style issue resolved

PATCH In review Andrea della Porta 2 participants 2 messages Mar 28, 2017 – Mar 29, 2017

Subsystems (4)
Staging IIO Analog Devices IIO drivers Staging - industrial io
lore
Share & tools
lore

Andrea della Porta

author
#0 lore raw

PATCH 1/1 coding style issue resolved

Coding style issue resolved.

Signed-off-by Andrea della Porta <[email protected]>
---
 drivers/staging/iio/accel/adis16209.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/accel/adis16209.c +2 -2
index 52fa2e0..159a687 100644
@@ -255,9 +255,9 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
 		}
 		addr = adis16209_addresses[chan->scan_index][0];
 		ret = adis_read_reg_16(st, addr, &val16);
-		if (ret) {
+		if (ret)
 			return ret;
-		}
+
 		val16 &= (1 << bits) - 1;
 		val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
 		*val = val16;
Signature · 1 line
2.4.10
maintainer
#1 lore raw
Quoted 3 lines · Andrea della Porta

Coding style issue resolved.

Signed-off-by Andrea della Porta <[email protected]>

Please include the driver name in the title. Subsystem also good. staging:iio:accel:adis16029 drop braces around single element if block

or something along those lines would be good.

Quoted 21 lines
---
 drivers/staging/iio/accel/adis16209.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/accel/adis16209.c +2 -2
index 52fa2e0..159a687 100644
@@ -255,9 +255,9 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
 		}
 		addr = adis16209_addresses[chan->scan_index][0];
 		ret = adis_read_reg_16(st, addr, &val16);
-		if (ret) {
+		if (ret)
 			return ret;
-		}
+
 		val16 &= (1 << bits) - 1;
 		val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
 		*val = val16;