Skip to contentSkip to conversation

crypto: ccp - Remove redundant cpu-to-le32 macros

PATCH In review Gary R Hook 2 participants 2 messages Mar 28, 2017 – Apr 5, 2017

Subsystems (2)
Crypto API AMD cryptographic coprocessor (CCP) driver
lore
Share & tools
lore

Gary R Hook

author
#0 lore raw

PATCH 1/1 crypto: ccp - Remove redundant cpu-to-le32 macros

Endianness is dealt with when the command descriptor is copied into the command queue. Remove any occurrences of cpu_to_le32() found elsewhere.

Signed-off-by Gary R Hook <[email protected]>
---
 drivers/crypto/ccp/ccp-dev-v5.c |   22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/crypto/ccp/ccp-dev-v5.c +11 -11
index 5e08654..e03d06a 100644
@@ -419,22 +419,22 @@ static int ccp5_perform_des3(struct ccp_op *op)
 	CCP_DES3_ENCRYPT(&function) = op->u.des3.action;
 	CCP_DES3_MODE(&function) = op->u.des3.mode;
 	CCP_DES3_TYPE(&function) = op->u.des3.type;
-	CCP5_CMD_FUNCTION(&desc) = cpu_to_le32(function.raw);
+	CCP5_CMD_FUNCTION(&desc) = function.raw;
 
-	CCP5_CMD_LEN(&desc) = cpu_to_le32(op->src.u.dma.length);
+	CCP5_CMD_LEN(&desc) = op->src.u.dma.length;
 
-	CCP5_CMD_SRC_LO(&desc) = cpu_to_le32(ccp_addr_lo(&op->src.u.dma));
-	CCP5_CMD_SRC_HI(&desc) = cpu_to_le32(ccp_addr_hi(&op->src.u.dma));
-	CCP5_CMD_SRC_MEM(&desc) = cpu_to_le32(CCP_MEMTYPE_SYSTEM);
+	CCP5_CMD_SRC_LO(&desc) = ccp_addr_lo(&op->src.u.dma);
+	CCP5_CMD_SRC_HI(&desc) = ccp_addr_hi(&op->src.u.dma);
+	CCP5_CMD_SRC_MEM(&desc) = CCP_MEMTYPE_SYSTEM;
 
-	CCP5_CMD_DST_LO(&desc) = cpu_to_le32(ccp_addr_lo(&op->dst.u.dma));
-	CCP5_CMD_DST_HI(&desc) = cpu_to_le32(ccp_addr_hi(&op->dst.u.dma));
-	CCP5_CMD_DST_MEM(&desc) = cpu_to_le32(CCP_MEMTYPE_SYSTEM);
+	CCP5_CMD_DST_LO(&desc) = ccp_addr_lo(&op->dst.u.dma);
+	CCP5_CMD_DST_HI(&desc) = ccp_addr_hi(&op->dst.u.dma);
+	CCP5_CMD_DST_MEM(&desc) = CCP_MEMTYPE_SYSTEM;
 
-	CCP5_CMD_KEY_LO(&desc) = cpu_to_le32(lower_32_bits(key_addr));
+	CCP5_CMD_KEY_LO(&desc) = lower_32_bits(key_addr);
 	CCP5_CMD_KEY_HI(&desc) = 0;
-	CCP5_CMD_KEY_MEM(&desc) = cpu_to_le32(CCP_MEMTYPE_SB);
-	CCP5_CMD_LSB_ID(&desc) = cpu_to_le32(op->sb_ctx);
+	CCP5_CMD_KEY_MEM(&desc) = CCP_MEMTYPE_SB;
+	CCP5_CMD_LSB_ID(&desc) = op->sb_ctx;
 
 	return ccp5_do_cmd(&desc, op->cmd_q);
 }
maintainer
#1 lore raw
Quoted 5 lines · Gary R Hook

Endianness is dealt with when the command descriptor is copied into the command queue. Remove any occurrences of cpu_to_le32() found elsewhere.

Signed-off-by Gary R Hook <[email protected]>

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt