iio: adc: max1363: constify attribute_group structures

PATCH In review simran singhal 3 participants 4 messages Mar 28, 2017 – Mar 29, 2017 IIO

Share & tools

simran singhal

author

2017-03-28 20:15 UTC #0 lore raw

PATCH 1/1 iio: adc: max1363: constify attribute_group structures

Check for attribute_group structures that are only stored in the event_attrs filed of iio_info structure. As the event_attrs field of iio_info structures is constant, so these attribute_group structures can also be declared constant. Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.event_attrs=&i@p;

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
text data bss dec hex filename
36951 448 0 37399 9217 drivers/iio/adc/max1363.o

File size after:
text data bss dec hex filename
37015 384 0 37399 9217 drivers/iio/adc/max1363.o

Signed-off-by simran singhal <[email protected]>

---
 drivers/iio/adc/max1363.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/iio/adc/max1363.c +1 -1

index c6c12fe..80eada4 100644
@@ -1007,7 +1007,7 @@ static struct attribute *max1363_event_attributes[] = {
 	NULL,
 };
 
-static struct attribute_group max1363_event_attribute_group = {
+static const struct attribute_group max1363_event_attribute_group = {
 	.attrs = max1363_event_attributes,
 };

Signature · 1 line

2.7.4

Jonathan Cameron

maintainer

2017-03-29 21:11 UTC #1 lore raw

Quoted 41 lines · simran singhal

Check for attribute_group structures that are only stored in the event_attrs filed of iio_info structure. As the event_attrs field of iio_info structures is constant, so these attribute_group structures can also be declared constant. Done using coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};
@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.event_attrs=&i@p;
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;
File size before:
text data bss dec hex filename
36951 448 0 37399 9217 drivers/iio/adc/max1363.o

Quoted 5 lines

File size after:
text data bss dec hex filename
37015 384 0 37399 9217 drivers/iio/adc/max1363.o
Signed-off-by simran singhal <[email protected]>

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

Quoted 18 lines

---
 drivers/iio/adc/max1363.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/iio/adc/max1363.c +1 -1

index c6c12fe..80eada4 100644
@@ -1007,7 +1007,7 @@ static struct attribute *max1363_event_attributes[] = {
 	NULL,
 };
 
-static struct attribute_group max1363_event_attribute_group = {
+static const struct attribute_group max1363_event_attribute_group = {
 	.attrs = max1363_event_attributes,
 };

SIMRAN SINGHAL

author

2017-03-29 21:28 UTC #2 lore raw

Quoted 42 lines · Jonathan Cameron

Quoted 41 lines · simran singhal
Check for attribute_group structures that are only stored in the event_attrs filed of iio_info structure. As the event_attrs field of iio_info structures is constant, so these attribute_group structures can also be declared constant. Done using coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};
@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.event_attrs=&i@p;
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;
File size before:
text data bss dec hex filename
36951 448 0 37399 9217 drivers/iio/adc/max1363.o

Quoted 8 lines

Quoted 5 lines
File size after:
text data bss dec hex filename
37015 384 0 37399 9217 drivers/iio/adc/max1363.o
Signed-off-by simran singhal <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

But my tree is up-to-date and I also test it before sending.

Quoted 22 lines

Thanks,

Jonathan

Quoted 18 lines

---
 drivers/iio/adc/max1363.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/iio/adc/max1363.c +1 -1

index c6c12fe..80eada4 100644
@@ -1007,7 +1007,7 @@ static struct attribute *max1363_event_attributes[] = {
      NULL,
 };
 
-static struct attribute_group max1363_event_attribute_group = {
+static const struct attribute_group max1363_event_attribute_group = {
      .attrs = max1363_event_attributes,
 };

Julia Lawall

2017-03-29 21:31 UTC #3 lore raw

Quoted 47 lines · SIMRAN SINGHAL

Quoted 46 lines · Jonathan Cameron
Quoted 45 lines · simran singhal
Check for attribute_group structures that are only stored in the event_attrs filed of iio_info structure. As the event_attrs field of iio_info structures is constant, so these attribute_group structures can also be declared constant. Done using coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};
@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.event_attrs=&i@p;
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;
File size before:
text data bss dec hex filename
36951 448 0 37399 9217 drivers/iio/adc/max1363.o
File size after:
text data bss dec hex filename
37015 384 0 37399 9217 drivers/iio/adc/max1363.o

Quoted 6 lines

Quoted 4 lines
Quoted 1 line
Signed-off-by simran singhal <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.
But my tree is up-to-date and I also test it before sending.

One never knows...

julia

Quoted 31 lines

Quoted 16 lines
Thanks,
Jonathan
Quoted 12 lines
---
 drivers/iio/adc/max1363.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/max1363.c +0 -0
index c6c12fe..80eada4 100644
@@ -1007,7 +1007,7 @@ static struct attribute *max1363_event_attributes[] = {
      NULL,
 };
 
Quoted 7 lines
drivers/iio/adc/max1363.c static struct attribute *max1363_event_attributes[] = { · line 1013
Quoted 6 lines
drivers/iio/adc/max1363.c +1 -1
-static struct attribute_group max1363_event_attribute_group = {
+static const struct attribute_group max1363_event_attribute_group = {
      .attrs = max1363_event_attributes,
 };
 
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyOPVDA%2B4n56d3c%2BjZRsiaQ52vYEjA%2BOr1j8Z2LNgi58OQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.