btrfs: use clear_page where appropriate

PATCH New David Sterba 1 participant 1 message Mar 29, 2017 Btrfs file system

Share & tools

David Sterba

author maintainer

2017-03-29 18:49 UTC #0 lore raw

PATCH 1/1 btrfs: use clear_page where appropriate

There's a helper to clear whole page, with a arch-specific optimized code. The replaced cases do not seem to be in performace critical code, but we still might get some percent gain.

Signed-off-by David Sterba <[email protected]>

---
 fs/btrfs/free-space-cache.c | 2 +-
 fs/btrfs/scrub.c            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

fs/btrfs/free-space-cache.c +1 -1

index da6841efac26..c5e6180cdb8c 100644
@@ -355,7 +355,7 @@ static void io_ctl_map_page(struct btrfs_io_ctl *io_ctl, int clear)
 	io_ctl->orig = io_ctl->cur;
 	io_ctl->size = PAGE_SIZE;
 	if (clear)
-		memset(io_ctl->cur, 0, PAGE_SIZE);
+		clear_page(io_ctl->cur);
 }
 
 static void io_ctl_drop_pages(struct btrfs_io_ctl *io_ctl)

fs/btrfs/scrub.c +1 -1

index b0251eb1239f..08ae2331d402 100644
@@ -1634,7 +1634,7 @@ static int scrub_write_page_to_dev_replace(struct scrub_block *sblock,
 	if (spage->io_error) {
 		void *mapped_buffer = kmap_atomic(spage->page);
 
-		memset(mapped_buffer, 0, PAGE_SIZE);
+		clear_page(mapped_buffer);
 		flush_dcache_page(spage->page);
 		kunmap_atomic(mapped_buffer);
 	}

Signature · 1 line

2.12.0