Skip to contentSkip to conversation

shairport-sync: requires C++

PATCH New Baruch Siach 3 participants 3 messages Mar 29, 2017 – Mar 30, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 shairport-sync: requires C++

Fixes:
http://autobuild.buildroot.net/results/122/122d6cedf0205e8db27d498d6a2a839e11e7b6f2/
http://autobuild.buildroot.net/results/bef/bef5fb328e6688107496cb213d8aeeca527abf03/

---
 package/shairport-sync/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/shairport-sync/Config.in +3 -2
index d70121b9fd78..c2a5565402d6 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_SHAIRPORT_SYNC
 	bool "shairport-sync"
 	depends on BR2_USE_MMU # libdaemon
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
+	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_ALSA_LIB
 	select BR2_PACKAGE_ALSA_LIB_MIXER
 	select BR2_PACKAGE_LIBCONFIG
@@ -34,6 +35,6 @@ config BR2_PACKAGE_SHAIRPORT_SYNC_LIBSOXR
 
 endif
 
-comment "shairport-sync needs a toolchain w/ NPTL"
+comment "shairport-sync needs a toolchain w/ C++, NPTL"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 shairport-sync: requires C++

Hello,

Quoted 9 lines · Baruch Siach

Fixes:
http://autobuild.buildroot.net/results/122/122d6cedf0205e8db27d498d6a2a839e11e7b6f2/
http://autobuild.buildroot.net/results/bef/bef5fb328e6688107496cb213d8aeeca527abf03/

---
 package/shairport-sync/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Applied to master, thanks. In practice, most of the code in shairport-sync is in C, except one file in C++, which is only compiled conditionally (and we don't build it). However it seems like automake uses CXX even if the C++ file is not part of the build.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 shairport-sync: requires C++

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 9 lines · Baruch Siach

Fixes:
http://autobuild.buildroot.net/results/122/122d6cedf0205e8db27d498d6a2a839e11e7b6f2/
http://autobuild.buildroot.net/results/bef/bef5fb328e6688107496cb213d8aeeca527abf03/

---
package/shairport-sync/Config.in | 5 +++--

1 file changed, 3 insertions(+), 2 deletions(-)
Quoted 4 lines

Applied to master, thanks. In practice, most of the code in shairport-sync is in C, except one file in C++, which is only compiled conditionally (and we don't build it). However it seems like automake uses CXX even if the C++ file is not part of the build.

That is afaik because of the unconditional AC_PROG_CXX. For other packages (E.G. package/ifplugd/0003-no-cxx.patch) we patch it out, but something upstreamable would naturally be nicer.

Signature · 1 line
Bye, Peter Korsgaard