Skip to contentSkip to conversation

ALSA: oxygen - Fix snd_oxygen module not loading for some (new?) Xonar DG SI cards.

PATCH In review Eugene Ganeev 2 participants 4 messages Mar 29, 2017 – Mar 30, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: oxygen - Fix snd_oxygen module not loading for some (new?) Xonar DG SI cards.

My Xonar DG SI card is showing up in lspci but no module is loaded for it.

The patch just adds a new value with card's PCI ID to oxygen_ids array.

---
 sound/pci/oxygen/oxygen.c | 1 +
 1 file changed, 1 insertion(+)
sound/pci/oxygen/oxygen.c +1 -0
index ada6c256378e..99ba0354d4cc 100644
@@ -110,6 +110,7 @@ static DEFINE_PCI_DEVICE_TABLE(oxygen_ids) = {
 	{ OXYGEN_PCI_SUBID(0x1a58, 0x0910), .driver_data = MODEL_CMEDIA_REF },
 	/* Asus Xonar DG */
 	{ OXYGEN_PCI_SUBID(0x1043, 0x8467), .driver_data = MODEL_XONAR_DG },
+	{ OXYGEN_PCI_SUBID(0x1043, 0x855e), .driver_data = MODEL_XONAR_DG },
 	/* Asus Xonar DGX */
 	{ OXYGEN_PCI_SUBID(0x1043, 0x8521), .driver_data = MODEL_XONAR_DGX },
 	/* PCI 2.0 HD Audio */
Signature · 1 line
2.11.1
maintainer
#1 lore raw
Quoted 4 lines · Eugene Ganeev

My Xonar DG SI card is showing up in lspci but no module is loaded for it.

The patch just adds a new value with card's PCI ID to oxygen_ids array.

Is the hardware identical? Do all the inputs and outputs work?

Quoted 10 lines
---
 sound/pci/oxygen/oxygen.c | 1 +
 1 file changed, 1 insertion(+)
sound/pci/oxygen/oxygen.c +0 -0
index ada6c256378e..99ba0354d4cc 100644

sound/pci/oxygen/oxygen.c static DEFINE_PCI_DEVICE_TABLE(oxygen_ids) = { · line 113

Quoted 4 lines
sound/pci/oxygen/oxygen.c +1 -0
@@ -110,6 +110,7 @@ static DEFINE_PCI_DEVICE_TABLE(oxygen_ids) = {
 	{ OXYGEN_PCI_SUBID(0x1a58, 0x0910), .driver_data = MODEL_CMEDIA_REF },
 	/* Asus Xonar DG */
 	{ OXYGEN_PCI_SUBID(0x1043, 0x8467), .driver_data = MODEL_XONAR_DG },
+	{ OXYGEN_PCI_SUBID(0x1043, 0x855e), .driver_data = MODEL_XONAR_DG },

Please add the correct name to the names[] array.

Regards.
Clemens

#2 lore raw
Quoted 7 lines · Clemens Ladisch
Quoted 4 lines · Eugene Ganeev

My Xonar DG SI card is showing up in lspci but no module is loaded for it.

The patch just adds a new value with card's PCI ID to oxygen_ids array.

Is the hardware identical? Do all the inputs and outputs work?

According to asus website they both use C-MEDIA CMI8786. The difference is that DG SI is 7.1 surround compared to 5.1 in DG. I've tested the patch, all ports seem to work except rear out. So basically the card is usable unless you use 7.1 setup.

Quoted 5 lines

Please add the correct name to the names[] array.

Regards.
Clemens.

[PATCH v2] sound: oxygen: add Xonar DG SI support

Add PCI ID for the Asus Xonar DG SI card.

---

v2:
- Added model name to names[] array.

 sound/pci/oxygen/oxygen.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/pci/oxygen/oxygen.c +7 -0
index 74afb6b75976..7ba1099fefb1 100644
@@ -94,6 +94,7 @@ enum {
 	MODEL_2CH_OUTPUT,
 	MODEL_HG2PCI,
 	MODEL_XONAR_DG,
+	MODEL_XONAR_DG_SI,
 	MODEL_XONAR_DGX,
 };
 
@@ -110,6 +111,8 @@ static const struct pci_device_id oxygen_ids[] = {
 	{ OXYGEN_PCI_SUBID(0x1a58, 0x0910), .driver_data = MODEL_CMEDIA_REF },
 	/* Asus Xonar DG */
 	{ OXYGEN_PCI_SUBID(0x1043, 0x8467), .driver_data = MODEL_XONAR_DG },
+	/* Asus Xonar DG SI */
+	{ OXYGEN_PCI_SUBID(0x1043, 0x855e), .driver_data = MODEL_XONAR_DG_SI },
 	/* Asus Xonar DGX */
 	{ OXYGEN_PCI_SUBID(0x1043, 0x8521), .driver_data = MODEL_XONAR_DGX },
 	/* PCI 2.0 HD Audio */
@@ -767,6 +770,7 @@ static int get_oxygen_model(struct oxygen *chip,
 		[MODEL_FANTASIA]	= "TempoTec HiFier Fantasia",
 		[MODEL_SERENADE]	= "TempoTec HiFier Serenade",
 		[MODEL_HG2PCI]		= "CMI8787-HG2PCI",
+		[MODEL_XONAR_DG_SI]	= "Asus Xonar DG SI",
 	};
 
 	chip->model = model_generic;
@@ -832,6 +836,9 @@ static int get_oxygen_model(struct oxygen *chip,
 		chip->model = model_xonar_dg;
 		chip->model.shortname = "Xonar DG";
 		break;
+	case MODEL_XONAR_DG_SI:
+		chip->model = model_xonar_dg;
+		break;
 	case MODEL_XONAR_DGX:
 		chip->model = model_xonar_dg;
 		chip->model.shortname = "Xonar DGX";
maintainer
#3 lore raw
Quoted 11 lines · Eugene Ganeev
Quoted 7 lines · Clemens Ladisch
Quoted 4 lines · Eugene Ganeev

My Xonar DG SI card is showing up in lspci but no module is loaded for it.

The patch just adds a new value with card's PCI ID to oxygen_ids array.

Is the hardware identical? Do all the inputs and outputs work?

According to asus website they both use C-MEDIA CMI8786. The difference is that DG SI is 7.1 surround compared to 5.1 in DG. I've tested the patch, all ports seem to work except rear out. So basically the card is usable unless you use 7.1 setup.

Strange. This would imply that the CS4245 is used for both headphones output and back surround output.

And of course this should be supported. Are you willing to experiment? (In theory, it should suffice to adjust model.dac_channels_pcm and model.adjust_dac_routing.)

Quoted 46 lines
Quoted 1 line

Please add the correct name to the names[] array.

[PATCH v2] sound: oxygen: add Xonar DG SI support

Add PCI ID for the Asus Xonar DG SI card.

---

v2:
- Added model name to names[] array.

 sound/pci/oxygen/oxygen.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/pci/oxygen/oxygen.c +4 -0
index 74afb6b75976..7ba1099fefb1 100644
@@ -94,6 +94,7 @@ enum {
 	MODEL_2CH_OUTPUT,
 	MODEL_HG2PCI,
 	MODEL_XONAR_DG,
+	MODEL_XONAR_DG_SI,
 	MODEL_XONAR_DGX,
 };
 
@@ -110,6 +111,8 @@ static const struct pci_device_id oxygen_ids[] = {
 	{ OXYGEN_PCI_SUBID(0x1a58, 0x0910), .driver_data = MODEL_CMEDIA_REF },
 	/* Asus Xonar DG */
 	{ OXYGEN_PCI_SUBID(0x1043, 0x8467), .driver_data = MODEL_XONAR_DG },
+	/* Asus Xonar DG SI */
+	{ OXYGEN_PCI_SUBID(0x1043, 0x855e), .driver_data = MODEL_XONAR_DG_SI },
 	/* Asus Xonar DGX */
 	{ OXYGEN_PCI_SUBID(0x1043, 0x8521), .driver_data = MODEL_XONAR_DGX },
 	/* PCI 2.0 HD Audio */
@@ -767,6 +770,7 @@ static int get_oxygen_model(struct oxygen *chip,
 		[MODEL_FANTASIA]	= "TempoTec HiFier Fantasia",
 		[MODEL_SERENADE]	= "TempoTec HiFier Serenade",
 		[MODEL_HG2PCI]		= "CMI8787-HG2PCI",
+		[MODEL_XONAR_DG_SI]	= "Asus Xonar DG SI",
 	};
 
 	chip->model = model_generic;

sound/pci/oxygen/oxygen.c static int get_oxygen_model(struct oxygen *chip, · line 844

Quoted 9 lines
sound/pci/oxygen/oxygen.c +3 -0
@@ -832,6 +836,9 @@ static int get_oxygen_model(struct oxygen *chip,
 		chip->model = model_xonar_dg;
 		chip->model.shortname = "Xonar DG";
 		break;
+	case MODEL_XONAR_DG_SI:
+		chip->model = model_xonar_dg;
+		break;
 	case MODEL_XONAR_DGX:
 		chip->model = model_xonar_dg;
 		chip->model.shortname = "Xonar DGX";

This does no longer apply because of the other names[] patch.

And I forgot to mention: please also update sound/pci/Kconfig and Documentation/sound/alsa-configuration.rst.

Regards,
Clemens