drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
Subsystems (2)
PATCH 1/1 drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
With CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=n we see the following link error in the i915 driver:
drivers/built-in.o: In function 'intel_backlight_device_register':
(.text+0x2a921d): undefined reference to 'backlight_device_register'
Fix this by removing the condition on ACPI from the appropriate select statement.
--- drivers/gpu/drm/i915/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/Kconfig +1 -1
@@ -15,7 +15,7 @@ config DRM_I915 # i915 depends on ACPI_VIDEO when ACPI is enabled # but for select to work, need to select ACPI_VIDEO's dependencies, ick select BACKLIGHT_LCD_SUPPORT if ACPI - select BACKLIGHT_CLASS_DEVICE if ACPI + select BACKLIGHT_CLASS_DEVICE select INPUT if ACPI select ACPI_VIDEO if ACPI select ACPI_BUTTON if ACPI
Signature · 1 line
2.11.0
Jani Nikula
maintainerQuoted 8 lines · Tobias Regnery
With
CONFIG_ACPI=nandCONFIG_BACKLIGHT_CLASS_DEVICE=nwe see the following link error in the i915 driver:
drivers/built-in.o: In function 'intel_backlight_device_register':
(.text+0x2a921d): undefined reference to 'backlight_device_register'Fix this by removing the condition on ACPI from the appropriate select statement.
The right fix for the build problem is to add empty stub functions for BACKLIGHT_CLASS_DEVICE=n in include/linux/backlight.h. I'm frankly surprised nobody's done that yet.
It's another question whether we should support and select backlight for ACPI=n, and yet another question whether we should support ACPI=n.
Also, selecting BACKLIGHT_CLASS_DEVICE is fundamentally broken, but people aren't interested [1].
BR,
Jani.
[1] http://mid.mail-archive.com/[email protected]
Quoted 19 lines
Signed-off-by Tobias Regnery <[email protected]>--- drivers/gpu/drm/i915/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/Kconfig +1
-1@@ -15,7 +15,7 @@ config DRM_I915 # i915 depends on ACPI_VIDEO when ACPI is enabled # but for select to work, need to select ACPI_VIDEO's dependencies, ick select BACKLIGHT_LCD_SUPPORT if ACPI - select BACKLIGHT_CLASS_DEVICE if ACPI + select BACKLIGHT_CLASS_DEVICE select INPUT if ACPI select ACPI_VIDEO if ACPI select ACPI_BUTTON if ACPI
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Jani Nikula
Quoted 6 lines · Tobias Regnery
With
CONFIG_ACPI=nandCONFIG_BACKLIGHT_CLASS_DEVICE=nwe see the following link error in the i915 driver:
drivers/built-in.o: In function 'intel_backlight_device_register':
(.text+0x2a921d): undefined reference to 'backlight_device_register'
Quoted 6 lines
Quoted 2 lines
Fix this by removing the condition on ACPI from the appropriate select statement.
The right fix for the build problem is to add empty stub functions for BACKLIGHT_CLASS_DEVICE=n in
include/linux/backlight.h. I'm frankly surprised nobody's done that yet.
Thanks for the advice, I will try to come up with a patch.
--
Tobias
Quoted 19 lines
It's another question whether we should support and select backlight for ACPI=n, and yet another question whether we should support ACPI=n.
Also, selecting
BACKLIGHT_CLASS_DEVICEis fundamentally broken, but people aren't interested [1].BR,
Jani.[1] http://mid.mail-archive.com/[email protected]
Quoted 6 lines
Signed-off-by Tobias Regnery <[email protected]>--- drivers/gpu/drm/i915/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 13 lines
drivers/gpu/drm/i915/Kconfig +1
-1@@ -15,7 +15,7 @@ config DRM_I915 # i915 depends on ACPI_VIDEO when ACPI is enabled # but for select to work, need to select ACPI_VIDEO's dependencies, ick select BACKLIGHT_LCD_SUPPORT if ACPI - select BACKLIGHT_CLASS_DEVICE if ACPI + select BACKLIGHT_CLASS_DEVICE select INPUT if ACPI select ACPI_VIDEO if ACPI select ACPI_BUTTON if ACPISignature · 1 line
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
In reply to Tobias Regnery== Series Details ==
== Series Details ==
Series: drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
URL : https://patchwork.freedesktop.org/series/22174/
State : warning
== Summary ==
Series 22174v1 drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
https://patchwork.freedesktop.org/api/1.0/series/22174/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-snb-2520m)fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 430s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time: 431s fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 572s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 515s fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time: 567s fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 483s fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 483s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 408s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 410s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 421s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 493s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 485s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 453s fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 570s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 452s fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 573s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 460s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 492s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time: 432s fi-snb-2520m total:278 pass:249 dwarn:1 dfail:0 fail:0 skip:28 time: 531s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time: 408s
096f7a6356b9fb071e5bee15652ef842519d77f4 drm-tip: 2017y-03m-30d-08h-56m-23s UTC integration manifest 16ee08f drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4352/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx