net/faraday: Explicitly include linux/of.h and linux/property.h
Subsystems (2)
PATCH 1/1 net/faraday: Explicitly include linux/of.h and linux/property.h
This driver uses interfaces from linux/of.h and linux/property.h but relies on implict inclusion of those headers which means that changes in other headers could break the build, as happened in -next for arm today. Add a explicit includes.
--- drivers/net/ethernet/faraday/ftgmac100.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/faraday/ftgmac100.c +2 -0
@@ -28,8 +28,10 @@#include <linux/io.h> #include <linux/module.h> #include <linux/netdevice.h> +#include <linux/of.h> #include <linux/phy.h> #include <linux/platform_device.h> +#include <linux/property.h> #include <net/ip.h> #include <net/ncsi.h>
Signature · 1 line
2.11.0
Quoted 6 lines · Mark Brown
This driver uses interfaces from
linux/of.handlinux/property.hbut relies on implict inclusion of those headers which means that changes in other headers could break the build, as happened in -next for arm today. Add a explicit includes.Signed-off-by Mark Brown <[email protected]>
Thank you for fixing this Mark.
Cheers,
Joel
Quoted 22 lines
--- drivers/net/ethernet/faraday/ftgmac100.c | 2 ++ 1 file changed, 2 insertions(+)drivers/net/ethernet/faraday/ftgmac100.c +2
-1@@ -28,8 +28,10 @@#include <linux/io.h> #include <linux/module.h> #include <linux/netdevice.h> +#include <linux/of.h> #include <linux/phy.h> #include <linux/platform_device.h> +#include <linux/property.h> #include <net/ip.h> #include <net/ncsi.h> --2.11.0
From: Mark Brown <[email protected]>
Date: Thu, 30 Mar 2017 17:00:12 +0100
Quoted 6 lines
This driver uses interfaces from
linux/of.handlinux/property.hbut relies on implict inclusion of those headers which means that changes in other headers could break the build, as happened in -next for arm today. Add a explicit includes.Signed-off-by Mark Brown <[email protected]>
Applied, thank you.