Skip to contentSkip to conversation

ftrace: Add 'function-fork' trace option (v1)

PATCH In review Namhyung Kim 3 participants 21 messages Mar 29, 2017 – Mar 30, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover ftrace: Add 'function-fork' trace option (v1)

Hello,

This patchset add 'function-fork' option to function tracer which makes pid filter to be inherited like 'event-fork' does. During the test, I found a bug of pid filter on an instance directory. The patch 1 fixes it and maybe it should go to the stable tree.

The function-fork option is disabled by default as event-fork does, but we might consider changing the default since it seems to be more natural from an user's perspective IMHO.

The code is also available at 'ftrace/function-fork-v1' branch on

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (4):
ftrace: Fix function pid filter on instances
ftrace: Add 'function-fork' trace option
selftests: ftrace: Add -l/--logdir option
selftests: ftrace: Add a testcase for function PID filter

 kernel/trace/ftrace.c                              | 47 ++++++++++-
 kernel/trace/trace.c                               |  6 +-
 kernel/trace/trace.h                               |  8 +-
 tools/testing/selftests/ftrace/ftracetest          |  5 ++
 .../ftrace/test.d/ftrace/func-filter-pid.tc        | 98 ++++++++++++++++++++++
 5 files changed, 158 insertions(+), 6 deletions(-)
 create mode 100644 tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
Signature · 1 line
2.12.0
#1 lore raw

PATCH 1/4 ftrace: Fix function pid filter on instances

When function tracer has a pid filter, it adds a probe to sched_switch to track if current task can be ignored. The probe checks the ftrace_ignore_pid from current tr to filter tasks. But it misses to delete the probe when removing an instance so that it can cause a crash due to the invalid tr pointer (use-after-free).

This is easily reproducible with the following:

  # cd /sys/kernel/debug/tracing
  # mkdir instances/buggy
  # echo $$ > instances/buggy/set_ftrace_pid
  # rmdir instances/buggy

============================================================================

  BUG: KASAN: use-after-free in ftrace_filter_pid_sched_switch_probe+0x3d/0x90
  Read of size 8 by task kworker/0:1/17
  CPU: 0 PID: 17 Comm: kworker/0:1 Tainted: G    B           4.11.0-rc3  #198
  Call Trace:
   dump_stack+0x68/0x9f
   kasan_object_err+0x21/0x70
   kasan_report.part.1+0x22b/0x500
   ? ftrace_filter_pid_sched_switch_probe+0x3d/0x90
   kasan_report+0x25/0x30
   __asan_load8+0x5e/0x70
   ftrace_filter_pid_sched_switch_probe+0x3d/0x90
   ? fpid_start+0x130/0x130
   __schedule+0x571/0xce0
   ...

To fix it, use ftrace_pid_reset() to unregister the probe. As instance_rmdir() already updated ftrace codes, it can just free the filter safely.

Fixes 0c8916c34203 ("tracing: Add rmdir to remove multibuffer instances")
---
 kernel/trace/ftrace.c | 10 ++++++----
 kernel/trace/trace.c  |  1 +
 kernel/trace/trace.h  |  2 ++
 3 files changed, 9 insertions(+), 4 deletions(-)
kernel/trace/ftrace.c +6 -4
index 0556a202c055..b451a860e885 100644
@@ -5598,13 +5598,15 @@ static void clear_ftrace_pids(struct trace_array *tr)
 	trace_free_pid_list(pid_list);
 }
 
-static void ftrace_pid_reset(struct trace_array *tr)
+void ftrace_pid_reset(struct trace_array *tr, bool update)
 {
 	mutex_lock(&ftrace_lock);
 	clear_ftrace_pids(tr);
 
-	ftrace_update_pid_func();
-	ftrace_startup_all(0);
+	if (update) {
+		ftrace_update_pid_func();
+		ftrace_startup_all(0);
+	}
 
 	mutex_unlock(&ftrace_lock);
 }
@@ -5676,7 +5678,7 @@ ftrace_pid_open(struct inode *inode, struct file *file)
 
 	if ((file->f_mode & FMODE_WRITE) &&
 	    (file->f_flags & O_TRUNC))
-		ftrace_pid_reset(tr);
+		ftrace_pid_reset(tr, true);
 
 	ret = seq_open(file, &ftrace_pid_sops);
 	if (ret < 0) {
kernel/trace/trace.c +1 -0
index b5d4b80f2d45..b92489dfa829 100644
@@ -7485,6 +7485,7 @@ static int instance_rmdir(const char *name)
 
 	tracing_set_nop(tr);
 	event_trace_del_tracer(tr);
+	ftrace_pid_reset(tr, false);
 	ftrace_destroy_function_files(tr);
 	tracefs_remove_recursive(tr->dir);
 	free_trace_buffers(tr);
kernel/trace/trace.h +2 -0
index 571acee52a32..4d9804fd9a2d 100644
@@ -897,6 +897,7 @@ void ftrace_init_tracefs(struct trace_array *tr, struct dentry *d_tracer);
 void ftrace_init_tracefs_toplevel(struct trace_array *tr,
 				  struct dentry *d_tracer);
 int init_function_trace(void);
+void ftrace_pid_reset(struct trace_array *tr, bool update);
 #else
 static inline int ftrace_trace_task(struct trace_array *tr)
 {
@@ -916,6 +917,7 @@ static inline void ftrace_reset_array_ops(struct trace_array *tr) { }
 static inline void ftrace_init_tracefs(struct trace_array *tr, struct dentry *d) { }
 static inline void ftrace_init_tracefs_toplevel(struct trace_array *tr, struct dentry *d) { }
 static inline int init_function_trace(void) { return 0; }
+static inline void ftrace_pid_reset(struct trace_array *tr, bool update) { }
 /* ftace_func_t type is not defined, use macro instead of static inline */
 #define ftrace_init_array_ops(tr, func) do { } while (0)
 #endif /* CONFIG_FUNCTION_TRACER */
Signature · 1 line
2.12.0
maintainer
#2 lore raw

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

Quoted 54 lines · On Wed, 29 Mar 2017 10:46:22 +0900 Namhyung Kim <[email protected]> wrote:

When function tracer has a pid filter, it adds a probe to sched_switch to track if current task can be ignored. The probe checks the ftrace_ignore_pid from current tr to filter tasks. But it misses to delete the probe when removing an instance so that it can cause a crash due to the invalid tr pointer (use-after-free).

This is easily reproducible with the following:

  # cd /sys/kernel/debug/tracing
  # mkdir instances/buggy
  # echo $$ > instances/buggy/set_ftrace_pid
  # rmdir instances/buggy

============================================================================

  BUG: KASAN: use-after-free in ftrace_filter_pid_sched_switch_probe+0x3d/0x90
  Read of size 8 by task kworker/0:1/17
  CPU: 0 PID: 17 Comm: kworker/0:1 Tainted: G    B           4.11.0-rc3  #198
  Call Trace:
   dump_stack+0x68/0x9f
   kasan_object_err+0x21/0x70
   kasan_report.part.1+0x22b/0x500
   ? ftrace_filter_pid_sched_switch_probe+0x3d/0x90
   kasan_report+0x25/0x30
   __asan_load8+0x5e/0x70
   ftrace_filter_pid_sched_switch_probe+0x3d/0x90
   ? fpid_start+0x130/0x130
   __schedule+0x571/0xce0
   ...

To fix it, use ftrace_pid_reset() to unregister the probe. As instance_rmdir() already updated ftrace codes, it can just free the filter safely.

Fixes 0c8916c34203 ("tracing: Add rmdir to remove multibuffer instances")
---
 kernel/trace/ftrace.c | 10 ++++++----
 kernel/trace/trace.c  |  1 +
 kernel/trace/trace.h  |  2 ++
 3 files changed, 9 insertions(+), 4 deletions(-)
kernel/trace/ftrace.c +1 -1
index 0556a202c055..b451a860e885 100644
@@ -5598,13 +5598,15 @@ static void clear_ftrace_pids(struct trace_array *tr)
 	trace_free_pid_list(pid_list);
 }
 
-static void ftrace_pid_reset(struct trace_array *tr)
+void ftrace_pid_reset(struct trace_array *tr, bool update)
 {
 	mutex_lock(&ftrace_lock);
 	clear_ftrace_pids(tr);

kernel/trace/ftrace.c static void clear_ftrace_pids(struct trace_array *tr) · line 5612

Quoted 10 lines
kernel/trace/ftrace.c +4 -2
 
-	ftrace_update_pid_func();
-	ftrace_startup_all(0);
+	if (update) {
+		ftrace_update_pid_func();
+		ftrace_startup_all(0);
+	}
 
 	mutex_unlock(&ftrace_lock);
 }

I think it is better to create a new function here. I mean, you just added a bool, that removes 2 thirds of the code when false.

Quoted 14 lines
kernel/trace/ftrace.c +1 -1
@@ -5676,7 +5678,7 @@ ftrace_pid_open(struct inode *inode, struct file *file)
 
 	if ((file->f_mode & FMODE_WRITE) &&
 	    (file->f_flags & O_TRUNC))
-		ftrace_pid_reset(tr);
+		ftrace_pid_reset(tr, true);
 
 	ret = seq_open(file, &ftrace_pid_sops);
 	if (ret < 0) {
kernel/trace/trace.c +0 -0
index b5d4b80f2d45..b92489dfa829 100644

kernel/trace/trace.c static int instance_rmdir(const char *name) · line 7488

Quoted 4 lines
kernel/trace/trace.c +1 -0
@@ -7485,6 +7485,7 @@ static int instance_rmdir(const char *name)
 
 	tracing_set_nop(tr);
 	event_trace_del_tracer(tr);
+	ftrace_pid_reset(tr, false);

Actually, if this is called after event_trace_del_tracer(), the tr is already invisible and nothing new should change.

Make a wrapper around clear_ftrace_pids() and call that instead. We don't even need to take a lock, but as I see there's a lockdep test for ftrace_lock, we should still do so just to be safe.

void ftrace_clear_pids(struct trace_array *tr)

{
	mutex_lock(&ftrace_lock);

	clear_ftrace_pids(tr);

	mutex_unlock(&ftrace_lock);
}

-- Steve

Quoted 23 lines
kernel/trace/trace.c +0 -0
 	ftrace_destroy_function_files(tr);
 	tracefs_remove_recursive(tr->dir);
 	free_trace_buffers(tr);
kernel/trace/trace.h +2 -0
index 571acee52a32..4d9804fd9a2d 100644
@@ -897,6 +897,7 @@ void ftrace_init_tracefs(struct trace_array *tr, struct dentry *d_tracer);
 void ftrace_init_tracefs_toplevel(struct trace_array *tr,
 				  struct dentry *d_tracer);
 int init_function_trace(void);
+void ftrace_pid_reset(struct trace_array *tr, bool update);
 #else
 static inline int ftrace_trace_task(struct trace_array *tr)
 {
@@ -916,6 +917,7 @@ static inline void ftrace_reset_array_ops(struct trace_array *tr) { }
 static inline void ftrace_init_tracefs(struct trace_array *tr, struct dentry *d) { }
 static inline void ftrace_init_tracefs_toplevel(struct trace_array *tr, struct dentry *d) { }
 static inline int init_function_trace(void) { return 0; }
+static inline void ftrace_pid_reset(struct trace_array *tr, bool update) { }
 /* ftace_func_t type is not defined, use macro instead of static inline */
 #define ftrace_init_array_ops(tr, func) do { } while (0)
 #endif /* CONFIG_FUNCTION_TRACER */
#3 lore raw

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

Hi Steve,

Quoted 87 lines · Steven Rostedt
Quoted 54 lines · On Wed, 29 Mar 2017 10:46:22 +0900 Namhyung Kim <[email protected]> wrote:

When function tracer has a pid filter, it adds a probe to sched_switch to track if current task can be ignored. The probe checks the ftrace_ignore_pid from current tr to filter tasks. But it misses to delete the probe when removing an instance so that it can cause a crash due to the invalid tr pointer (use-after-free).

This is easily reproducible with the following:

  # cd /sys/kernel/debug/tracing
  # mkdir instances/buggy
  # echo $$ > instances/buggy/set_ftrace_pid
  # rmdir instances/buggy

============================================================================

  BUG: KASAN: use-after-free in ftrace_filter_pid_sched_switch_probe+0x3d/0x90
  Read of size 8 by task kworker/0:1/17
  CPU: 0 PID: 17 Comm: kworker/0:1 Tainted: G    B           4.11.0-rc3  #198
  Call Trace:
   dump_stack+0x68/0x9f
   kasan_object_err+0x21/0x70
   kasan_report.part.1+0x22b/0x500
   ? ftrace_filter_pid_sched_switch_probe+0x3d/0x90
   kasan_report+0x25/0x30
   __asan_load8+0x5e/0x70
   ftrace_filter_pid_sched_switch_probe+0x3d/0x90
   ? fpid_start+0x130/0x130
   __schedule+0x571/0xce0
   ...

To fix it, use ftrace_pid_reset() to unregister the probe. As instance_rmdir() already updated ftrace codes, it can just free the filter safely.

Fixes 0c8916c34203 ("tracing: Add rmdir to remove multibuffer instances")
---
 kernel/trace/ftrace.c | 10 ++++++----
 kernel/trace/trace.c  |  1 +
 kernel/trace/trace.h  |  2 ++
 3 files changed, 9 insertions(+), 4 deletions(-)
kernel/trace/ftrace.c +1 -1
index 0556a202c055..b451a860e885 100644
@@ -5598,13 +5598,15 @@ static void clear_ftrace_pids(struct trace_array *tr)
 	trace_free_pid_list(pid_list);
 }
 
-static void ftrace_pid_reset(struct trace_array *tr)
+void ftrace_pid_reset(struct trace_array *tr, bool update)
 {
 	mutex_lock(&ftrace_lock);
 	clear_ftrace_pids(tr);

kernel/trace/ftrace.c static void clear_ftrace_pids(struct trace_array *tr) · line 5612

Quoted 10 lines
kernel/trace/ftrace.c +4 -2
 
-	ftrace_update_pid_func();
-	ftrace_startup_all(0);
+	if (update) {
+		ftrace_update_pid_func();
+		ftrace_startup_all(0);
+	}
 
 	mutex_unlock(&ftrace_lock);
 }

I think it is better to create a new function here. I mean, you just added a bool, that removes 2 thirds of the code when false.

Quoted 15 lines
kernel/trace/ftrace.c +1 -1
@@ -5676,7 +5678,7 @@ ftrace_pid_open(struct inode *inode, struct file *file)
 
 	if ((file->f_mode & FMODE_WRITE) &&
 	    (file->f_flags & O_TRUNC))
-		ftrace_pid_reset(tr);
+		ftrace_pid_reset(tr, true);
 
 	ret = seq_open(file, &ftrace_pid_sops);
 	if (ret < 0) {
kernel/trace/trace.c +0 -0
index b5d4b80f2d45..b92489dfa829 100644
@@ -7485,6 +7485,7 @@ static int instance_rmdir(const char *name)
 
Quoted 6 lines

kernel/trace/trace.c static int instance_rmdir(const char *name) · line 7488

Quoted 3 lines
kernel/trace/trace.c +1 -0
 	tracing_set_nop(tr);
 	event_trace_del_tracer(tr);
+	ftrace_pid_reset(tr, false);

Actually, if this is called after event_trace_del_tracer(), the tr is already invisible and nothing new should change.

I don't follow. After event_trace_del_tracer(), the tr is invisible from the probe of event tracing but still is visible from the probe of function tracing, right?

Quoted 4 lines

Make a wrapper around clear_ftrace_pids() and call that instead. We don't even need to take a lock, but as I see there's a lockdep test for ftrace_lock, we should still do so just to be safe.

Right, that's why I call ftrace_pid_reset() instead of clear_ftrace_pids(). So do you prefer adding a new wrapper like below rather than reusing ftrace_pid_reset() with a new argument?

Thanks,
Namhyung

Quoted 37 lines

void ftrace_clear_pids(struct trace_array *tr)

{
	mutex_lock(&ftrace_lock);

	clear_ftrace_pids(tr);

	mutex_unlock(&ftrace_lock);
}

-- Steve

Quoted 23 lines
kernel/trace/trace.c +0 -0
 	ftrace_destroy_function_files(tr);
 	tracefs_remove_recursive(tr->dir);
 	free_trace_buffers(tr);
kernel/trace/trace.h +2 -0
index 571acee52a32..4d9804fd9a2d 100644
@@ -897,6 +897,7 @@ void ftrace_init_tracefs(struct trace_array *tr, struct dentry *d_tracer);
 void ftrace_init_tracefs_toplevel(struct trace_array *tr,
 				  struct dentry *d_tracer);
 int init_function_trace(void);
+void ftrace_pid_reset(struct trace_array *tr, bool update);
 #else
 static inline int ftrace_trace_task(struct trace_array *tr)
 {
@@ -916,6 +917,7 @@ static inline void ftrace_reset_array_ops(struct trace_array *tr) { }
 static inline void ftrace_init_tracefs(struct trace_array *tr, struct dentry *d) { }
 static inline void ftrace_init_tracefs_toplevel(struct trace_array *tr, struct dentry *d) { }
 static inline int init_function_trace(void) { return 0; }
+static inline void ftrace_pid_reset(struct trace_array *tr, bool update) { }
 /* ftace_func_t type is not defined, use macro instead of static inline */
 #define ftrace_init_array_ops(tr, func) do { } while (0)
 #endif /* CONFIG_FUNCTION_TRACER */
maintainer
#4 lore raw

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

Quoted 6 lines · On Wed, 29 Mar 2017 11:20:37 +0900 Namhyung Kim <[email protected]> wrote:
Quoted 2 lines

Actually, if this is called after event_trace_del_tracer(), the tr is already invisible and nothing new should change.

I don't follow. After event_trace_del_tracer(), the tr is invisible from the probe of event tracing but still is visible from the probe of function tracing, right?

Well, nothing should be able to get to the set_ftrace_filter file when there. Because of the tr->ref count. But keeping the lock is safer regardless, and it's not a fast path, so the extra overhead if the lock isn't needed is no big deal.

Quoted 9 lines
Quoted 5 lines

Make a wrapper around clear_ftrace_pids() and call that instead. We don't even need to take a lock, but as I see there's a lockdep test for ftrace_lock, we should still do so just to be safe.

Right, that's why I call ftrace_pid_reset() instead of clear_ftrace_pids(). So do you prefer adding a new wrapper like below rather than reusing ftrace_pid_reset() with a new argument?

Yes, because the bool passed in is confusing. A separate function like below is more descriptive.

-- Steve

Quoted 14 lines

Thanks,
Namhyung

Quoted 9 lines

void ftrace_clear_pids(struct trace_array *tr)

{
	mutex_lock(&ftrace_lock);

	clear_ftrace_pids(tr);

	mutex_unlock(&ftrace_lock);
}
#5 lore raw

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

Quoted 7 lines · Steven Rostedt
Quoted 3 lines · On Wed, 29 Mar 2017 11:20:37 +0900 Namhyung Kim <[email protected]> wrote:
Quoted 2 lines

Actually, if this is called after event_trace_del_tracer(), the tr is already invisible and nothing new should change.

Quoted 8 lines
Quoted 3 lines

I don't follow. After event_trace_del_tracer(), the tr is invisible from the probe of event tracing but still is visible from the probe of function tracing, right?

Well, nothing should be able to get to the set_ftrace_filter file when there. Because of the tr->ref count. But keeping the lock is safer regardless, and it's not a fast path, so the extra overhead if the lock isn't needed is no big deal.

Oh, I meant if a pid filter was already set when removing the instance. Function filters should be inactive since function tracer was finished (via tracing_set_nop), but the probe on sched_switch event (for pid filter) is still active and references the tr.

Thanks,
Namhyung

Quoted 30 lines
Quoted 10 lines
Quoted 6 lines

Make a wrapper around clear_ftrace_pids() and call that instead. We don't even need to take a lock, but as I see there's a lockdep test for ftrace_lock, we should still do so just to be safe.

Right, that's why I call ftrace_pid_reset() instead of clear_ftrace_pids(). So do you prefer adding a new wrapper like below rather than reusing ftrace_pid_reset() with a new argument?

Yes, because the bool passed in is confusing. A separate function like below is more descriptive.

-- Steve

Quoted 14 lines

Thanks,
Namhyung

Quoted 9 lines

void ftrace_clear_pids(struct trace_array *tr)

{
	mutex_lock(&ftrace_lock);

	clear_ftrace_pids(tr);

	mutex_unlock(&ftrace_lock);
}
maintainer
#6 lore raw

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

Quoted 17 lines · On Wed, 29 Mar 2017 11:42:27 +0900 Namhyung Kim <[email protected]> wrote:
Quoted 7 lines · Steven Rostedt
Quoted 3 lines · On Wed, 29 Mar 2017 11:20:37 +0900 Namhyung Kim <[email protected]> wrote:
Quoted 2 lines

Actually, if this is called after event_trace_del_tracer(), the tr is already invisible and nothing new should change.

Quoted 8 lines
Quoted 3 lines

I don't follow. After event_trace_del_tracer(), the tr is invisible from the probe of event tracing but still is visible from the probe of function tracing, right?

Well, nothing should be able to get to the set_ftrace_filter file when there. Because of the tr->ref count. But keeping the lock is safer regardless, and it's not a fast path, so the extra overhead if the lock isn't needed is no big deal.

Quoted 5 lines

Oh, I meant if a pid filter was already set when removing the instance. Function filters should be inactive since function tracer was finished (via tracing_set_nop), but the probe on sched_switch event (for pid filter) is still active and references the tr.

I think we are talking about two different things. I was simply talking about the need to take the ftrace_lock or not in the clear_ftrace_pids() call here. I don't think we have to, because nothing should be in contention with it at that point. But it doesn't hurt to take it.

-- Steve

#7 lore raw

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

Quoted 26 lines · Steven Rostedt
Quoted 17 lines · On Wed, 29 Mar 2017 11:42:27 +0900 Namhyung Kim <[email protected]> wrote:
Quoted 7 lines · Steven Rostedt
Quoted 3 lines · On Wed, 29 Mar 2017 11:20:37 +0900 Namhyung Kim <[email protected]> wrote:
Quoted 2 lines

Actually, if this is called after event_trace_del_tracer(), the tr is already invisible and nothing new should change.

Quoted 8 lines
Quoted 3 lines

I don't follow. After event_trace_del_tracer(), the tr is invisible from the probe of event tracing but still is visible from the probe of function tracing, right?

Well, nothing should be able to get to the set_ftrace_filter file when there. Because of the tr->ref count. But keeping the lock is safer regardless, and it's not a fast path, so the extra overhead if the lock isn't needed is no big deal.

Quoted 5 lines

Oh, I meant if a pid filter was already set when removing the instance. Function filters should be inactive since function tracer was finished (via tracing_set_nop), but the probe on sched_switch event (for pid filter) is still active and references the tr.

Quoted 5 lines

I think we are talking about two different things. I was simply talking about the need to take the ftrace_lock or not in the clear_ftrace_pids() call here. I don't think we have to, because nothing should be in contention with it at that point. But it doesn't hurt to take it.

Right, I agree with you wrt the locking.

Thanks,
Namhyung

#8 lore raw

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

In reply to Steven Rostedt
Quoted 65 lines · Steven Rostedt
Quoted 62 lines · On Wed, 29 Mar 2017 10:46:22 +0900 Namhyung Kim <[email protected]> wrote:

When function tracer has a pid filter, it adds a probe to sched_switch to track if current task can be ignored. The probe checks the ftrace_ignore_pid from current tr to filter tasks. But it misses to delete the probe when removing an instance so that it can cause a crash due to the invalid tr pointer (use-after-free).

This is easily reproducible with the following:

  # cd /sys/kernel/debug/tracing
  # mkdir instances/buggy
  # echo $$ > instances/buggy/set_ftrace_pid
  # rmdir instances/buggy

============================================================================

  BUG: KASAN: use-after-free in ftrace_filter_pid_sched_switch_probe+0x3d/0x90
  Read of size 8 by task kworker/0:1/17
  CPU: 0 PID: 17 Comm: kworker/0:1 Tainted: G    B           4.11.0-rc3  #198
  Call Trace:
   dump_stack+0x68/0x9f
   kasan_object_err+0x21/0x70
   kasan_report.part.1+0x22b/0x500
   ? ftrace_filter_pid_sched_switch_probe+0x3d/0x90
   kasan_report+0x25/0x30
   __asan_load8+0x5e/0x70
   ftrace_filter_pid_sched_switch_probe+0x3d/0x90
   ? fpid_start+0x130/0x130
   __schedule+0x571/0xce0
   ...

To fix it, use ftrace_pid_reset() to unregister the probe. As instance_rmdir() already updated ftrace codes, it can just free the filter safely.

Fixes 0c8916c34203 ("tracing: Add rmdir to remove multibuffer instances")
---
 kernel/trace/ftrace.c | 10 ++++++----
 kernel/trace/trace.c  |  1 +
 kernel/trace/trace.h  |  2 ++
 3 files changed, 9 insertions(+), 4 deletions(-)
kernel/trace/ftrace.c +5 -3
index 0556a202c055..b451a860e885 100644
@@ -5598,13 +5598,15 @@ static void clear_ftrace_pids(struct trace_array *tr)
 	trace_free_pid_list(pid_list);
 }
 
-static void ftrace_pid_reset(struct trace_array *tr)
+void ftrace_pid_reset(struct trace_array *tr, bool update)
 {
 	mutex_lock(&ftrace_lock);
 	clear_ftrace_pids(tr);
 
-	ftrace_update_pid_func();
-	ftrace_startup_all(0);
+	if (update) {
+		ftrace_update_pid_func();
+		ftrace_startup_all(0);
+	}
 
Quoted 5 lines

kernel/trace/ftrace.c static void clear_ftrace_pids(struct trace_array *tr) · line 5612

Quoted 2 lines
kernel/trace/ftrace.c +0 -0
 	mutex_unlock(&ftrace_lock);
 }

I think it is better to create a new function here. I mean, you just added a bool, that removes 2 thirds of the code when false.

Ah, missed this part. Ok, I'll make it a separate function.

Thanks,
Namhyung

#9 lore raw

PATCH 2/4 ftrace: Add 'function-fork' trace option

In reply to Namhyung Kim

The function-fork option is same as event-fork that it tracks task fork/exit and set the pid filter properly. This can be useful if user wants to trace selected tasks including their children only.

---
 kernel/trace/ftrace.c | 37 +++++++++++++++++++++++++++++++++++++
 kernel/trace/trace.c  |  5 ++++-
 kernel/trace/trace.h  |  6 +++++-
 3 files changed, 46 insertions(+), 2 deletions(-)
kernel/trace/ftrace.c +37 -0
index b451a860e885..7ca2ed8d0a48 100644
@@ -5575,6 +5575,43 @@ ftrace_filter_pid_sched_switch_probe(void *data, bool preempt,
 		       trace_ignore_this_task(pid_list, next));
 }
 
+static void
+ftrace_pid_follow_sched_process_fork(void *data,
+				     struct task_struct *self,
+				     struct task_struct *task)
+{
+	struct trace_pid_list *pid_list;
+	struct trace_array *tr = data;
+
+	pid_list = rcu_dereference_sched(tr->function_pids);
+	trace_filter_add_remove_task(pid_list, self, task);
+}
+
+static void
+ftrace_pid_follow_sched_process_exit(void *data, struct task_struct *task)
+{
+	struct trace_pid_list *pid_list;
+	struct trace_array *tr = data;
+
+	pid_list = rcu_dereference_sched(tr->function_pids);
+	trace_filter_add_remove_task(pid_list, NULL, task);
+}
+
+void ftrace_pid_follow_fork(struct trace_array *tr, bool enable)
+{
+	if (enable) {
+		register_trace_sched_process_fork(ftrace_pid_follow_sched_process_fork,
+						  tr);
+		register_trace_sched_process_exit(ftrace_pid_follow_sched_process_exit,
+						  tr);
+	} else {
+		unregister_trace_sched_process_fork(ftrace_pid_follow_sched_process_fork,
+						    tr);
+		unregister_trace_sched_process_exit(ftrace_pid_follow_sched_process_exit,
+						    tr);
+	}
+}
+
 static void clear_ftrace_pids(struct trace_array *tr)
 {
 	struct trace_pid_list *pid_list;
kernel/trace/trace.c +4 -1
index b92489dfa829..291d8fc9dc36 100644
@@ -257,7 +257,7 @@ unsigned long long ns2usecs(u64 nsec)
 
 /* trace_flags that are default zero for instances */
 #define ZEROED_TRACE_FLAGS \
-	TRACE_ITER_EVENT_FORK
+	(TRACE_ITER_EVENT_FORK | TRACE_ITER_FUNC_FORK)
 
 /*
  * The global_trace is the descriptor that holds the top-level tracing
@@ -4205,6 +4205,9 @@ int set_tracer_flag(struct trace_array *tr, unsigned int mask, int enabled)
 	if (mask == TRACE_ITER_EVENT_FORK)
 		trace_event_follow_fork(tr, enabled);
 
+	if (mask == TRACE_ITER_FUNC_FORK)
+		ftrace_pid_follow_fork(tr, enabled);
+
 	if (mask == TRACE_ITER_OVERWRITE) {
 		ring_buffer_change_overwrite(tr->trace_buffer.buffer, enabled);
 #ifdef CONFIG_TRACER_MAX_TRACE
kernel/trace/trace.h +5 -1
index 4d9804fd9a2d..bacf5e845c55 100644
@@ -898,6 +898,7 @@ void ftrace_init_tracefs_toplevel(struct trace_array *tr,
 				  struct dentry *d_tracer);
 int init_function_trace(void);
 void ftrace_pid_reset(struct trace_array *tr, bool update);
+void ftrace_pid_follow_fork(struct trace_array *tr, bool enable);
 #else
 static inline int ftrace_trace_task(struct trace_array *tr)
 {
@@ -918,6 +919,7 @@ static inline void ftrace_init_tracefs(struct trace_array *tr, struct dentry *d)
 static inline void ftrace_init_tracefs_toplevel(struct trace_array *tr, struct dentry *d) { }
 static inline int init_function_trace(void) { return 0; }
 static inline void ftrace_pid_reset(struct trace_array *tr, bool update) { }
+static inline void ftrace_pid_follow_fork(struct trace_array *tr, bool enable) { }
 /* ftace_func_t type is not defined, use macro instead of static inline */
 #define ftrace_init_array_ops(tr, func) do { } while (0)
 #endif /* CONFIG_FUNCTION_TRACER */
@@ -991,11 +993,13 @@ extern int trace_get_user(struct trace_parser *parser, const char __user *ubuf,
 
 #ifdef CONFIG_FUNCTION_TRACER
 # define FUNCTION_FLAGS						\
-		C(FUNCTION,		"function-trace"),
+		C(FUNCTION,		"function-trace"),	\
+		C(FUNC_FORK,		"function-fork"),
 # define FUNCTION_DEFAULT_FLAGS		TRACE_ITER_FUNCTION
 #else
 # define FUNCTION_FLAGS
 # define FUNCTION_DEFAULT_FLAGS		0UL
+# define TRACE_ITER_FUNC_FORK		0UL
 #endif
 
 #ifdef CONFIG_STACKTRACE
Signature · 1 line
2.12.0
maintainer
#10 lore raw

Re: [PATCH 2/4] ftrace: Add 'function-fork' trace option

Quoted 3 lines · On Wed, 29 Mar 2017 10:46:23 +0900 Namhyung Kim <[email protected]> wrote:

The function-fork option is same as event-fork that it tracks task fork/exit and set the pid filter properly. This can be useful if user wants to trace selected tasks including their children only.

Actually, I had every set, but it appears I stopped at this step. You just finished it ;-)

Although, I think there was some issues with function tracing. I'll have to do some more testing an analysis tomorrow. But looking at this code, it currently appears fine.

-- Steve

Quoted 114 lines
---
 kernel/trace/ftrace.c | 37 +++++++++++++++++++++++++++++++++++++
 kernel/trace/trace.c  |  5 ++++-
 kernel/trace/trace.h  |  6 +++++-
 3 files changed, 46 insertions(+), 2 deletions(-)
kernel/trace/ftrace.c +37 -0
index b451a860e885..7ca2ed8d0a48 100644
@@ -5575,6 +5575,43 @@ ftrace_filter_pid_sched_switch_probe(void *data, bool preempt,
 		       trace_ignore_this_task(pid_list, next));
 }
 
+static void
+ftrace_pid_follow_sched_process_fork(void *data,
+				     struct task_struct *self,
+				     struct task_struct *task)
+{
+	struct trace_pid_list *pid_list;
+	struct trace_array *tr = data;
+
+	pid_list = rcu_dereference_sched(tr->function_pids);
+	trace_filter_add_remove_task(pid_list, self, task);
+}
+
+static void
+ftrace_pid_follow_sched_process_exit(void *data, struct task_struct *task)
+{
+	struct trace_pid_list *pid_list;
+	struct trace_array *tr = data;
+
+	pid_list = rcu_dereference_sched(tr->function_pids);
+	trace_filter_add_remove_task(pid_list, NULL, task);
+}
+
+void ftrace_pid_follow_fork(struct trace_array *tr, bool enable)
+{
+	if (enable) {
+		register_trace_sched_process_fork(ftrace_pid_follow_sched_process_fork,
+						  tr);
+		register_trace_sched_process_exit(ftrace_pid_follow_sched_process_exit,
+						  tr);
+	} else {
+		unregister_trace_sched_process_fork(ftrace_pid_follow_sched_process_fork,
+						    tr);
+		unregister_trace_sched_process_exit(ftrace_pid_follow_sched_process_exit,
+						    tr);
+	}
+}
+
 static void clear_ftrace_pids(struct trace_array *tr)
 {
 	struct trace_pid_list *pid_list;
kernel/trace/trace.c +4 -1
index b92489dfa829..291d8fc9dc36 100644
@@ -257,7 +257,7 @@ unsigned long long ns2usecs(u64 nsec)
 
 /* trace_flags that are default zero for instances */
 #define ZEROED_TRACE_FLAGS \
-	TRACE_ITER_EVENT_FORK
+	(TRACE_ITER_EVENT_FORK | TRACE_ITER_FUNC_FORK)
 
 /*
  * The global_trace is the descriptor that holds the top-level tracing
@@ -4205,6 +4205,9 @@ int set_tracer_flag(struct trace_array *tr, unsigned int mask, int enabled)
 	if (mask == TRACE_ITER_EVENT_FORK)
 		trace_event_follow_fork(tr, enabled);
 
+	if (mask == TRACE_ITER_FUNC_FORK)
+		ftrace_pid_follow_fork(tr, enabled);
+
 	if (mask == TRACE_ITER_OVERWRITE) {
 		ring_buffer_change_overwrite(tr->trace_buffer.buffer, enabled);
 #ifdef CONFIG_TRACER_MAX_TRACE
kernel/trace/trace.h +5 -1
index 4d9804fd9a2d..bacf5e845c55 100644
@@ -898,6 +898,7 @@ void ftrace_init_tracefs_toplevel(struct trace_array *tr,
 				  struct dentry *d_tracer);
 int init_function_trace(void);
 void ftrace_pid_reset(struct trace_array *tr, bool update);
+void ftrace_pid_follow_fork(struct trace_array *tr, bool enable);
 #else
 static inline int ftrace_trace_task(struct trace_array *tr)
 {
@@ -918,6 +919,7 @@ static inline void ftrace_init_tracefs(struct trace_array *tr, struct dentry *d)
 static inline void ftrace_init_tracefs_toplevel(struct trace_array *tr, struct dentry *d) { }
 static inline int init_function_trace(void) { return 0; }
 static inline void ftrace_pid_reset(struct trace_array *tr, bool update) { }
+static inline void ftrace_pid_follow_fork(struct trace_array *tr, bool enable) { }
 /* ftace_func_t type is not defined, use macro instead of static inline */
 #define ftrace_init_array_ops(tr, func) do { } while (0)
 #endif /* CONFIG_FUNCTION_TRACER */
@@ -991,11 +993,13 @@ extern int trace_get_user(struct trace_parser *parser, const char __user *ubuf,
 
 #ifdef CONFIG_FUNCTION_TRACER
 # define FUNCTION_FLAGS						\
-		C(FUNCTION,		"function-trace"),
+		C(FUNCTION,		"function-trace"),	\
+		C(FUNC_FORK,		"function-fork"),
 # define FUNCTION_DEFAULT_FLAGS		TRACE_ITER_FUNCTION
 #else
 # define FUNCTION_FLAGS
 # define FUNCTION_DEFAULT_FLAGS		0UL
+# define TRACE_ITER_FUNC_FORK		0UL
 #endif
 
 #ifdef CONFIG_STACKTRACE
maintainer
#11 lore raw

Re: [PATCH 2/4] ftrace: Add 'function-fork' trace option

Quoted 10 lines · On Tue, 28 Mar 2017 22:18:52 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 3 lines · On Wed, 29 Mar 2017 10:46:23 +0900 Namhyung Kim <[email protected]> wrote:

The function-fork option is same as event-fork that it tracks task fork/exit and set the pid filter properly. This can be useful if user wants to trace selected tasks including their children only.

Actually, I had every set, but it appears I stopped at this step. You just finished it ;-)

It's good to know that if I ever did get hit by a bus, my unfinished upstream work would actually get completed. :-)

-- Steve

#12 lore raw

PATCH 3/4 selftests: ftrace: Add -l/--logdir option

In reply to Namhyung Kim

In my virtual machine setup, running ftracetest failed on creating LOG_DIR on a read-only filesystem. It'd be convenient to provide an option to specify a different directory as log directory.

Cc Masami Hiramatsu <[email protected]>
Cc Steven Rostedt <[email protected]>
Cc Shuah Khan <[email protected]>
---
 tools/testing/selftests/ftrace/ftracetest | 5 +++++
 1 file changed, 5 insertions(+)
tools/testing/selftests/ftrace/ftracetest +5 -0
index 52e3c4df28d6..a8631d978725 100755
@@ -16,6 +16,7 @@ echo "		-k|--keep  Keep passed test logs"
 echo "		-v|--verbose Increase verbosity of test messages"
 echo "		-vv        Alias of -v -v (Show all results in stdout)"
 echo "		-d|--debug Debug mode (trace all shell commands)"
+echo "		-l|--logdir <dir> Save logs on the <dir>"
 exit $1
 }
 
@@ -64,6 +65,10 @@ parse_opts() { # opts
       DEBUG=1
       shift 1
     ;;
+    --logdir|-l)
+      LOG_DIR=$2
+      shift 2
+    ;;
     *.tc)
       if [ -f "$1" ]; then
         OPT_TEST_CASES="$OPT_TEST_CASES `abspath $1`"
Signature · 1 line
2.12.0
maintainer Acked-by on v1 3/4
#13 lore raw

Re: [PATCH 3/4] selftests: ftrace: Add -l/--logdir option

Quoted 4 lines · On Wed, 29 Mar 2017 10:46:24 +0900 Namhyung Kim <[email protected]> wrote:

In my virtual machine setup, running ftracetest failed on creating LOG_DIR on a read-only filesystem. It'd be convenient to provide an option to specify a different directory as log directory.

Looks good to me :)

Thanks!

Quoted 34 lines
Cc Masami Hiramatsu <[email protected]>
Cc Steven Rostedt <[email protected]>
Cc Shuah Khan <[email protected]>
---
 tools/testing/selftests/ftrace/ftracetest | 5 +++++
 1 file changed, 5 insertions(+)
tools/testing/selftests/ftrace/ftracetest +5 -0
index 52e3c4df28d6..a8631d978725 100755
@@ -16,6 +16,7 @@ echo "		-k|--keep  Keep passed test logs"
 echo "		-v|--verbose Increase verbosity of test messages"
 echo "		-vv        Alias of -v -v (Show all results in stdout)"
 echo "		-d|--debug Debug mode (trace all shell commands)"
+echo "		-l|--logdir <dir> Save logs on the <dir>"
 exit $1
 }
 
@@ -64,6 +65,10 @@ parse_opts() { # opts
       DEBUG=1
       shift 1
     ;;
+    --logdir|-l)
+      LOG_DIR=$2
+      shift 2
+    ;;
     *.tc)
       if [ -f "$1" ]; then
         OPT_TEST_CASES="$OPT_TEST_CASES `abspath $1`"
Signature · 1 line
2.12.0
Signature · 1 line
Masami Hiramatsu <[email protected]>
#14 lore raw

PATCH 4/4 selftests: ftrace: Add a testcase for function PID filter

In reply to Namhyung Kim

Like event pid filtering test, add function pid filtering test with the new "function-fork" option. It also tests it on an instance directory so that it can verify the bug related pid filtering on instances.

Cc Masami Hiramatsu <[email protected]>
Cc Steven Rostedt <[email protected]>
Cc Shuah Khan <[email protected]>
---
 .../ftrace/test.d/ftrace/func-filter-pid.tc        | 98 ++++++++++++++++++++++
 1 file changed, 98 insertions(+)
 create mode 100644 tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc new file +98 -0
new file mode 100644
index 000000000000..cd552f44c3b4
@@ -0,0 +1,98 @@
+#!/bin/sh
+# description: ftrace - function pid filters
+
+# Make sure that function pid matching filter works.
+# Also test it on an instance directory
+
+if ! grep -q function available_tracers; then
+    echo "no function tracer configured"
+    exit_unsupported
+fi
+
+if [ ! -f set_ftrace_pid ]; then
+    echo "set_ftrace_pid not found? Is function tracer not set?"
+    exit_unsupported
+fi
+
+if [ ! -f set_ftrace_filter ]; then
+    echo "set_ftrace_filter not found? Is function tracer not set?"
+    exit_unsupported
+fi
+
+read PID _ < /proc/self/stat
+
+# default value of function-fork option
+orig_value=`grep function-fork trace_options`
+
+do_reset() {
+    reset_tracer
+    clear_trace
+    enable_tracing
+    echo > set_ftrace_filter
+    echo > set_ftrace_pid
+
+    echo $orig_value > trace_options
+}
+
+fail() { # msg
+    do_reset
+    echo $1
+    exit $FAIL
+}
+
+yield() {
+    ping localhost -c 1 || sleep .001 || usleep 1 || sleep 1
+}
+
+do_test() {
+    disable_tracing
+
+    echo do_execve* > set_ftrace_filter
+    echo *do_fork >> set_ftrace_filter
+
+    echo $PID > set_ftrace_pid
+    echo function > current_tracer
+
+    # don't allow children to be traced
+    echo nofunction-fork > trace_options
+
+    enable_tracing
+    yield
+
+    count_pid=`cat trace | grep -v ^# | grep $PID | wc -l`
+    count_other=`cat trace | grep -v ^# | grep -v $PID | wc -l`
+
+    # count_other should be 0
+    if [ $count_pid -eq 0 -o $count_other -ne 0 ]; then
+	fail "PID filtering not working?"
+    fi
+
+    disable_tracing
+    clear_trace
+
+    # allow children to be traced
+    echo function-fork > trace_options
+
+    enable_tracing
+    yield
+
+    count_pid=`cat trace | grep -v ^# | grep $PID | wc -l`
+    count_other=`cat trace | grep -v ^# | grep -v $PID | wc -l`
+
+    # count_other should NOT be 0
+    if [ $count_pid -eq 0 -o $count_other -eq 0 ]; then
+	fail "PID filtering not following fork?"
+    fi
+}
+
+do_test
+
+mkdir instances/foo
+cd instances/foo
+do_test
+cd ../../
+rmdir instances/foo
+
+do_reset
+
+exit 0
Signature · 1 line
2.12.0
maintainer
#15 lore raw
In reply to Namhyung Kim
Quoted 7 lines · On Wed, 29 Mar 2017 10:46:21 +0900 Namhyung Kim <[email protected]> wrote:

Hello,

This patchset add 'function-fork' option to function tracer which makes pid filter to be inherited like 'event-fork' does. During the test, I found a bug of pid filter on an instance directory. The patch 1 fixes it and maybe it should go to the stable tree.

Quoted 8 lines

The function-fork option is disabled by default as event-fork does, but we might consider changing the default since it seems to be more natural from an user's perspective IMHO.

The code is also available at 'ftrace/function-fork-v1' branch on

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks for the reminder. I actually have this functionality working, and just forgot to push it :-/ I've had it done months ago too.

I'll take a look at what you did and compare it to my changes. Now I need to find which branch I left it in (I have 446 git branches in my repo!)

-- Steve

maintainer
#16 lore raw
In reply to Namhyung Kim
Quoted 10 lines · On Wed, 29 Mar 2017 10:46:21 +0900 Namhyung Kim <[email protected]> wrote:

Hello,

This patchset add 'function-fork' option to function tracer which makes pid filter to be inherited like 'event-fork' does. During the test, I found a bug of pid filter on an instance directory. The patch 1 fixes it and maybe it should go to the stable tree.

The function-fork option is disabled by default as event-fork does, but we might consider changing the default since it seems to be more natural from an user's perspective IMHO.

By the way, I thought that event-fork option also effected to function tracer. Is there any reason we should separate those? I mean, we can add "trace-fork" option instead of "function-fork" for setting both pid filters at once.

Thank you,

Quoted 26 lines

The code is also available at 'ftrace/function-fork-v1' branch on

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (4):
ftrace: Fix function pid filter on instances
ftrace: Add 'function-fork' trace option
selftests: ftrace: Add -l/--logdir option
selftests: ftrace: Add a testcase for function PID filter

 kernel/trace/ftrace.c                              | 47 ++++++++++-
 kernel/trace/trace.c                               |  6 +-
 kernel/trace/trace.h                               |  8 +-
 tools/testing/selftests/ftrace/ftracetest          |  5 ++
 .../ftrace/test.d/ftrace/func-filter-pid.tc        | 98 ++++++++++++++++++++++
 5 files changed, 158 insertions(+), 6 deletions(-)
 create mode 100644 tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
Signature · 1 line
2.12.0
Signature · 1 line
Masami Hiramatsu <[email protected]>
#17 lore raw

Hi Masami,

Quoted 14 lines · Masami Hiramatsu
Quoted 10 lines · On Wed, 29 Mar 2017 10:46:21 +0900 Namhyung Kim <[email protected]> wrote:

Hello,

This patchset add 'function-fork' option to function tracer which makes pid filter to be inherited like 'event-fork' does. During the test, I found a bug of pid filter on an instance directory. The patch 1 fixes it and maybe it should go to the stable tree.

The function-fork option is disabled by default as event-fork does, but we might consider changing the default since it seems to be more natural from an user's perspective IMHO.

Quoted 6 lines

By the way, I thought that event-fork option also effected to function tracer. Is there any reason we should separate those? I mean, we can add "trace-fork" option instead of "function-fork" for setting both pid filters at once.

Thank you,

I'm ok with combining two options.

Thanks
Namhyung

maintainer
#18 lore raw
Quoted 17 lines · On Thu, 30 Mar 2017 10:40:46 +0900 Namhyung Kim <[email protected]> wrote:

Hi Masami,

Quoted 14 lines · Masami Hiramatsu
Quoted 10 lines · On Wed, 29 Mar 2017 10:46:21 +0900 Namhyung Kim <[email protected]> wrote:

Hello,

This patchset add 'function-fork' option to function tracer which makes pid filter to be inherited like 'event-fork' does. During the test, I found a bug of pid filter on an instance directory. The patch 1 fixes it and maybe it should go to the stable tree.

The function-fork option is disabled by default as event-fork does, but we might consider changing the default since it seems to be more natural from an user's perspective IMHO.

Quoted 9 lines
Quoted 6 lines

By the way, I thought that event-fork option also effected to function tracer. Is there any reason we should separate those? I mean, we can add "trace-fork" option instead of "function-fork" for setting both pid filters at once.

Thank you,

I'm ok with combining two options.

I prefer not. Mainly because they are two different mechanisms, and only event-fork is available now. trace-cmd will use ptrace if function fork is needed. Having it separate will let trace-cmd know if it needs to use ptrace or not for function forking.

-- Steve

maintainer
#19 lore raw
Quoted 25 lines · On Thu, 30 Mar 2017 09:49:29 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 22 lines · On Thu, 30 Mar 2017 10:40:46 +0900 Namhyung Kim <[email protected]> wrote:

Hi Masami,

Quoted 19 lines · Masami Hiramatsu
Quoted 10 lines · On Wed, 29 Mar 2017 10:46:21 +0900 Namhyung Kim <[email protected]> wrote:

Hello,

This patchset add 'function-fork' option to function tracer which makes pid filter to be inherited like 'event-fork' does. During the test, I found a bug of pid filter on an instance directory. The patch 1 fixes it and maybe it should go to the stable tree.

The function-fork option is disabled by default as event-fork does, but we might consider changing the default since it seems to be more natural from an user's perspective IMHO.

By the way, I thought that event-fork option also effected to function tracer. Is there any reason we should separate those? I mean, we can add "trace-fork" option instead of "function-fork" for setting both pid filters at once.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Thank you,

I'm ok with combining two options.

I prefer not. Mainly because they are two different mechanisms, and only event-fork is available now.

That sounds like implementation issue. From the viewpoint of users, they may want to use just one knob to filter both. And I didn't suggest replacing event-fork, but adding trace-fork for both, like a superset option.

Quoted 3 lines

trace-cmd will use ptrace if function
fork is needed. Having it separate will let trace-cmd know if it needs to use ptrace or not for function forking.

Yeah, that's a good workaround for older kernel.

Thank you,

Signature · 1 line
Masami Hiramatsu <[email protected]>
maintainer
#20 lore raw
Quoted 33 lines · On Fri, 31 Mar 2017 07:25:50 +0900 Masami Hiramatsu <[email protected]> wrote:
Quoted 30 lines · On Thu, 30 Mar 2017 09:49:29 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 26 lines · On Thu, 30 Mar 2017 10:40:46 +0900 Namhyung Kim <[email protected]> wrote:

Hi Masami,

Quoted 14 lines · Masami Hiramatsu
Quoted 10 lines · On Wed, 29 Mar 2017 10:46:21 +0900 Namhyung Kim <[email protected]> wrote:

Hello,

This patchset add 'function-fork' option to function tracer which makes pid filter to be inherited like 'event-fork' does. During the test, I found a bug of pid filter on an instance directory. The patch 1 fixes it and maybe it should go to the stable tree.

The function-fork option is disabled by default as event-fork does, but we might consider changing the default since it seems to be more natural from an user's perspective IMHO.

Quoted 6 lines

By the way, I thought that event-fork option also effected to function tracer. Is there any reason we should separate those? I mean, we can add "trace-fork" option instead of "function-fork" for setting both pid filters at once.

Thank you,

I'm ok with combining two options.

Quoted 7 lines
Quoted 2 lines

I prefer not. Mainly because they are two different mechanisms, and only event-fork is available now.

That sounds like implementation issue. From the viewpoint of users, they may want to use just one knob to filter both. And I didn't suggest replacing event-fork, but adding trace-fork for both, like a superset option.

Well, trace-cmd will just set both when one adds -c

I'd like to have two options for now. We can always add a superset option for later.

-- Steve

Quoted 6 lines
Quoted 4 lines

trace-cmd will use ptrace if function
fork is needed. Having it separate will let trace-cmd know if it needs to use ptrace or not for function forking.

Yeah, that's a good workaround for older kernel.