Skip to contentSkip to conversation

pinctrl: sh-pfc: r8a7791: fix IPSR comment typos

PATCH In review Sergei Shtylyov 2 participants 2 messages Mar 31, 2017 – Apr 3, 2017

Subsystems (2)
GPIO Pin control
lore
Share & tools
lore

Sergei Shtylyov

author
#0 lore raw

PATCH 1/1 pinctrl: sh-pfc: r8a7791: fix IPSR comment typos

The IPSR field names in the comments have been fat-fingered in a couple places -- fix those silly typos...

Fixes 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support")
Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'fixes' branch of Linus Walleij's 'linux-pinctrl.git' repo plus 3 R8A7791 fixes posted in the last couple days...

 drivers/pinctrl/sh-pfc/pfc-r8a7791.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/sh-pfc/pfc-r8a7791.c +2 -2
Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
===================================================================
@@ -5711,7 +5711,7 @@ static const struct pinmux_cfg_reg pinmu
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR2", 0xE6060028, 32,
 			     2, 3, 2, 2, 2, 2, 3, 3, 3, 3, 2, 2, 3) {
-		/* IP2_31_20 [2] */
+		/* IP2_31_30 [2] */
 		0, 0, 0, 0,
 		/* IP2_29_27 [3] */
 		FN_EX_CS3_N, FN_ATADIR0_N, FN_MSIOF2_TXD,

@@ -6042,7 +6042,7 @@ static const struct pinmux_cfg_reg pinmu
 		/* IP10_24_22 [3] */
 		FN_VI0_R1, FN_VI2_DATA2, FN_GLO_I1_B, FN_TS_SCK0_C, FN_ATAG1_N,
 		0, 0, 0,
-		/* IP10_21_29 [3] */
+		/* IP10_21_19 [3] */
 		FN_VI0_R0, FN_VI2_DATA1, FN_GLO_I0_B,
 		FN_TS_SDATA0_C, FN_ATACS11_N,
 		0, 0, 0,
Reviewed-by on v1 1/1
#1 lore raw

Hi Sergii,

Quoted 2 lines · Sergei Shtylyov

The IPSR field names in the comments have been fat-fingered in a couple places -- fix those silly typos...

Thanks!

Quoted 2 lines
Fixes 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support")
Signed-off-by Sergei Shtylyov <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>
Quoted 12 lines

---
This patch is against the 'fixes' branch of Linus Walleij's 'linux-pinctrl.git' repo plus 3 R8A7791 fixes posted in the last couple days...

 drivers/pinctrl/sh-pfc/pfc-r8a7791.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
===================================================================

drivers/pinctrl/sh-pfc/pfc-r8a7791.c static const struct pinmux_cfg_reg pinmu · line 5717

Quoted 8 lines
drivers/pinctrl/sh-pfc/pfc-r8a7791.c +1 -1
@@ -5711,7 +5711,7 @@ static const struct pinmux_cfg_reg pinmu
        },
        { PINMUX_CFG_REG_VAR("IPSR2", 0xE6060028, 32,
                             2, 3, 2, 2, 2, 2, 3, 3, 3, 3, 2, 2, 3) {
-               /* IP2_31_20 [2] */
+               /* IP2_31_30 [2] */
                0, 0, 0, 0,
                /* IP2_29_27 [3] */
                FN_EX_CS3_N, FN_ATADIR0_N, FN_MSIOF2_TXD,

There's another one a few lines below:

- /* IP2_12_0 [3] */
+ /* IP2_12_10 [3] */

I'll fix that up when applying...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds