Skip to contentSkip to conversation

linux: Add CIP SLTS easy selection option

PATCH Superseded Angelo Compagnucci 2 participants 5 messages Mar 7, 2017 – Apr 6, 2017

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Angelo Compagnucci

author
#0 lore raw

v2 cover linux: Add CIP SLTS easy selection option

This patch adds an easy way to select the CIP project SLTS kernel within the kernel menu.

This series:
* Adds a gitlab helper to download archive files
* Add the option to download the CIP kernel from TAG of from a branch

Angelo Compagnucci (2):
package/pkg-download.mk: add gitlab helper
linux: Add CIP SLTS easy selection option

 linux/Config.in         | 25 +++++++++++++++++++++++++
 linux/linux.mk          |  4 ++++
 package/pkg-download.mk |  3 +++
 3 files changed, 32 insertions(+)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v2 1/2 package/pkg-download.mk: add gitlab helper

Downloaging tarball from gitlab it's not straigthforward cause it uses a strange url format. Adding an helper to simplify things.

Signed-off-by Angelo Compagnucci <[email protected]>
---
 package/pkg-download.mk | 3 +++
 1 file changed, 3 insertions(+)
package/pkg-download.mk +3 -0
index cfc550e..eae30d8 100644
@@ -55,6 +55,9 @@ domainseparator = $(if $(1),$(1),/)
 # github(user,package,version): returns site of GitHub repository
 github = https://github.com/$(1)/$(2)/archive/$(3)
 
+# gitlab(user,package,version): returns site of GitHub repository
+gitlab = "https://gitlab.com/$(1)/$(2)/repository/archive.tar.bz2?ref=$(3)&filename="
+
 # Expressly do not check hashes for those files
 # Exported variables default to immediately expanded in some versions of
 # make, but we need it to be recursively-epxanded, so explicitly assign it.
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH v2 2/2 linux: Add CIP SLTS easy selection option

In reply to Angelo Compagnucci

This patch adds an easy way to select the CIP project SLTS kernel within the kernel menu.

Signed-off-by Angelo Compagnucci <[email protected]>
---
 linux/Config.in | 25 +++++++++++++++++++++++++
 linux/linux.mk  |  4 ++++
 2 files changed, 29 insertions(+)
linux/Config.in +25 -0
index 1707f7d..76acece 100644
@@ -28,6 +28,9 @@ choice
 config BR2_LINUX_KERNEL_LATEST_VERSION
 	bool "Latest version (4.10.1)"
 
+config BR2_LINUX_KERNEL_LATEST_CIP_VERSION
+	bool "Latest CIP SLTS (Super Long Term Support)"
+
 config BR2_LINUX_KERNEL_CUSTOM_VERSION
 	bool "Custom version"
 	help

@@ -95,9 +98,31 @@ config BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION
 
 endif
 
+if BR2_LINUX_KERNEL_LATEST_CIP_VERSION
+
+choice
+	prompt "CIP version"
+	default BR2_LINUX_KERNEL_LATEST_CIP_VERSION_TAG
+
+	config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_TAG
+		bool "Latest tagged version (v4.4.48-cip2)"
+		help
+		  Use the latest tagged version
+
+	config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH
+		bool "Latest released version"
+		help
+		  Always use the latest released version at the time of compiling
+
+endchoice
+
+endif
+
 config BR2_LINUX_KERNEL_VERSION
 	string
 	default "4.10.1" if BR2_LINUX_KERNEL_LATEST_VERSION
+	default "v4.4.48-cip2" if BR2_LINUX_KERNEL_LATEST_CIP_VERSION_TAG
+	default "linux-4.4.y-cip" if BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH
 	default BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE \
 		if BR2_LINUX_KERNEL_CUSTOM_VERSION
 	default "custom" if BR2_LINUX_KERNEL_CUSTOM_TARBALL
linux/linux.mk +4 -0
index 7f4432e..473a198 100644
@@ -30,6 +30,10 @@ LINUX_SITE_METHOD = hg
 else ifeq ($(BR2_LINUX_KERNEL_CUSTOM_SVN),y)
 LINUX_SITE = $(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_REPO_URL))
 LINUX_SITE_METHOD = svn
+else ifeq ($(BR2_LINUX_KERNEL_LATEST_CIP_VERSION),y)
+LINUX_SITE = $(call gitlab,cip-project,cip-kernel-4.4,$(LINUX_VERSION))
+LINUX_SOURCE = linux-$(LINUX_VERSION).tar.bz2
+BR_NO_CHECK_HASH_FOR += $(LINUX_SOURCE)
 else
 LINUX_SOURCE = linux-$(LINUX_VERSION).tar.xz
 ifeq ($(BR2_LINUX_KERNEL_CUSTOM_VERSION),y)
Signature · 1 line
2.7.4
#3 lore raw

PATCH v2 2/2 linux: Add CIP SLTS easy selection option

Hello,

Quoted 5 lines · Angelo Compagnucci

This patch adds an easy way to select the CIP project SLTS kernel within the kernel menu.

Signed-off-by Angelo Compagnucci <[email protected]>

linux/Config.in config BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION · line 115

Quoted 9 lines
linux/Config.in +9 -0
+	config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_TAG
+		bool "Latest tagged version (v4.4.48-cip2)"
+		help
+		  Use the latest tagged version
+
+	config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH
+		bool "Latest released version"
+		help
+		  Always use the latest released version at the time of compiling

I still won't take a patch that adds an option like this. It makes the build non reproducible, which is plain and simply unacceptable in Buildroot. So until you remove this, this patch cannot be accepted.

linux/linux.mk LINUX_SITE_METHOD = hg · line 35

Quoted 3 lines
linux/linux.mk +3 -0
+else ifeq ($(BR2_LINUX_KERNEL_LATEST_CIP_VERSION),y)
+LINUX_SITE = $(call gitlab,cip-project,cip-kernel-4.4,$(LINUX_VERSION))
+LINUX_SOURCE = linux-$(LINUX_VERSION).tar.bz2

According to
https://wiki.linuxfoundation.org/civilinfrastructureplatform/start,
gitlab is only a mirror, and the official Git repository is
https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-cip.git/.

And in fact, according to
https://lists.cip-project.org/pipermail/cip-dev/2017-March/000167.html,
they even say that the gitlab mirror is no longer updated that regularly due to technical issues.

So could you rework your patch using git.kernel.org instead of gitlab (and therefore dropping the gitlab helper), and also dropping the BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH option ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#4 lore raw

PATCH v2 2/2 linux: Add CIP SLTS easy selection option

Dear Thomas Petazzoni,

2017-04-01 18:48 GMT+02:00 Thomas Petazzoni <
[email protected]>:

Quoted 32 lines

Hello,

Quoted 5 lines · Angelo Compagnucci

This patch adds an easy way to select the CIP project SLTS kernel within the kernel menu.

Signed-off-by Angelo Compagnucci <[email protected]>

linux/Config.in config BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION

Quoted 9 lines
linux/Config.in +9 -0
+     config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_TAG
+             bool "Latest tagged version (v4.4.48-cip2)"
+             help
+               Use the latest tagged version
+
+     config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH
+             bool "Latest released version"
+             help
+               Always use the latest released version at the time of

compiling

I still won't take a patch that adds an option like this. It makes the build non reproducible, which is plain and simply unacceptable in Buildroot. So until you remove this, this patch cannot be accepted.

linux/linux.mk LINUX_SITE_METHOD = hg · line 35

Quoted 3 lines
linux/linux.mk +3 -0
+else ifeq ($(BR2_LINUX_KERNEL_LATEST_CIP_VERSION),y)
+LINUX_SITE = $(call gitlab,cip-project,cip-kernel-4.4,$(LINUX_VERSION))
+LINUX_SOURCE = linux-$(LINUX_VERSION).tar.bz2

According to
https://wiki.linuxfoundation.org/civilinfrastructureplatform/start,
gitlab is only a mirror, and the official Git repository is
https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-cip.git/.

Quoted 9 lines

And in fact, according to
https://lists.cip-project.org/pipermail/cip-dev/2017-March/000167.html,
they even say that the gitlab mirror is no longer updated that regularly due to technical issues.

So could you rework your patch using git.kernel.org instead of gitlab (and therefore dropping the gitlab helper), and also dropping the BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH option ?

Done!

Hope this time it will be accepted!

Quoted 3 lines

Thanks,

Thank you so much for the patience!

Quoted 7 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Signature · 4 lines
Profile: http://it.linkedin.com/in/compagnucciangelo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170406/ddc78e4f/attachment.html>