Skip to contentSkip to conversation

powerpc/sequoia: fix NAND partitions not to overlap

PATCH Applied Pavel Machek 4 participants 10 messages Apr 2, 2017 – May 30, 2017

Subsystems (2)
Device tree bindings PowerPC
lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

PATCH 1/1 powerpc/sequoia: fix NAND partitions not to overlap

Fix overlapping NAND partitions.

Signed-off-by Pavel Machek <[email protected]>
arch/powerpc/boot/dts/sequoia.dts +1 -1
index b1d3292..e41b88a 100644
@@ -229,7 +229,7 @@
 						};
 						partition@84000 {
 							label = "user";
-							reg = <0x00000000 0x01f7c000>;
+							reg = <0x00084000 0x01f7c000>;
 						};
 					};
 				};
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#1 lore raw
Quoted 3 lines · Pavel Machek

Fix overlapping NAND partitions.

Signed-off-by Pavel Machek <[email protected]>

Ping? Two partitions at same place are bad news...
Pavel

Quoted 16 lines
arch/powerpc/boot/dts/sequoia.dts +1 -1
index b1d3292..e41b88a 100644
@@ -229,7 +229,7 @@
 						};
 						partition@84000 {
 							label = "user";
-							reg = <0x00000000 0x01f7c000>;
+							reg = <0x00084000 0x01f7c000>;
 						};
 					};
 				};
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw
Quoted 6 lines · On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <[email protected]> wrote:
Quoted 3 lines · Pavel Machek

Fix overlapping NAND partitions.

Signed-off-by Pavel Machek <[email protected]>

Ping? Two partitions at same place are bad news...

Please expand on "bad news"? What are the runtime effects of this change? Decisions about which kernel(s) to patch depend on this info.

author
#3 lore raw
Quoted 11 lines · Andrew Morton
Quoted 6 lines · On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek…
Quoted 3 lines · Pavel Machek

Fix overlapping NAND partitions.

Signed-off-by Pavel Machek <[email protected]>

Ping? Two partitions at same place are bad news...

Please expand on "bad news"? What are the runtime effects of this change? Decisions about which kernel(s) to patch depend on this info.

Well... two partitions at same place. If you use one, you will corrupt information on the other one.

OTOH this moves partition around (so that they don't overlap) so it is probably not stable candidate.

I guess this is not huge issue; people using these boards probably have custom dts changes, anyway...

Best regards,

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
reviewer
#4 lore raw
Quoted 13 lines · Pavel Machek
Quoted 11 lines · Andrew Morton
Quoted 6 lines · On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek…
Quoted 3 lines · Pavel Machek

Fix overlapping NAND partitions.

Signed-off-by Pavel Machek <[email protected]>

Ping? Two partitions at same place are bad news...

Please expand on "bad news"? What are the runtime effects of this change? Decisions about which kernel(s) to patch depend on this info.

Quoted 8 lines

Well... two partitions at same place. If you use one, you will corrupt information on the other one.

OTOH this moves partition around (so that they don't overlap) so it is probably not stable candidate.

I guess this is not huge issue; people using these boards probably have custom dts changes, anyway...

Or no one's even using it anymore.

I can take this via powerpc, I won't mark it for stable etc.

cheers
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#5 lore raw

Hi!

Quoted 6 lines
Quoted 6 lines

Well... two partitions at same place. If you use one, you will corrupt information on the other one.

OTOH this moves partition around (so that they don't overlap) so it is probably not stable candidate.

Quoted 6 lines
Quoted 2 lines

I guess this is not huge issue; people using these boards probably have custom dts changes, anyway...

Or no one's even using it anymore.

I can take this via powerpc, I won't mark it for stable etc.

That sounds good.

Thanks,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
reviewer
#6 lore raw
In reply to Michael Ellerman
Quoted 21 lines · Michael Ellerman
Quoted 19 lines · Pavel Machek
Quoted 11 lines · Andrew Morton
Quoted 6 lines · On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <[email protected]> wrote:
Quoted 3 lines · Pavel Machek

Fix overlapping NAND partitions.

Signed-off-by Pavel Machek <[email protected]>

Ping? Two partitions at same place are bad news...

Please expand on "bad news"? What are the runtime effects of this change? Decisions about which kernel(s) to patch depend on this info.

Well... two partitions at same place. If you use one, you will corrupt information on the other one.

OTOH this moves partition around (so that they don't overlap) so it is probably not stable candidate.

Quoted 6 lines
Quoted 2 lines

I guess this is not huge issue; people using these boards probably have custom dts changes, anyway...

Or no one's even using it anymore.

I can take this via powerpc, I won't mark it for stable etc.

It became:

Author: Pavel Machek <[email protected]>

powerpc/sequoia: Fix NAND partitions not to overlap

Currently the DTS defines two partitions at the same addresses, if you use one, you will corrupt information on the other one. Fix it by shifting the second partition.

Signed-off-by Pavel Machek <[email protected]>
[mpe: Reconstruct change log from email thread]
Signed-off-by Michael Ellerman <[email protected]>

Minor nit, your From: address doesn't match your Signed-off-by: address, which trips my "check patch is signed-off-by author" script. I can just ignore it, but I think it's preferable if they match.

cheers

author
#7 lore raw

Hi!

Quoted 30 lines
Quoted 13 lines
Quoted 13 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Pavel Machek <[email protected]>

Ping? Two partitions at same place are bad news...

Please expand on "bad news"? What are the runtime effects of this change? Decisions about which kernel(s) to patch depend on this info.

Well... two partitions at same place. If you use one, you will corrupt information on the other one.

OTOH this moves partition around (so that they don't overlap) so it is probably not stable candidate.

Quoted 6 lines
Quoted 2 lines

I guess this is not huge issue; people using these boards probably have custom dts changes, anyway...

Or no one's even using it anymore.

I can take this via powerpc, I won't mark it for stable etc.

It became:

Author: Pavel Machek <[email protected]>

powerpc/sequoia: Fix NAND partitions not to overlap

Currently the DTS defines two partitions at the same addresses, if you use one, you will corrupt information on the other one. Fix it by shifting the second partition.

Quoted 8 lines
Signed-off-by Pavel Machek <[email protected]>
[mpe: Reconstruct change log from email thread]
Signed-off-by Michael Ellerman <mpe-Gsx/[email protected]>

Minor nit, your From: address doesn't match your Signed-off-by: address, which trips my "check patch is signed-off-by author" script. I can just ignore it, but I think it's preferable if they match.

Sorry about that (I have automatic scripts changing From:). It is still me, but I guess denx should get the credit here, so you can use.

Signed-off-by Pavel Machek <[email protected]>

Thanks,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
reviewer
#8 lore raw
Quoted 37 lines · Pavel Machek

Hi!

Quoted 35 lines
Quoted 13 lines
Quoted 13 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Pavel Machek <[email protected]>

Ping? Two partitions at same place are bad news...

Please expand on "bad news"? What are the runtime effects of this change? Decisions about which kernel(s) to patch depend on this info.

Well... two partitions at same place. If you use one, you will corrupt information on the other one.

OTOH this moves partition around (so that they don't overlap) so it is probably not stable candidate.

Quoted 6 lines
Quoted 2 lines

I guess this is not huge issue; people using these boards probably have custom dts changes, anyway...

Or no one's even using it anymore.

I can take this via powerpc, I won't mark it for stable etc.

It became:

Author: Pavel Machek <[email protected]>

powerpc/sequoia: Fix NAND partitions not to overlap

Currently the DTS defines two partitions at the same addresses, if you use one, you will corrupt information on the other one. Fix it by shifting the second partition.

Signed-off-by Pavel Machek <[email protected]>
[mpe: Reconstruct change log from email thread]
Signed-off-by Michael Ellerman <mpe-Gsx/[email protected]>
Quoted 8 lines
Quoted 3 lines

Minor nit, your From: address doesn't match your Signed-off-by: address, which trips my "check patch is signed-off-by author" script. I can just ignore it, but I think it's preferable if they match.

Sorry about that (I have automatic scripts changing From:). It is still me, but I guess denx should get the credit here, so you can use.

Signed-off-by Pavel Machek <[email protected]>

Sure, done.

cheers
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html