Skip to contentSkip to conversation

qed: Add a missing error code

PATCH Applied Dan Carpenter 3 participants 3 messages Apr 3, 2017 – Apr 5, 2017

Subsystems (4)
Networking Network drivers Kernel janitors QLogic QL4xxx Ethernet driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 qed: Add a missing error code

We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The current code returns success.

Fixes 4ed1eea82a21 ("qed: Revise MFW command locking")
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/qlogic/qed/qed_mcp.c +3 -1
index 619eac845028..ff6080df2246 100644
@@ -455,8 +455,10 @@ _qed_mcp_cmd_and_union(struct qed_hwfn *p_hwfn,
 	qed_mcp_reread_offsets(p_hwfn, p_ptt);
 	seq_num = ++p_hwfn->mcp_info->drv_mb_seq;
 	p_cmd_elem = qed_mcp_cmd_add_elem(p_hwfn, p_mb_params, seq_num);
-	if (!p_cmd_elem)
+	if (!p_cmd_elem) {
+		rc = -ENOMEM;
 		goto err;
+	}
 
 	__qed_mcp_cmd_and_union(p_hwfn, p_ptt, p_mb_params, seq_num);
 	spin_unlock_bh(&p_hwfn->mcp_info->cmd_lock);