Skip to contentSkip to conversation

i40e: limit client interface to X722 hardware

PATCH In review Stefan Assmann 3 participants 5 messages Apr 4, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e: limit client interface to X722 hardware

The client interface is meant for X722 iWARP support. Modprobing i40iw on systems with X710/XL710 NICs currently may crash the system. Adding a check which limits client interface access to the appropriate hardware.

---
 drivers/net/ethernet/intel/i40e/i40e_client.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_client.c +8 -6
index 191028b..6f873449 100644
@@ -525,15 +525,17 @@ static void i40e_client_release(struct i40e_client *client)
 static void i40e_client_prepare(struct i40e_client *client)
 {
 	struct i40e_device *ldev;
-	struct i40e_pf *pf;
 
 	mutex_lock(&i40e_device_mutex);
 	list_for_each_entry(ldev, &i40e_devices, list) {
-		pf = ldev->pf;
-		i40e_client_add_instance(pf);
-		/* Start the client subtask */
-		pf->flags |= I40E_FLAG_SERVICE_CLIENT_REQUESTED;
-		i40e_service_event_schedule(pf);
+		struct i40e_pf *pf = ldev->pf;
+
+		if (pf->hw.mac.type == I40E_MAC_X722) {
+			i40e_client_add_instance(pf);
+			/* Start the client subtask */
+			pf->flags |= I40E_FLAG_SERVICE_CLIENT_REQUESTED;
+			i40e_service_event_schedule(pf);
+		}
 	}
 	mutex_unlock(&i40e_device_mutex);
 }
Signature · 1 line
2.9.3
#1 lore raw
Quoted 49 lines

-----Original Message-----
From: netdev-owner at vger.kernel.org [mailto:netdev-owner at vger.kernel.org] On Behalf Of Stefan Assmann
Sent: Tuesday, April 04, 2017 7:35 AM
To: intel-wired-lan at lists.osuosl.org
Cc: netdev at vger.kernel.org; davem at davemloft.net; Kirsher, Jeffrey T <[email protected]>; sassmann at kpanic.de
Subject: [PATCH] i40e: limit client interface to X722 hardware

The client interface is meant for X722 iWARP support. Modprobing i40iw on systems with X710/XL710 NICs currently may crash the system. Adding a check which limits client interface access to the appropriate hardware.

---
 drivers/net/ethernet/intel/i40e/i40e_client.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_client.c +8 -6
index 191028b..6f873449 100644
@@ -525,15 +525,17 @@ static void i40e_client_release(struct i40e_client
 *client)
 static void i40e_client_prepare(struct i40e_client *client)
 {
 	struct i40e_device *ldev;
-	struct i40e_pf *pf;
 
 	mutex_lock(&i40e_device_mutex);
 	list_for_each_entry(ldev, &i40e_devices, list) {
-		pf = ldev->pf;
-		i40e_client_add_instance(pf);
-		/* Start the client subtask */
-		pf->flags |= I40E_FLAG_SERVICE_CLIENT_REQUESTED;
-		i40e_service_event_schedule(pf);
+		struct i40e_pf *pf = ldev->pf;
+
+		if (pf->hw.mac.type == I40E_MAC_X722) {
+			i40e_client_add_instance(pf);
+			/* Start the client subtask */
+			pf->flags |= I40E_FLAG_SERVICE_CLIENT_REQUESTED;
+			i40e_service_event_schedule(pf);
+		}
 	}
 	mutex_unlock(&i40e_device_mutex);
Quoted 3 lines

}
--
2.9.3

Thanks for pointing this out, Stephan. I think that's not exactly the right way to do this check. Instead, we need to look at the IWARP flag. I'll get a patch out today to take care of it.

So consider this a thankful NAK.

-Mitch

#2 lore raw
In reply to Stefan Assmann
Quoted 2 lines · Stefan Assmann

The client interface is meant for X722 iWARP support. Modprobing i40iw on systems with X710/XL710 NICs currently may crash the system.

just curious may or crash? and why?

#3 lore raw
Quoted 5 lines · Or Gerlitz
Quoted 2 lines · Stefan Assmann

The client interface is meant for X722 iWARP support. Modprobing i40iw on systems with X710/XL710 NICs currently may crash the system.

just curious may or crash? and why?

The backtrace I got was not really conclusive. The code is not meant to be run on that hardware so I didn't bother to dig deeper.

Stefan

#4 lore raw
Quoted 17 lines

-----Original Message-----
From: netdev-owner at vger.kernel.org [mailto:netdev-owner at vger.kernel.org] On Behalf Of Stefan Assmann
Sent: Tuesday, April 04, 2017 12:52 PM
To: Or Gerlitz <[email protected]>
Cc: intel-wired-lan at lists.osuosl.org; Linux Netdev List <[email protected]>; David Miller <[email protected]>; Kirsher, Jeffrey T <[email protected]>
Subject: Re: [PATCH] i40e: limit client interface to X722 hardware

Quoted 4 lines · Or Gerlitz
Quoted 2 lines · Stefan Assmann

The client interface is meant for X722 iWARP support. Modprobing i40iw on systems with X710/XL710 NICs currently may crash the system.

Quoted 6 lines
Quoted 1 line

just curious may or crash? and why?

The backtrace I got was not really conclusive. The code is not meant to be run on that hardware so I didn't bother to dig deeper.

Stefan

The i40iw module can't easily determine which hardware its loaded upon. So it assumes that we (i40e, that is) have handed it a handle to valid hardware. When the interface is opened, it starts reading and writing registers that are nonexistent on X710/XL710.

-Mitch