Skip to contentSkip to conversation

unisys: visornic: Replace symbolic perms with octal

PATCH In review Thomas Jespersen 2 participants 2 messages Apr 4, 2017 – Apr 5, 2017 Staging

lore
Share & tools
lore

Thomas Jespersen

author
#0 lore raw

PATCH 1/1 unisys: visornic: Replace symbolic perms with octal

Replace symbolic permissions S_IRUSR and S_IWUSR for their octal counterparts

Signed-off-by Thomas Jespersen <[email protected]>
---
 drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/unisys/visornic/visornic_main.c +2 -2
index feece91..1008337 100644
@@ -2146,11 +2146,11 @@ static int visornic_init(void)
 	if (!visornic_debugfs_dir)
 		return err;
 
-	ret = debugfs_create_file("info", S_IRUSR, visornic_debugfs_dir, NULL,
+	ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
 				  &debugfs_info_fops);
 	if (!ret)
 		goto cleanup_debugfs;
-	ret = debugfs_create_file("enable_ints", S_IWUSR, visornic_debugfs_dir,
+	ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir,
 				  NULL, &debugfs_enable_ints_fops);
 	if (!ret)
 		goto cleanup_debugfs;
Signature · 1 line
2.10.2
#1 lore raw
Quoted 12 lines

-----Original Message-----
From: Thomas Jespersen [mailto:[email protected]]
Sent: Tuesday, April 4, 2017 3:15 PM
To: Kershner, David A <[email protected]>
Cc: [email protected]; Sell, Timothy C <[email protected]>; Binder, David Anthony <[email protected]>; Frisch, Jon <[email protected]>; [email protected]; *S-Par-Maintainer <[email protected]>; [email protected]; linux- [email protected]
Subject: [PATCH] unisys: visornic: Replace symbolic perms with octal

Should the subject line say "staging: unisys: visornic" instead of just "unisys: visornic:"?

Besides that, I'm fine with this patch and have tested it on s-Par.

David Kershner

Quoted 31 lines

Replace symbolic permissions S_IRUSR and S_IWUSR for their octal counterparts

Signed-off-by Thomas Jespersen <[email protected]>
---
 drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/unisys/visornic/visornic_main.c +2 -2
index feece91..1008337 100644
@@ -2146,11 +2146,11 @@ static int visornic_init(void)
 	if (!visornic_debugfs_dir)
 		return err;
 
-	ret = debugfs_create_file("info", S_IRUSR, visornic_debugfs_dir,
 NULL,
+	ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
 				  &debugfs_info_fops);
 	if (!ret)
 		goto cleanup_debugfs;
-	ret = debugfs_create_file("enable_ints", S_IWUSR,
 visornic_debugfs_dir,
+	ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir,
 				  NULL, &debugfs_enable_ints_fops);
drivers/staging/unisys/visornic/visornic_main.c +0 -1
 	if (!ret)
 		goto cleanup_debugfs;
--

2.10.2