Skip to contentSkip to conversation

nvme/pci: Don't set reserved SQ create flags

PATCH New Keith Busch 3 participants 3 messages Apr 4, 2017 – Apr 5, 2017 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme/pci: Don't set reserved SQ create flags

The QPRIO field is only valid if weighted round robin arbitration is used, and this driver doesn't enable that controller configuration option.

Signed-off-by Keith Busch <keith.busch at intel.com>
---
 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/pci.c +1 -1
index 26a5fd0..4eb0815 100644
@@ -812,7 +812,7 @@ static int adapter_alloc_sq(struct nvme_dev *dev, u16 qid,
 						struct nvme_queue *nvmeq)
 {
 	struct nvme_command c;
-	int flags = NVME_QUEUE_PHYS_CONTIG | NVME_SQ_PRIO_MEDIUM;
+	int flags = NVME_QUEUE_PHYS_CONTIG;
 
 	/*
 	 * Note: we (ab)use the fact the the prp fields survive if no data
Signature · 1 line
2.5.5
#1 lore raw

PATCH 1/1 nvme/pci: Don't set reserved SQ create flags

Oops..

Looks good:

Reviewed-by Christoph Hellwig <hch at lst.de>