make: run check on current `dim`, not the installed one
PATCH 1/3 make: run check on current `dim`, not the installed one
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
@@ -33,7 +33,7 @@ shellcheck: shellcheck $(SC_EXCLUDE) dim bash_completion mancheck: - @for cmd in $$(dim list-commands); do \ + @for cmd in $$(./dim list-commands); do \ if ! grep -q "^$$cmd" dim.rst; then \ echo "$@: $$cmd not documented"; \ fi \
Signature · 7 lines
Cheers, Eric _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 2/3 dim: send 'not configured' error to stderr
This fixes make check when dim is not configured.
--- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
dim +1 -1
@@ -197,7 +197,7 @@ export __dim_running=1 if [ "$subcommand" != "setup" ] && [ "$subcommand" != "help" ] && [ "$subcommand" != "usage" ]; then for d in $DIM_PREFIX $DIM_PREFIX/$DIM_DRM_INTEL $DIM_PREFIX/drm-rerere $DIM_PREFIX/drm-tip; do if [ ! -d $d ]; then - echo "$d is missing, please check your configuration and/or run dim setup" + echoerr "$d is missing, please check your configuration and/or run dim setup" exit 1 fi done
Signature · 7 lines
Cheers, Eric _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 3/3 dim.rst: update CONTRIBUTING instructions
In reply to Eric EngestromSuggest using git-config instead of a flag on format-patch. While at it, use the more common "PATCH foo" subject prefix.
--- dim.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
dim.rst +3 -2
@@ -476,10 +476,11 @@ CONTRIBUTING ============ Submit patches for any of the maintainer tools to the [email protected] mailing list with [maintainer-tools PATCH] [email protected] mailing list with [PATCH maintainer-tools] prefix. Use:: - $ git format-patch --subject-prefix="maintainer-tools PATCH" + $ git config sendemail.to [email protected] + $ git config format.subjectprefix 'PATCH maintainer-tools' for that. Please make sure your patches pass the build and self tests by running::
Signature · 7 lines
Cheers, Eric _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH maintainer-tools 3/3] dim.rst: update CONTRIBUTING instructions
Quoted 2 lines · Eric Engestrom
Suggest using git-config instead of a flag on format-patch. While at it, use the more common "PATCH foo" subject prefix.
More common? That's all so subjective.
And I've mostly used [dim PATCH]...
BR,
Jani.
Quoted 24 lines
Signed-off-by Eric Engestrom <[email protected]>--- dim.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)dim.rst +3
-2@@ -476,10 +476,11 @@ CONTRIBUTING ============ Submit patches for any of the maintainer tools to the [email protected] mailing list with [maintainer-tools PATCH] [email protected] mailing list with [PATCH maintainer-tools] prefix. Use:: - $ git format-patch --subject-prefix="maintainer-tools PATCH" + $ git config sendemail.to [email protected] + $ git config format.subjectprefix 'PATCH maintainer-tools' for that. Please make sure your patches pass the build and self tests by running::
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH maintainer-tools 3/3] dim.rst: update CONTRIBUTING instructions
In reply to Eric EngestromQuoted 13 lines · Eric Engestrom
Suggest using git-config instead of a flag on format-patch. While at it, use the more common "PATCH foo" subject prefix.
Signed-off-by Eric Engestrom <[email protected]>--- dim.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)dim.rst +0
-0
dim.rst CONTRIBUTING · line 483
Quoted 10 lines
dim.rst +3
-2@@ -476,10 +476,11 @@ CONTRIBUTING ============ Submit patches for any of the maintainer tools to the [email protected] mailing list with [maintainer-tools PATCH] [email protected] mailing list with [PATCH maintainer-tools] prefix. Use:: - $ git format-patch --subject-prefix="maintainer-tools PATCH" + $ git config sendemail.to [email protected] + $ git config format.subjectprefix 'PATCH maintainer-tools'
With dim this is a worktree checkout, which means all kernel patches end up looking like this. Can we make this branch-specific? -Daniel
Quoted 7 lines
dim.rst +0
-1for that. Please make sure your patches pass the build and self tests by running:: --Cheers,
Eric
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 1 line · Eric Engestrom
Signed-off-by Eric Engestrom <[email protected]>
For me "current dim" *is* the "installed one". ;)
Pushed patches 1-2.
BR,
Jani.
Quoted 17 lines
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Makefile +1
-1@@ -33,7 +33,7 @@ shellcheck: shellcheck $(SC_EXCLUDE) dim bash_completion mancheck: - @for cmd in $$(dim list-commands); do \ + @for cmd in $$(./dim list-commands); do \ if ! grep -q "^$$cmd" dim.rst; then \ echo "$@: $$cmd not documented"; \ fi \
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx