Skip to contentSkip to conversation

qga-win: Fix Event Viewer errors caused by qemu-ga

PATCH Applied Sameeh Jubran 2 participants 2 messages Apr 5, 2017 – Apr 13, 2017

lore
Share & tools
lore

Sameeh Jubran

author
#0 lore raw

PATCH v2 1/1 qga-win: Fix Event Viewer errors caused by qemu-ga

When the command "guest-fsfreeze-freeze" is executed it causes the VSS service to log the error below in the Event Viewer. This error is caused by an issue in the function "CommitSnapshots" in provider.cpp:

* When VSS_TIMEOUT_MSEC expires the funtion returns E_ABORT. This causes the error #12293.

|event id|                           error                               |
* 12293  : Volume Shadow Copy Service error: Error calling a routine on a
           Shadow Copy Provider {00000000-0000-0000-0000-000000000000}.
           Routine details CommitSnapshots [hr = 0x80004004, Operation
           aborted.
Signed-off-by Sameeh Jubran <[email protected]>
---
 qga/vss-win32/provider.cpp | 1 -
 1 file changed, 1 deletion(-)
qga/vss-win32/provider.cpp +0 -1
index ef94669..72d8b0e 100644
@@ -377,7 +377,6 @@ STDMETHODIMP CQGAVssProvider::CommitSnapshots(VSS_ID SnapshotSetId)
     if (WaitForSingleObject(hEventThaw, VSS_TIMEOUT_MSEC) != WAIT_OBJECT_0) {
         /* Send event to qemu-ga to notify the provider is timed out */
         SetEvent(hEventTimeout);
-        hr = E_ABORT;
     }
 
     CloseHandle(hEventThaw);
Signature · 1 line
2.9.3
Applied
#1 lore raw

Quoting Sameeh Jubran (2017-04-05 07:01:06)

Quoted 8 lines

When the command "guest-fsfreeze-freeze" is executed it causes the VSS service to log the error below in the Event Viewer. This error is caused by an issue in the function "CommitSnapshots" in provider.cpp:

* When VSS_TIMEOUT_MSEC expires the funtion returns E_ABORT. This causes the error #12293.

Quoted 7 lines
|event id|                           error                               |
* 12293  : Volume Shadow Copy Service error: Error calling a routine on a
           Shadow Copy Provider {00000000-0000-0000-0000-000000000000}.
           Routine details CommitSnapshots [hr = 0x80004004, Operation
           aborted.
Signed-off-by Sameeh Jubran <[email protected]>

Thanks, applied to qga tree:

https://github.com/mdroth/qemu/commits/qga

Quoted 19 lines
---
 qga/vss-win32/provider.cpp | 1 -
 1 file changed, 1 deletion(-)
qga/vss-win32/provider.cpp +0 -1
index ef94669..72d8b0e 100644
@@ -377,7 +377,6 @@ STDMETHODIMP CQGAVssProvider::CommitSnapshots(VSS_ID SnapshotSetId)
     if (WaitForSingleObject(hEventThaw, VSS_TIMEOUT_MSEC) != WAIT_OBJECT_0) {
         /* Send event to qemu-ga to notify the provider is timed out */
         SetEvent(hEventTimeout);
-        hr = E_ABORT;
     }
 
     CloseHandle(hEventThaw);
Signature · 1 line
2.9.3