Skip to contentSkip to conversation

arm: dts: renesas: Drop _clk suffix from clock node names

PATCH New Geert Uytterhoeven 4 participants 7 messages Apr 3, 2017 – Apr 5, 2017

Subsystems (3)
Device tree bindings Common clk Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Geert Uytterhoeven

author maintainer
#0 lore raw

cover arm: dts: renesas: Drop _clk suffix from clock node names

Hi Simon, Magnus,

The current practice is to not add _clk suffixes to clock node names in DT, as these names are used as the actual clock names.

This patch removes the remaining offenders in the various Renesas DTSes.

Thanks!

Geert Uytterhoeven (3):
ARM: dts: r8a7790: Drop _clk suffix from external CAN clock node name
ARM: dts: r8a7791: Drop _clk suffix from external CAN clock node name
arm64: dts: r8a7795: salvator-x: Drop _clk suffix from X12 clock node
name

 arch/arm/boot/dts/r8a7790.dtsi                     | 2 +-
 arch/arm/boot/dts/r8a7791.dtsi                     | 2 +-
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Signature · 12 lines
2.7.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
author maintainer
#1 lore raw

PATCH 1/3 ARM: dts: r8a7790: Drop _clk suffix from external CAN clock node name

The current practice is to not add _clk suffixes to clock node names in DT, as these names are used as the actual clock names.

Signed-off-by Geert Uytterhoeven <[email protected]>
---
 arch/arm/boot/dts/r8a7790.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7790.dtsi +1 -1
index fe6b8c2a2d711536..99269aaca6fc953e 100644
@@ -1101,7 +1101,7 @@
 		};
 
 		/* External CAN clock */
-		can_clk: can_clk {
+		can_clk: can {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
 			/* This value must be overridden by the board. */
Signature · 1 line
2.7.4
author maintainer
#2 lore raw

PATCH 2/3 ARM: dts: r8a7791: Drop _clk suffix from external CAN clock node name

In reply to Geert Uytterhoeven

The current practice is to not add _clk suffixes to clock node names in DT, as these names are used as the actual clock names.

Signed-off-by Geert Uytterhoeven <[email protected]>
---
 arch/arm/boot/dts/r8a7791.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7791.dtsi +1 -1
index a6478ca3f4ca7554..4d0c2ce59900f811 100644
@@ -1126,7 +1126,7 @@
 		};
 
 		/* External CAN clock */
-		can_clk: can_clk {
+		can_clk: can {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
 			/* This value must be overridden by the board. */
Signature · 1 line
2.7.4
author maintainer
#3 lore raw

PATCH 3/3 arm64: dts: r8a7795: salvator-x: Drop _clk suffix from X12 clock node name

In reply to Geert Uytterhoeven

The current practice is to not add _clk suffixes to clock node names in DT, as these names are used as the actual clock names.

Signed-off-by Geert Uytterhoeven <[email protected]>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts +1 -1
index f25241921067dcef..639aa085d9966676 100644
@@ -56,7 +56,7 @@
 		reg = <0x0 0x48000000 0x0 0x38000000>;
 	};
 
-	x12_clk: x12_clk {
+	x12_clk: x12 {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
 		clock-frequency = <24576000>;
Signature · 1 line
2.7.4
#4 lore raw

cover arm: dts: renesas: Drop _clk suffix from clock node names

In reply to Geert Uytterhoeven
Quoted 7 lines · Geert Uytterhoeven

Hi Simon, Magnus,

The current practice is to not add _clk suffixes to clock node names in DT, as these names are used as the actual clock names.

This patch removes the remaining offenders in the various Renesas DTSes.

This changes the names in the clk framework too though? If you're ok with that I'm ok too.

Acked-by Stephen Boyd <[email protected]>
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
#5 lore raw

cover arm: dts: renesas: Drop _clk suffix from clock node names

Hi Stephen,

Quoted 8 lines · Stephen Boyd
Quoted 4 lines · Geert Uytterhoeven

The current practice is to not add _clk suffixes to clock node names in DT, as these names are used as the actual clock names.

This patch removes the remaining offenders in the various Renesas DTSes.

This changes the names in the clk framework too though? If you're ok with that I'm ok too.

Yes, that's my main motivation doing this: it's a bit silly to have some clocks show up in /sys/kernel/debug/clk/clk_summary with a "_clk" suffix.

Quoted 1 line
Acked-by Stephen Boyd <[email protected]>

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#6 lore raw

cover arm: dts: renesas: Drop _clk suffix from clock node names

Quoted 12 lines · Geert Uytterhoeven

Hi Stephen,

Quoted 8 lines · Stephen Boyd
Quoted 4 lines · Geert Uytterhoeven

The current practice is to not add _clk suffixes to clock node names in DT, as these names are used as the actual clock names.

This patch removes the remaining offenders in the various Renesas DTSes.

This changes the names in the clk framework too though? If you're ok with that I'm ok too.

Quoted 6 lines

Yes, that's my main motivation doing this: it's a bit silly to have some clocks show up in /sys/kernel/debug/clk/clk_summary with a "_clk" suffix.

Quoted 1 line
Acked-by Stephen Boyd <[email protected]>

Thanks!

Thanks, I have queued these up.