Skip to contentSkip to conversation

net: ethernet: wiznet: avoid format string exposure

PATCH Applied Kees Cook 2 participants 2 messages Apr 5, 2017 – Apr 6, 2017

Subsystems (3)
Networking Network drivers Wiznet W5100 Ethernet driver
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 net: ethernet: wiznet: avoid format string exposure

While unlikely, this makes sure any format strings in the device name can't exposure information via the resulting workqueue name.

Signed-off-by Kees Cook <[email protected]>
---
 drivers/net/ethernet/wiznet/w5100.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/wiznet/w5100.c +2 -1
index f90267f0519f..2bdfb39215e9 100644
@@ -1152,7 +1152,8 @@ int w5100_probe(struct device *dev, const struct w5100_ops *ops,
 	if (err < 0)
 		goto err_register;
 
-	priv->xfer_wq = alloc_workqueue(netdev_name(ndev), WQ_MEM_RECLAIM, 0);
+	priv->xfer_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0,
+					netdev_name(ndev));
 	if (!priv->xfer_wq) {
 		err = -ENOMEM;
 		goto err_wq;
Signature · 6 lines
2.7.4


-- 
Kees Cook
Pixel Security