Skip to contentSkip to conversation

i40e/i40evf: Remove VF Rx csum offload for tunneled packets.

PATCH New Alice Michael 2 participants 2 messages Apr 6, 2017 – Apr 10, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e/i40evf: Remove VF Rx csum offload for tunneled packets.

Rx checksum offload for tunneled packets was never being negotiated or requested by VF. This capability was assumed by default and enabled in current hardware for VF. Going forward, this feature needs to be disabled or advanced ptypes should be negotiated with PF in the future.

Change-ID I9e54cfa8a90e03ab6956db4412f1e337ccd2c2e0
---
 drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/net/ethernet/intel/i40evf/i40e_txrx.c +0 -7
index 163b42b..b3fb0d08 100644
@@ -835,13 +835,6 @@ static inline void i40e_rx_checksum(struct i40e_vsi *vsi,
 	if (rx_error & BIT(I40E_RX_DESC_ERROR_PPRS_SHIFT))
 		return;
 
-	/* If there is an outer header present that might contain a checksum
-	 * we need to bump the checksum level by 1 to reflect the fact that
-	 * we are indicating we validated the inner checksum.
-	 */
-	if (decoded.tunnel_type >= I40E_RX_PTYPE_TUNNEL_IP_GRENAT)
-		skb->csum_level = 1;
-
 	/* Only report checksum unnecessary for TCP, UDP, or SCTP */
 	switch (decoded.inner_prot) {
 	case I40E_RX_PTYPE_INNER_PROT_TCP:
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 i40e/i40evf: Remove VF Rx csum offload for tunneled packets.

Quoted 14 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Alice Michael
Sent: Thursday, April 6, 2017 3:00 AM
To: Michael, Alice <[email protected]>; intel-wired-
lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next S68 01/01] i40e/i40evf: Remove VF Rx csum offload for tunneled packets.

Rx checksum offload for tunneled packets was never being negotiated or requested by VF. This capability was assumed by default and enabled in current hardware for VF. Going forward, this feature needs to be disabled or advanced ptypes should be negotiated with PF in the future.

Quoted 5 lines
Change-ID I9e54cfa8a90e03ab6956db4412f1e337ccd2c2e0
---
 drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 7 -------
 1 file changed, 7 deletions(-)