Skip to contentSkip to conversation

ti_armv7_common: env: Use args_mmc in FIT loading path

PATCH In review Andrew F. Davis 3 participants 3 messages Mar 10, 2017 – Apr 9, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ti_armv7_common: env: Use args_mmc in FIT loading path

The env command 'args_fit' does not define a root path, this forces us to embed the rootfs into the FIT image. FIT images do not need to contain a rootfs, when they do not the kernel will fall-back to the kernel argument 'root', if this is not defined the kernel will not boot. It is safe to add this as when we do have the rootfs in FIT this argument is ignored. As 'loadfit' is only called from the MMC boot path, use 'args_mmc' to correctly populate 'bootargs'.

---
 include/configs/ti_armv7_common.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/configs/ti_armv7_common.h +1 -2
index d7ad13570e..c7c83afa4e 100644
@@ -117,8 +117,7 @@
 	"fit_loadaddr=0x88000000\0" \
 	"fit_bootfile=fitImage\0" \
 	"update_to_fit=setenv loadaddr ${fit_loadaddr}; setenv bootfile ${fit_bootfile}\0" \
-	"args_fit=setenv bootargs console=${console} \0" \
-	"loadfit=run args_fit; bootm ${loadaddr}#${fdtfile};\0" \
+	"loadfit=run args_mmc; bootm ${loadaddr}#${fdtfile};\0" \
 
 /*
  * DDR information.  If the CONFIG_NR_DRAM_BANKS is not defined,
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 ti_armv7_common: env: Use args_mmc in FIT loading path

Quoted 9 lines · Andrew F. Davis

The env command 'args_fit' does not define a root path, this forces us to embed the rootfs into the FIT image. FIT images do not need to contain a rootfs, when they do not the kernel will fall-back to the kernel argument 'root', if this is not defined the kernel will not boot. It is safe to add this as when we do have the rootfs in FIT this argument is ignored. As 'loadfit' is only called from the MMC boot path, use 'args_mmc' to correctly populate 'bootargs'.

Thanks and regards,
Lokesh

#2 lore raw
In reply to Andrew F. Davis
Quoted 10 lines · Andrew F. Davis

The env command 'args_fit' does not define a root path, this forces us to embed the rootfs into the FIT image. FIT images do not need to contain a rootfs, when they do not the kernel will fall-back to the kernel argument 'root', if this is not defined the kernel will not boot. It is safe to add this as when we do have the rootfs in FIT this argument is ignored. As 'loadfit' is only called from the MMC boot path, use 'args_mmc' to correctly populate 'bootargs'.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170408/9c4bb2d1/attachment.sig>