package/libpng: bump version to 1.6.29
PATCH 1/1 package/libpng: bump version to 1.6.29
Added support for Intel SSE2 and PowerPC VSX optimisations.
Changelog:
https://sourceforge.net/p/libpng/code/ci/b363e01e6b5e865e536db62ca4480f3a2d4690bd/#diff-2
--- ...002-Don-t-append-prefix-to-symbol-names-in-version-script.patch | 5 ++++- package/libpng/libpng.hash | 6 +++--- package/libpng/libpng.mk | 7 +++++-- 3 files changed, 12 insertions(+), 6 deletions(-)
package/libpng/0002-Don-t-append-prefix-to-symbol-names-in-version-script.patch +4 -1
@@ -15,6 +15,9 @@ Signed-off-by: Gustavo Zacarias <[email protected]> [Julien: update for 1.6.25] Signed-off-by: Julien Boibessot <[email protected]> +[Bernd: update for 1.6.29] +Signed-off-by: Bernd Kuhls <[email protected]> + Signed-off-by: Gustavo Zacarias <[email protected]> --- Makefile.am | 2 +-
@@ -44,7 +47,7 @@ index 4e67782..5f468d9 100644 -DPNGLIB_VERSION='@PNGLIB_VERSION@' \ - -DSYMBOL_PREFIX='$(SYMBOL_PREFIX)' -DPNG_NO_USE_READ_MACROS \ + -DSYMBOL_PREFIX='' -DPNG_NO_USE_READ_MACROS \ - -DPNG_BUILDING_SYMBOL_TABLE $(am__append_7) + -DPNG_BUILDING_SYMBOL_TABLE $(am__append_9) # EXT_LIST is a list of the possibly library directory extensions, this exists --
package/libpng/libpng.hash +3 -3
@@ -1,4 +1,4 @@ -# From http://sourceforge.net/projects/libpng/files/libpng16/1.6.28/ -sha1 ff4dceadb15e2c929ad26283118d56f66f4a6cff libpng-1.6.28.tar.xz +# From http://sourceforge.net/projects/libpng/files/libpng16/1.6.29/ +sha1 7dbe6a5088b938545fc0857c507d4e0cf5d9023e libpng-1.6.29.tar.xz # Locally computed: -sha256 d8d3ec9de6b5db740fefac702c37ffcf96ae46cb17c18c1544635a3852f78f7a libpng-1.6.28.tar.xz +sha256 4245b684e8fe829ebb76186327bb37ce5a639938b219882b53d64bd3cfc5f239 libpng-1.6.29.tar.xz
package/libpng/libpng.mk +5 -2
@@ -4,7 +4,7 @@ # ################################################################################ -LIBPNG_VERSION = 1.6.28 +LIBPNG_VERSION = 1.6.29 LIBPNG_SERIES = 16 LIBPNG_SOURCE = libpng-$(LIBPNG_VERSION).tar.xz LIBPNG_SITE = http://downloads.sourceforge.net/project/libpng/libpng${LIBPNG_SERIES}/$(LIBPNG_VERSION)
@@ -14,7 +14,10 @@ LIBPNG_INSTALL_STAGING = YES LIBPNG_DEPENDENCIES = host-pkgconf zlib HOST_LIBPNG_DEPENDENCIES = host-pkgconf host-zlib LIBPNG_CONFIG_SCRIPTS = libpng$(LIBPNG_SERIES)-config libpng-config -LIBPNG_CONF_OPTS = $(if $(BR2_ARM_CPU_HAS_NEON),--enable-arm-neon=yes,--enable-arm-neon=no) +LIBPNG_CONF_OPTS = \ + $(if $(BR2_ARM_CPU_HAS_NEON),--enable-arm-neon=yes,--enable-arm-neon=no) \ + $(if $(BR2_POWERPC_CPU_HAS_ALTIVEC),--enable-powerpc-vsx=api,--enable-powerpc-vsx=no) \ + $(if $(BR2_X86_CPU_HAS_SSE2),--enable-intel-sse=yes,--enable-intel-sse=no) $(eval $(autotools-package)) $(eval $(host-autotools-package))
Signature · 1 line
2.11.0
PATCH 1/1 package/libpng: bump version to 1.6.29
Hello,
package/libpng/libpng.mk LIBPNG_INSTALL_STAGING = YES · line 19
Quoted 2 lines · Bernd Kuhls
package/libpng/libpng.mk +2
-0+ $(if $(BR2_ARM_CPU_HAS_NEON),--enable-arm-neon=yes,--enable-arm-neon=no) \ + $(if $(BR2_POWERPC_CPU_HAS_ALTIVEC),--enable-powerpc-vsx=api,--enable-powerpc-vsx=no) \
Is "api" really the value that we want? configure.ac says:
[case "$enableval" in
no|off)
# disable the default enabling on __ppc64__ systems:
AC_DEFINE([PNG_POWERPC_VSX_OPT], [0],
[Disable POWERPC VSX optimizations])
# Prevent inclusion of the platform specific files below:
enable_powerpc_vsx=no;;
check)
AC_DEFINE([PNG_POWERPC_VSX_CHECK_SUPPORTED], [],
[Check for POWERPC VSX support at run-time])
AC_MSG_WARN([--enable-powerpc-vsx Please check contrib/powerpc/README file]
[for the list of supported OSes.]);;
api)
AC_DEFINE([PNG_POWERPC_VSX_API_SUPPORTED], [],
[Turn on POWERPC VSX optimizations at run-time]);;
yes|on)
AC_DEFINE([PNG_POWERPC_VSX_OPT], [2],
[Enable POWERPC VSX optimizations])
AC_MSG_WARN([--enable-powerpc-vsx: please specify 'check' or 'api', if]
[you want the optimizations unconditionally pass '-maltivec -mvsx']
[or '-mcpu=power8'to the compiler.]);;So in the context of Buildroot, a value of "yes" would be more logical, of course if the PPC processor has VSX instructions. Should we have another BR2_<foo> Config.in option for VSX ?
It would be nice to use --enable-<foo> / --disable-<foo> instead of --enable-foo=yes / --enable-foo=no. I know there's an existing instance of that of libpng.mk, but it would be good to clean it up in a preparation patch.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 package/libpng: bump version to 1.6.29
Hi Thomas,
Am Sun, 09 Apr 2017 15:54:42 +0200 schrieb Thomas Petazzoni:
Quoted 3 lines
So in the context of Buildroot, a value of "yes" would be more logical, of course if the PPC processor has VSX instructions. Should we have another BR2_<foo> Config.in option for VSX ?
Maybe, but sorry, I do not know enough about the ppc arch to provide patches for it so I removed the option in v2:
http://patchwork.ozlabs.org/patch/753019/
While compiling ppc toolchains I got errors like these discussed in 2016:
http://lists.busybox.net/pipermail/buildroot/2016-July/167298.html
Quoted 4 lines
It would be nice to use --enable-<foo> / --disable-<foo> instead of --enable-foo=yes / --enable-foo=no. I know there's an existing instance of that of libpng.mk, but it would be good to clean it up in a preparation patch.
Done: http://patchwork.ozlabs.org/patch/753018/
Regards, Bernd