bindings: net: stmmac: add missing note about LPI interrupt
Subsystems (4)
PATCH v2 1/1 bindings: net: stmmac: add missing note about LPI interrupt
From: Niklas Cassel <[email protected]>
The hardware has a LPI interrupt.
There is already code in the stmmac driver to parse and handle the interrupt. However, this information was missing from the DT binding.
--- Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/net/stmmac.txt +4 -4
@@ -8,8 +8,8 @@ Required properties: that services interrupts for this device - interrupts: Should contain the STMMAC interrupts - interrupt-names: Should contain the interrupt names "macirq" - "eth_wake_irq" if this interrupt is supported in the "interrupts" - property + "eth_wake_irq" if this interrupt is supported in the "interrupts" property + "eth_lpi" if this interrupt is supported in the "interrupts" property - phy-mode: See ethernet.txt file in the same directory. - snps,reset-gpio gpio number for phy reset. - snps,reset-active-low boolean flag to indicate if phy reset is active low.
@@ -152,8 +152,8 @@ Examples: compatible = "st,spear600-gmac"; reg = <0xe0800000 0x8000>; interrupt-parent = <&vic1>; - interrupts = <24 23>; - interrupt-names = "macirq", "eth_wake_irq"; + interrupts = <24 23 22>; + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; mac-address = [000000000000]; /* Filled in by U-Boot */ max-frame-size = <3800>; phy-mode = "gmii";
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Niklas
Quoted 5 lines · Niklas Cassel
From: Niklas Cassel <[email protected]>
The hardware has a LPI interrupt.
There is already code in the stmmac driver to parse and handle the interrupt. However, this information was missing from the DT binding.
i wonder if we could improve the comments in this patch too
Quoted 10 lines
Signed-off-by Niklas Cassel <[email protected]>--- Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)Documentation/devicetree/bindings/net/stmmac.txt +0
-0
Documentation/devicetree/bindings/net/stmmac.txt Required properties: · line 11
Quoted 6 lines
Documentation/devicetree/bindings/net/stmmac.txt +1
-2@@ -8,8 +8,8 @@ Required properties: that services interrupts for this device - interrupts: Should contain the STMMAC interrupts - interrupt-names: Should contain the interrupt names "macirq" - "eth_wake_irq" if this interrupt is supported in the "interrupts" - property + "eth_wake_irq" if this interrupt is supported in the "interrupts" property
this is the PMT interrupt to manage the remote wake-up packet detection
Documentation/devicetree/bindings/net/stmmac.txt Required properties: · line 12
Quoted 1 line
Documentation/devicetree/bindings/net/stmmac.txt +1
-0+ "eth_lpi" if this interrupt is supported in the "interrupts" property
This is the interrupt that occurs when Tx or Rx enter/exit from LPI state
Regards
Peppe
Quoted 14 lines
Documentation/devicetree/bindings/net/stmmac.txt +2
-2- phy-mode: See ethernet.txt file in the same directory. - snps,reset-gpio gpio number for phy reset. - snps,reset-active-low boolean flag to indicate if phy reset is active low.@@ -152,8 +152,8 @@ Examples: compatible = "st,spear600-gmac"; reg = <0xe0800000 0x8000>; interrupt-parent = <&vic1>; - interrupts = <24 23>; - interrupt-names = "macirq", "eth_wake_irq"; + interrupts = <24 23 22>; + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; mac-address = [000000000000]; /* Filled in by U-Boot */ max-frame-size = <3800>; phy-mode = "gmii";