cpupower: Fix turbo frequency reporting for pre-Sandy Bridge cores
PATCH 1/1 cpupower: Fix turbo frequency reporting for pre-Sandy Bridge cores
The switch that conditionally sets CPUPOWER_CAP_HAS_TURBO_RATIO and CPUPOWER_CAP_IS_SNB flags is missing a break, so all cores get both flags set and an assumed base clock of 100 MHz for turbo values.
References: https://bugs.debian.org/859978
--- tools/power/cpupower/utils/helpers/cpuid.c | 1 + 1 file changed, 1 insertion(+)
tools/power/cpupower/utils/helpers/cpuid.c +1 -0
@@ -156,6 +156,7 @@ int get_cpu_info(unsigned int cpu, struct cpupower_cpu_info *cpu_info)*/ case 0x2C :/* Westmere EP - Gulftown */ cpu_info->caps |=CPUPOWER_CAP_HAS_TURBO_RATIO ; +break ;case 0x2A :/* SNB */ case 0x2D :/* SNB Xeon */ case 0x3A :/* IVB */
Hi Ben,
good catch, thanks!
Could you resubmit adding my Signed-off-by, please. Rafael could directly pick it up then?
Quoted 2 lines
Reported-by GSR <[email protected]>Tested-by GSR <[email protected]>
These seem not to make much sense, at least not in the kernel changelog?
Quoted 5 lines · Thomas Renninger
Hi Ben,
good catch, thanks!
Could you resubmit adding my Signed-off-by, please. Rafael could directly pick it up then?
That doesn't make sense. You should add a Signed-off-by if *you* send it on. Otherwise Rafael or I can add an Acked-by.
Quoted 5 lines
Quoted 2 lines
Reported-by GSR <[email protected]>Tested-by GSR <[email protected]>These seem not to make much sense, at least not in the kernel changelog?
I don't see why not.
Ben.
Signature · 2 lines
Ben Hutchings 73.46% of all statistics are made up.