4.9.22-stable review
Subsystems (2)
Greg Kroah-Hartman
maintainerPATCH 152/152 x86/reboot/quirks: Fix typo in ASUS EeeBook X205TA reboot quirk
In reply to Greg Kroah-Hartman4.9-stable review patch. If anyone has any objections, please let me know.
------------------
From: Matjaz Hegedic <[email protected]>
[ Upstream commit bba8376aea1dcbbe22bbda118c52abee317c7609 ]
The reboot quirk for ASUS EeeBook X205TA contains a typo in DMI_PRODUCT_NAME, improperly referring to X205TAW instead of X205TA, which prevents the quirk from being triggered. The model X205TAW already has a reboot quirk of its own.
This fix simply removes the inappropriate final letter W.
--- arch/x86/kernel/reboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/reboot.c +1 -1
@@ -228,7 +228,7 @@ static struct dmi_system_id __initdata r .ident = "ASUS EeeBook X205TA", .matches = {DMI_MATCH (DMI_SYS_VENDOR ,"ASUSTeK COMPUTER INC." ), - DMI_MATCH(DMI_PRODUCT_NAME, "X205TAW"), + DMI_MATCH(DMI_PRODUCT_NAME, "X205TA"), }, }, { /* Handle problems with rebooting on ASUS EeeBook X205TAW */
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.22 release. There are 152 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Apr 12 16:41:34 UTC 2017. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.22-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.9.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.22 release. There are 152 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Apr 12 16:41:34 UTC 2017. Anything received after that time might be too late.
Early feedback:
Building arm64:allmodconfig ... failed
--------------
Error log:arch/arm64/Makefile:23: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratumarch/arm64/Makefile:36: LSE atomics not supported by binutils/opt/buildbot/slave/stable-queue-4.9/build/arch/arm64/kernel/pci.c: In function ‘pci_acpi_setup_ecam_mapping’:/opt/buildbot/slave/stable-queue-4.9/build/arch/arm64/kernel/pci.c:139:9: error: implicit declaration of function ‘acpi_resource_consumer’ [-Werror=implicit-function-declaration]
adev = acpi_resource_consumer(&cfgres);
^
/opt/buildbot/slave/stable-queue-4.9/build/arch/arm64/kernel/pci.c:139:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
adev = acpi_resource_consumer(&cfgres);
^cc1: some warnings being treated as errors
make[2]: *** [arch/arm64/kernel/pci.o] Error 1
make[1]: *** [arch/arm64/kernel] Error 2
make[1]: *** Waiting for unfinished jobs..../opt/buildbot/slave/stable-queue-4.9/build/drivers/pci/host/pcie-hisi.c: In function ‘hisi_pcie_init’:/opt/buildbot/slave/stable-queue-4.9/build/drivers/pci/host/pcie-hisi.c:94:8: error: implicit declaration of function ‘acpi_get_rc_resources’ [-Werror=implicit-function-declaration]
ret = acpi_get_rc_resources(dev, "HISI0081", root->segment, res);
^cc1: some warnings being treated as errors make[4]: *** [drivers/pci/host/pcie-hisi.o] Error 1
Culprits:
166fba287313 PCI: Add MCFG quirks for Cavium ThunderX pass2.x host controller 575fdb4e21ec arm64: PCI: Search ACPI namespace to ensure ECAM space is reserved 6fe2dc79c28d PCI: Add MCFG quirks for HiSilicon Hip05/06/07 host controllers
You will also need
00710984eac5 ACPI: Add acpi_resource_consumer() to find device that claims a resource 169de969c018 PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform
to fix the errors.
Guenter
Greg Kroah-Hartman
maintainerQuoted 42 lines · Guenter Roeck
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.22 release. There are 152 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Apr 12 16:41:34 UTC 2017. Anything received after that time might be too late.
Early feedback:
Building arm64:allmodconfig ... failed
--------------
Error log:arch/arm64/Makefile:23: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratumarch/arm64/Makefile:36: LSE atomics not supported by binutils/opt/buildbot/slave/stable-queue-4.9/build/arch/arm64/kernel/pci.c: In function ‘pci_acpi_setup_ecam_mapping’:/opt/buildbot/slave/stable-queue-4.9/build/arch/arm64/kernel/pci.c:139:9: error: implicit declaration of function ‘acpi_resource_consumer’ [-Werror=implicit-function-declaration]adev = acpi_resource_consumer(&cfgres); ^ /opt/buildbot/slave/stable-queue-4.9/build/arch/arm64/kernel/pci.c:139:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion] adev = acpi_resource_consumer(&cfgres); ^cc1: some warnings being treated as errors
make[2]: *** [arch/arm64/kernel/pci.o] Error 1
make[1]: *** [arch/arm64/kernel] Error 2
make[1]: *** Waiting for unfinished jobs..../opt/buildbot/slave/stable-queue-4.9/build/drivers/pci/host/pcie-hisi.c: In function ‘hisi_pcie_init’:/opt/buildbot/slave/stable-queue-4.9/build/drivers/pci/host/pcie-hisi.c:94:8: error: implicit declaration of function ‘acpi_get_rc_resources’ [-Werror=implicit-function-declaration]ret = acpi_get_rc_resources(dev, "HISI0081", root->segment, res); ^cc1: some warnings being treated as errors make[4]: *** [
drivers/pci/host/pcie-hisi.o] Error 1Culprits:
166fba287313PCI: Add MCFG quirks for Cavium ThunderX pass2.x host controller575fdb4e21ecarm64: PCI: Search ACPI namespace to ensure ECAM space is reserved6fe2dc79c28dPCI: Add MCFG quirks for HiSilicon Hip05/06/07 host controllers
Quoted 6 lines
You will also need
00710984eac5ACPI: Addacpi_resource_consumer()to find device that claims a resource169de969c018PCI/ACPI: Provideacpi_get_rc_resources()for ARM64 platformto fix the errors.
No, that's a mess, I'm dropping those original patches, and others that depended on them. Thanks for letting me know.
greg k-h
Quoted 4 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.22 release. There are 152 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Like in 4.10.10-rc1, turbostat is no longer building. In addition to the same missing commit, 4.9.22-rc1 has one more issue.
71616c8e936a6dd541f0627d7bf4ff09971d8ccb "tools/power turbostat: decode Baytrail CC6 and MC6 demotion configuration" depends on a big deal of the turbostat changes in 4.10 due to needing 869ce69e1e8ae7e6fa4a1a90887e5f94eac653eb "tools/power turbostat: use intel-family.h model strings" which in turn needs a bunch of other commits to apply.
Seems simple enough to make a more targeted backport using the pre-"use intel-family.h model strings" style magic values.
Greg Kroah-Hartman
maintainerQuoted 16 lines · Andre Tomt
Quoted 4 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.22 release. There are 152 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Like in 4.10.10-rc1, turbostat is no longer building. In addition to the same missing commit, 4.9.22-rc1 has one more issue.
71616c8e936a6dd541f0627d7bf4ff09971d8ccb"tools/powerturbostat: decode Baytrail CC6 and MC6 demotion configuration" depends on a big deal of the turbostat changes in 4.10 due to needing869ce69e1e8ae7e6fa4a1a90887e5f94eac653eb"tools/powerturbostat: useintel-family.hmodel strings" which in turn needs a bunch of other commits to apply.
Quoted 2 lines
Seems simple enough to make a more targeted backport using the pre-"use
intel-family.hmodel strings" style magic values.
Ick, no, that's a total mess. I'm going to drop all of these now from 4.9 and 4.10 as it's obvious Sasha never tried to build them :(
thanks,
greg k-h
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.22 release. There are 152 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Apr 12 16:41:34 UTC 2017. Anything received after that time might be too late.
Build results:
total: 149 pass: 146 fail: 3
Failed builds:
arm:allmodconfig
arm:omap2plus_defconfig
arm64:allmodconfig
Qemu test results:
total: 122 pass: 103 fail: 19 Failed tests: arm:beagle:multi_v7_defconfig:omap3-beagle arm:beaglexm:multi_v7_defconfig:omap3-beagle-xm arm:overo:multi_v7_defconfig:omap3-overo-tobi arm:sabrelite:multi_v7_defconfig:imx6dl-sabrelite arm:vexpress-a9:multi_v7_defconfig:vexpress-v2p-ca9 arm:vexpress-a15:multi_v7_defconfig:vexpress-v2p-ca15-tc1 arm:vexpress-a15-a7:multi_v7_defconfig:vexpress-v2p-ca15_a7 arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zc702 arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zc706 arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zed arm:midway:multi_v7_defconfig:ecx-2000 arm:smdkc210:multi_v7_defconfig:exynos4210-smdkv310 arm:beagle:omap2plus_defconfig:omap3-beagle arm:beaglexm:omap2plus_defconfig:omap3-beagle-xm arm:overo:omap2plus_defconfig:omap3-overo-tobi arm64:virt:smp:defconfig arm64:xlnx-ep108:smp:defconfig:zynqmp-ep108 arm64:virt:nosmp:defconfig arm64:xlnx-ep108:nosmp:defconfig:zynqmp-ep108
As reported earlier, the arm64 builds fail with
Building arm64:virt:nosmp:defconfig ... failed
------------
Error log:arch/arm64/Makefile:23: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum arch/arm64/kernel/pci.c: In function ‘pci_acpi_setup_ecam_mapping’:arch/arm64/kernel/pci.c:139:9: error: implicit declaration of function ‘acpi_resource_consumer’
adev = acpi_resource_consumer(&cfgres);
...drivers/pci/host/pcie-hisi.c: In function ‘hisi_pcie_init’:drivers/pci/host/pcie-hisi.c:94:8: error: implicit declaration of function ‘acpi_get_rc_resources’
---
The arm builds fail as follows.
Building arm:overo:omap2plus_defconfig:omap3-overo-tobi ... failed
------------
Error log:
In file included from arch/arm/mach-omap2/pdata-quirks.c:15:0:arch/arm/mach-omap2/pdata-quirks.c:537:49: error: 'rx51_ir_data' undeclared here (not in a function)
OF_DEV_AUXDATA("nokia,n900-ir", 0, "n900-ir", &rx51_ir_data),
^
./include/linux/of_platform.h:52:21: note: in definition of macro 'OF_DEV_AUXDATA'
.platform_data = _pdata }
^make[1]: *** [arch/arm/mach-omap2/pdata-quirks.o] Error 1
I am a bit lost here. Reverting
f2ea7a5c3730 rx51: broken build
fixes the problem, but is supposed to accomplish the opposite. You'll need to drop that patch, or maybe even better drop
375a81645446 ARM: OMAP2+: Fix init for multiple quirks for the same SoC
as well and let the authors [copied] sort this out.
Anyway, details are as always available at http://kerneltests.org/builders.
Guenter
Greg Kroah-Hartman
maintainerQuoted 71 lines · Guenter Roeck
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.22 release. There are 152 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Apr 12 16:41:34 UTC 2017. Anything received after that time might be too late.
Build results:
total: 149 pass: 146 fail: 3Failed builds:
arm:allmodconfig
arm:omap2plus_defconfig
arm64:allmodconfigQemu test results:
total: 122 pass: 103 fail: 19 Failed tests: arm:beagle:multi_v7_defconfig:omap3-beagle arm:beaglexm:multi_v7_defconfig:omap3-beagle-xm arm:overo:multi_v7_defconfig:omap3-overo-tobi arm:sabrelite:multi_v7_defconfig:imx6dl-sabrelite arm:vexpress-a9:multi_v7_defconfig:vexpress-v2p-ca9 arm:vexpress-a15:multi_v7_defconfig:vexpress-v2p-ca15-tc1 arm:vexpress-a15-a7:multi_v7_defconfig:vexpress-v2p-ca15_a7 arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zc702 arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zc706 arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zed arm:midway:multi_v7_defconfig:ecx-2000 arm:smdkc210:multi_v7_defconfig:exynos4210-smdkv310 arm:beagle:omap2plus_defconfig:omap3-beagle arm:beaglexm:omap2plus_defconfig:omap3-beagle-xm arm:overo:omap2plus_defconfig:omap3-overo-tobi arm64:virt:smp:defconfig arm64:xlnx-ep108:smp:defconfig:zynqmp-ep108 arm64:virt:nosmp:defconfig arm64:xlnx-ep108:nosmp:defconfig:zynqmp-ep108As reported earlier, the arm64 builds fail with
Building arm64:virt:nosmp:defconfig ... failed
------------
Error log:arch/arm64/Makefile:23: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratumarch/arm64/kernel/pci.c: In function ‘pci_acpi_setup_ecam_mapping’:arch/arm64/kernel/pci.c:139:9: error: implicit declaration of function ‘acpi_resource_consumer’
adev =acpi_resource_consumer(&cfgres);
...drivers/pci/host/pcie-hisi.c: In function ‘hisi_pcie_init’:drivers/pci/host/pcie-hisi.c:94:8: error: implicit declaration of function ‘acpi_get_rc_resources’---
The arm builds fail as follows.
Building arm:overo:omap2plus_defconfig:omap3-overo-tobi ... failed
------------
Error log:
In file included fromarch/arm/mach-omap2/pdata-quirks.c:15:0:arch/arm/mach-omap2/pdata-quirks.c:537:49: error: 'rx51_ir_data' undeclared here (not in a function)
OF_DEV_AUXDATA("nokia,n900-ir", 0, "n900-ir", &rx51_ir_data),^ ./include/linux/of_platform.h:52:21: note: in definition of macro 'OF_DEV_AUXDATA' .platform_data = _pdata } ^make[1]: *** [
arch/arm/mach-omap2/pdata-quirks.o] Error 1I am a bit lost here. Reverting
Quoted 8 lines
f2ea7a5c3730rx51: broken buildfixes the problem, but is supposed to accomplish the opposite. You'll need to drop that patch, or maybe even better drop
375a81645446ARM: OMAP2+: Fix init for multiple quirks for the same SoCas well and let the authors [copied] sort this out.
Good idea, both now dropped, thanks.
greg k-h
Quoted 15 lines · Greg Kroah-Hartman
Quoted 14 lines · Guenter Roeck
The arm builds fail as follows.
Building arm:overo:omap2plus_defconfig:omap3-overo-tobi ... failed
------------
Error log:
In file included fromarch/arm/mach-omap2/pdata-quirks.c:15:0:arch/arm/mach-omap2/pdata-quirks.c:537:49: error: 'rx51_ir_data' undeclared here (not in a function)
OF_DEV_AUXDATA("nokia,n900-ir", 0, "n900-ir", &rx51_ir_data),^ ./include/linux/of_platform.h:52:21: note: in definition of macro 'OF_DEV_AUXDATA' .platform_data = _pdata } ^make[1]: *** [
arch/arm/mach-omap2/pdata-quirks.o] Error 1
Quoted 6 lines
Quoted 6 lines
I am a bit lost here. Reverting
f2ea7a5c3730rx51: broken buildfixes the problem, but is supposed to accomplish the opposite. You'll need to drop that patch, or maybe even better drop
Just trying to understand what's going on.. OK so dropping the patch above makes sense. It seems there's some other dependency not mentioned there.
Quoted 3 lines
Quoted 3 lines
375a81645446ARM: OMAP2+: Fix init for multiple quirks for the same SoCas well and let the authors [copied] sort this out.
Guenter, what's your reasoning to also drop this one? I don't quite see the connection between these two patches?
Quoted 1 line
Good idea, both now dropped, thanks.
Fine with me, the second one can always be revisited as needed.
Regards,
Tony
Quoted 27 lines · Tony Lindgren
Quoted 15 lines · Greg Kroah-Hartman
Quoted 14 lines · Guenter Roeck
The arm builds fail as follows.
Building arm:overo:omap2plus_defconfig:omap3-overo-tobi ... failed
------------
Error log:
In file included fromarch/arm/mach-omap2/pdata-quirks.c:15:0:arch/arm/mach-omap2/pdata-quirks.c:537:49: error: 'rx51_ir_data' undeclared here (not in a function)
OF_DEV_AUXDATA("nokia,n900-ir", 0, "n900-ir", &rx51_ir_data),^ ./include/linux/of_platform.h:52:21: note: in definition of macro 'OF_DEV_AUXDATA' .platform_data = _pdata } ^make[1]: *** [
arch/arm/mach-omap2/pdata-quirks.o] Error 1Quoted 6 lines
Quoted 6 lines
I am a bit lost here. Reverting
f2ea7a5c3730rx51: broken buildfixes the problem, but is supposed to accomplish the opposite. You'll need to drop that patch, or maybe even better drop
Just trying to understand what's going on.. OK so dropping the patch above makes sense. It seems there's some other dependency not mentioned there.
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
375a81645446ARM: OMAP2+: Fix init for multiple quirks for the same SoCas well and let the authors [copied] sort this out.
Guenter, what's your reasoning to also drop this one? I don't quite see the connection between these two patches?
Somehow I thought they are related, but right now I have no idea why I thought that. Maybe I didn't have enough coffee :-(.
Guenter
Greg Kroah-Hartman
maintainerQuoted 30 lines · Guenter Roeck
Quoted 29 lines · Tony Lindgren
Quoted 15 lines · Greg Kroah-Hartman
Quoted 14 lines · Guenter Roeck
The arm builds fail as follows.
Building arm:overo:omap2plus_defconfig:omap3-overo-tobi ... failed
------------
Error log:
In file included fromarch/arm/mach-omap2/pdata-quirks.c:15:0:arch/arm/mach-omap2/pdata-quirks.c:537:49: error: 'rx51_ir_data' undeclared here (not in a function)
OF_DEV_AUXDATA("nokia,n900-ir", 0, "n900-ir", &rx51_ir_data),^ ./include/linux/of_platform.h:52:21: note: in definition of macro 'OF_DEV_AUXDATA' .platform_data = _pdata } ^make[1]: *** [
arch/arm/mach-omap2/pdata-quirks.o] Error 1Quoted 6 lines
Quoted 6 lines
I am a bit lost here. Reverting
f2ea7a5c3730rx51: broken buildfixes the problem, but is supposed to accomplish the opposite. You'll need to drop that patch, or maybe even better drop
Just trying to understand what's going on.. OK so dropping the patch above makes sense. It seems there's some other dependency not mentioned there.
Quoted 2 lines
Quoted 2 lines
375a81645446ARM: OMAP2+: Fix init for multiple quirks for the same SoC
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
as well and let the authors [copied] sort this out.
Guenter, what's your reasoning to also drop this one? I don't quite see the connection between these two patches?
Somehow I thought they are related, but right now I have no idea why I thought that. Maybe I didn't have enough coffee :-(.
I'm frustrated enough at this mess that it's not a big deal to drop them, if Sasha feels they are really needed, we can re-add them later :)
thanks,
greg k-h
Greg Kroah-Hartman
maintainerQuoted 5 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.22 release. There are 152 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Quoted 8 lines
Responses should be made by Wed Apr 12 16:41:34 UTC 2017. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.22-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.9.y
and the diffstat can be found below.
And I made a -rc2 here as well, due to the build issues:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.22-rc2.gz
or:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
thanks,
greg k-h
Quoted 15 lines · Greg Kroah-Hartman
Quoted 5 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.22 release. There are 152 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Quoted 8 lines
Responses should be made by Wed Apr 12 16:41:34 UTC 2017. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.22-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.9.y
and the diffstat can be found below.
Quoted 6 lines
And I made a -rc2 here as well, due to the build issues:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.22-rc2.gzor:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.9.y
Both 4.9 and 4.10 are now clean; no more build (or qemu) errors.
Thanks,
Guenter
Greg Kroah-Hartman
maintainerQuoted 16 lines · Guenter Roeck
Quoted 15 lines · Greg Kroah-Hartman
Quoted 13 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.22 release. There are 152 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed Apr 12 16:41:34 UTC 2017. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.22-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.9.y
and the diffstat can be found below.
Quoted 8 lines
Quoted 6 lines
And I made a -rc2 here as well, due to the build issues:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.22-rc2.gzor:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.9.yBoth 4.9 and 4.10 are now clean; no more build (or qemu) errors.
Yeah! thanks for letting me know.
greg k-h