device-dax: Improve fault handler debug output
PATCH 1/1 device-dax: Improve fault handler debug output
A couple of minor improvements to the debug output in the fault handlers:
a) Print the region alignment and fault size when we sent a SIGBUS because the region alignment is greater than the fault size.
b) Fix the message in the PFN_{DEV|MAP} check.
c) Additionally print the fault size enum value in the huge fault handler.
--- drivers/dax/dax.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
drivers/dax/dax.c +10 -7
@@ -395,7 +395,8 @@ static int __dax_dev_pte_fault(struct dax_dev *dax_dev, struct vm_fault *vmf) dax_region = dax_dev->region;if (dax_region->align >PAGE_SIZE ) { -dev_dbg (dev,"%s: alignment > fault size\n" , __func__); +dev_dbg (dev,"%s: alignment (%#x) > fault size (%#x)\n" , + __func__, dax_region->align, fault_size);return VM_FAULT_SIGBUS ; }
@@ -436,13 +437,14 @@ static int __dax_dev_pmd_fault(struct dax_dev *dax_dev, struct vm_fault *vmf) dax_region = dax_dev->region;if (dax_region->align >PMD_SIZE ) { -dev_dbg (dev,"%s: alignment > fault size\n" , __func__); +dev_dbg (dev,"%s: alignment (%#x) > fault size (%#x)\n" , + __func__, dax_region->align, fault_size);return VM_FAULT_SIGBUS ; }/* dax pmd mappings require pfn_t_devmap() */ if ((dax_region->pfn_flags & (PFN_DEV |PFN_MAP )) != (PFN_DEV |PFN_MAP )) { -dev_dbg (dev,"%s: alignment > fault size\n" , __func__); +dev_dbg (dev,"%s: region lacks devmap flags\n" , __func__);return VM_FAULT_SIGBUS ; }
@@ -487,13 +489,14 @@ static int __dax_dev_pud_fault(struct dax_dev *dax_dev, struct vm_fault *vmf) dax_region = dax_dev->region;if (dax_region->align >PUD_SIZE ) { -dev_dbg (dev,"%s: alignment > fault size\n" , __func__); +dev_dbg (dev,"%s: alignment (%#x) > fault size (%#x)\n" , + __func__, dax_region->align, fault_size);return VM_FAULT_SIGBUS ; }/* dax pud mappings require pfn_t_devmap() */ if ((dax_region->pfn_flags & (PFN_DEV |PFN_MAP )) != (PFN_DEV |PFN_MAP )) { -dev_dbg (dev,"%s: alignment > fault size\n" , __func__); +dev_dbg (dev,"%s: region lacks devmap flags\n" , __func__);return VM_FAULT_SIGBUS ; }
@@ -534,10 +537,10 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,struct file *filp = vmf->vma->vm_file;struct dax_dev *dax_dev = filp->private_data; -dev_dbg (&dax_dev->dev,"%s: %s: %s (%#lx - %#lx)\n" , __func__, +dev_dbg (&dax_dev->dev,"%s: %s: %s (%#lx - %#lx) size = %d\n" , __func__, current->comm, (vmf->flags &FAULT_FLAG_WRITE ) ?"write" :"read" , - vmf->vma->vm_start, vmf->vma->vm_end); + vmf->vma->vm_start, vmf->vma->vm_end, pe_size); id =srcu_read_lock (&dax_srcu);switch (pe_size) {
Signature · 6 lines
2.9.3 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
Quoted 8 lines · Oliver O'Halloran
A couple of minor improvements to the debug output in the fault handlers:
a) Print the region alignment and fault size when we sent a SIGBUS because the region alignment is greater than the fault size.
b) Fix the message in the PFN_{DEV|MAP} check.
c) Additionally print the fault size enum value in the huge fault handler.Signed-off-by Oliver O'Halloran <[email protected]>
Thanks Oliver, looks good.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm