Skip to contentSkip to conversation

alpha: module xxx: Unknown relocation: 1

BUG Bob Tracy 3 participants 4 messages Apr 12, 2017 – Apr 13, 2017 5 messages not in the archive Alpha port

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 20170410094250.gxcne7imso4u2vjx@tower

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 20170411061232.bchlfc73lqx2z2cy@tower

A message that is not in the archive (sent off-list or not yet received): [email protected]

Bob Tracy

author
#5 lore raw

(Adding linux-kernel to the distribution. The issue seems to be architecture-specific, but I'm trying to understand what broke.)

The 4.10-rc1 patch set made fairly extensive modifications to "a/kernel/module.c" (I'm leaving the "a" there so there's no doubt I mean the top-level "kernel/module.c" file and not any of the architecture-specific ones).

One of the changes was to replace an include of <asm/uaccess.h> with <linux/uaccess.h>. This is potentially significant because of the mod we made to alpha's <asm/uaccess.h> to fix the BRSGP relocation error on __copy_user() issue.

Bottom line is, no kernel I've built since 4.9 can load a module. All attempts to load a module result in the error message emitted by "arch/alpha/kernel/module.c" as follows:

module XXX: Unknown relocation: 1

I'll start attempting to revert the recent module patches to see if that helps. If anyone reading this knows what's happening, feel free to weigh-in before I spend too much time rebuilding kernels on a slow machine.

--Bob

#6 lore raw
Quoted 17 lines · Bob Tracy

(Adding linux-kernel to the distribution. The issue seems to be architecture-specific, but I'm trying to understand what broke.)

The 4.10-rc1 patch set made fairly extensive modifications to "a/kernel/module.c" (I'm leaving the "a" there so there's no doubt I mean the top-level "kernel/module.c" file and not any of the architecture-specific ones).

One of the changes was to replace an include of <asm/uaccess.h> with <linux/uaccess.h>. This is potentially significant because of the mod we made to alpha's <asm/uaccess.h> to fix the BRSGP relocation error on __copy_user() issue.

Bottom line is, no kernel I've built since 4.9 can load a module. All attempts to load a module result in the error message emitted by "arch/alpha/kernel/module.c" as follows:

Quoted 6 lines

module XXX: Unknown relocation: 1

I'll start attempting to revert the recent module patches to see if that helps. If anyone reading this knows what's happening, feel free to weigh-in before I spend too much time rebuilding kernels on a slow machine.

I assume it's due this commmit "modversions: treat symbol CRCs as 32 bit quantities":
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=71810db27c1c853b335675bee335d893bc3d324b

For parisc this patch solves it:
parisc: support R_PARISC_SECREL32 relocation in modules
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f655322b1ba4bd46e26e307d04098f9c84df764

Quoted 1 line

module XXX: Unknown relocation: 1

For alpha it seems you need to add similar code to handle R_ALPHA_REFLONG to apply_relocate_add() in arch/alpha/kernel/module.c

Helge

#7 lore raw
Quoted 11 lines · Helge Deller
Quoted 6 lines · Bob Tracy

Bottom line is, no kernel I've built since 4.9 can load a module. All attempts to load a module result in the error message emitted by "arch/alpha/kernel/module.c" as follows:

module XXX: Unknown relocation: 1

I assume it's due this commmit "modversions: treat symbol CRCs as 32 bit quantities":
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=71810db27c1c853b335675bee335d893bc3d324b

Quoted 8 lines

For parisc this patch solves it:
parisc: support R_PARISC_SECREL32 relocation in modules
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f655322b1ba4bd46e26e307d04098f9c84df764

Quoted 1 line

module XXX: Unknown relocation: 1

For alpha it seems you need to add similar code to handle R_ALPHA_REFLONG to apply_relocate_add() in arch/alpha/kernel/module.c

Would the attached patch fix it? Untested because I don't see the above issue.

Cheers
Michael.

arch/alpha/kernel/module.c +3 -0
index 936bc8f89a67..47632fa8c24e 100644
@@ -181,6 +181,9 @@ apply_relocate_add(Elf64_Shdr *sechdrs, const char *strtab,
 		switch (r_type) {
 		case R_ALPHA_NONE:
 			break;
+		case R_ALPHA_REFLONG:
+			*(u32 *)location = value;
+			break;
 		case R_ALPHA_REFQUAD:
 			/* BUG() can produce misaligned relocations. */
 			((u32 *)location)[0] = value;
author
#8 lore raw
Quoted 15 lines · Michael Cree
Quoted 14 lines · Helge Deller
Quoted 5 lines · Bob Tracy

Bottom line is, no kernel I've built since 4.9 can load a module. All attempts to load a module result in the error message emitted by "arch/alpha/kernel/module.c" as follows:

module XXX: Unknown relocation: 1

I assume it's due this commmit "modversions: treat symbol CRCs as 32 bit quantities":
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=71810db27c1c853b335675bee335d893bc3d324b

For parisc this patch solves it:
parisc: support R_PARISC_SECREL32 relocation in modules
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f655322b1ba4bd46e26e307d04098f9c84df764

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

module XXX: Unknown relocation: 1

For alpha it seems you need to add similar code to handle R_ALPHA_REFLONG to apply_relocate_add() in arch/alpha/kernel/module.c

Would the attached patch fix it? Untested because I don't see the above issue.

I'm up and running on 4.11.0-rc6. The patch works. Feel free to add me as the "Tested-by". Much appreciated!

--Bob