Skip to contentSkip to conversation

nvmet_fc: Change traddr field separator to a colon

PATCH New [email protected] 3 participants 3 messages Apr 12, 2017 – Apr 20, 2017

Subsystems (3)
NVMe NVMe target NVMe FC transport
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 nvmet_fc: Change traddr field separator to a colon

From: James Smart <[email protected]>

The FC-NVME spec revised syntax to avoid comma separators. Sync with the change in the parser for traddr on port attachments.

Signed-off-by James Smart <james.smart at broadcom.com>
---
 drivers/nvme/target/fc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/fc.c +1 -1
index 9a8b846..e6243bb 100644
@@ -2326,7 +2326,7 @@ nvmet_fc_parse_traddr(struct nvmet_fc_traddr *traddr, char *buf)
 	if (!options)
 		return -ENOMEM;
 
-	while ((p = strsep(&o, ",\n")) != NULL) {
+	while ((p = strsep(&o, ":\n")) != NULL) {
 		if (!*p)
 			continue;
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 nvmet_fc: Change traddr field separator to a colon

Quoted 4 lines · On Wed, Apr 12, 2017@03:15:18PM -0700, [email protected] wrote:

From: James Smart <jsmart2021 at gmail.com>

The FC-NVME spec revised syntax to avoid comma separators. Sync with the change in the parser for traddr on port attachments.

Looks fine,

Reviewed-by Christoph Hellwig <hch at lst.de>