Skip to contentSkip to conversation

iio: dac: ad7303: fix channel description

PATCH In review [email protected] 3 participants 3 messages Apr 13, 2017 – Apr 14, 2017

Subsystems (2)
IIO Analog Devices IIO drivers
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 iio: dac: ad7303: fix channel description

From: Pavel Roskin <[email protected]>

realbits, storagebits and shift should be numbers, not ASCII characters.

Signed-off-by Pavel Roskin <[email protected]>
---
 drivers/iio/dac/ad7303.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/dac/ad7303.c +3 -3
index e690dd11e99f..4b0f942b8914 100644
@@ -184,9 +184,9 @@ static const struct iio_chan_spec_ext_info ad7303_ext_info[] = {
 	.address = (chan),					\
 	.scan_type = {						\
 		.sign = 'u',					\
-		.realbits = '8',				\
-		.storagebits = '8',				\
-		.shift = '0',					\
+		.realbits = 8,					\
+		.storagebits = 8,				\
+		.shift = 0,					\
 	},							\
 	.ext_info = ad7303_ext_info,				\
 }
Signature · 1 line
2.12.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · On 04/13/2017 11:54 PM, [email protected] wrote:

From: Pavel Roskin <[email protected]>

realbits, storagebits and shift should be numbers, not ASCII characters.

Signed-off-by Pavel Roskin <[email protected]>

Thanks for the fix.

Reviewed-by Lars-Peter Clausen <[email protected]>

You really have to wonder how somebody would be able to get that wrong in the first place... ;)

Quoted 22 lines
---
 drivers/iio/dac/ad7303.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/dac/ad7303.c +3 -3
index e690dd11e99f..4b0f942b8914 100644
@@ -184,9 +184,9 @@ static const struct iio_chan_spec_ext_info ad7303_ext_info[] = {
 	.address = (chan),					\
 	.scan_type = {						\
 		.sign = 'u',					\
-		.realbits = '8',				\
-		.storagebits = '8',				\
-		.shift = '0',					\
+		.realbits = 8,					\
+		.storagebits = 8,				\
+		.shift = 0,					\
 	},							\
 	.ext_info = ad7303_ext_info,				\
 }
maintainer
#2 lore raw
Quoted 5 lines · Lars-Peter Clausen
Quoted 4 lines · On 04/13/2017 11:54 PM, [email protected] wrote:

From: Pavel Roskin <[email protected]>

realbits, storagebits and shift should be numbers, not ASCII characters.

Quoted 8 lines
Quoted 1 line
Signed-off-by Pavel Roskin <[email protected]>

Thanks for the fix.

Reviewed-by Lars-Peter Clausen <[email protected]>

You really have to wonder how somebody would be able to get that wrong in the first place... ;)

Applied and marked for stable. Big oops on this one.

Jonathan

Quoted 30 lines
Quoted 14 lines

---
 drivers/iio/dac/ad7303.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/dac/ad7303.c +0 -0
index e690dd11e99f..4b0f942b8914 100644
@@ -184,9 +184,9 @@ static const struct iio_chan_spec_ext_info ad7303_ext_info[] = {
 	.address = (chan),					\
 	.scan_type = {						\

drivers/iio/dac/ad7303.c static const struct iio_chan_spec_ext_info ad7303_ext_info[] = { · line 192

Quoted 10 lines
drivers/iio/dac/ad7303.c +3 -3
 		.sign = 'u',					\
-		.realbits = '8',				\
-		.storagebits = '8',				\
-		.shift = '0',					\
+		.realbits = 8,					\
+		.storagebits = 8,				\
+		.shift = 0,					\
 	},							\
 	.ext_info = ad7303_ext_info,				\
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html