ARM: dts: imx: ventana: fix DTC warnings

PATCH Superseded Tim Harvey 2 participants 4 messages Apr 3, 2017 – Apr 14, 2017

Subsystems (2)

Device tree bindings Arm i.MX and Layerscape

lore

Share & tools

lore

Tim Harvey

author

2017-04-03 20:42 UTC #0 lore raw

PATCH 1/1 ARM: dts: imx: ventana: fix DTC warnings

Remove the sky2 ethernet device node from the pcie controller which was invalid to begin with.

The original intent was to allow the bootloader to populate the MAC via dt but this requires the PCI bus topology to be complete in dt as well and as these boards have an expansion connector that topology is dynamic and can't be represented here.

Signed-off-by Tim Harvey <[email protected]>

---
 arch/arm/boot/dts/imx6q-gw5400-a.dts  | 4 ----
 arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 4 ----
 arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 4 ----
 3 files changed, 12 deletions(-)

arch/arm/boot/dts/imx6q-gw5400-a.dts +0 -4

index 8e84713..5b066c0 100644
@@ -347,10 +347,6 @@
 &pcie {
 	reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
 	status = "okay";
-
-	eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
-		compatible = "marvell,sky2";
-	};
 };
 
 &ssi1 {

arch/arm/boot/dts/imx6qdl-gw53xx.dtsi +0 -4

index a208e7e..420a2f6 100644
@@ -342,10 +342,6 @@
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
 	status = "okay";
-
-	eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
-		compatible = "marvell,sky2";
-	};
 };
 
 &pwm2 {

arch/arm/boot/dts/imx6qdl-gw54xx.dtsi +0 -4

index 968fda9..e742153 100644
@@ -379,10 +379,6 @@
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
 	status = "okay";
-
-	eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
-		compatible = "marvell,sky2";
-	};
 };
 
 &pwm1 {

Signature · 1 line

2.7.4

Shawn Guo

2017-04-07 12:33 UTC #1 lore raw

PATCH 1/1 ARM: dts: imx: ventana: fix DTC warnings

Quoted 20 lines · Tim Harvey

Remove the sky2 ethernet device node from the pcie controller which was invalid to begin with.
The original intent was to allow the bootloader to populate the MAC via dt but this requires the PCI bus topology to be complete in dt as well and as these boards have an expansion connector that topology is dynamic and can't be represented here.
Signed-off-by Tim Harvey <[email protected]>
---
 arch/arm/boot/dts/imx6q-gw5400-a.dts  | 4 ----
 arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 4 ----
 arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 4 ----
 3 files changed, 12 deletions(-)
arch/arm/boot/dts/imx6q-gw5400-a.dts +0 -0
index 8e84713..5b066c0 100644

arch/arm/boot/dts/imx6q-gw5400-a.dts line 353

Quoted 7 lines

arch/arm/boot/dts/imx6q-gw5400-a.dts +0 -4

@@ -347,10 +347,6 @@
 &pcie {
 	reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
 	status = "okay";
-
-	eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
-		compatible = "marvell,sky2";
-	};

The label 'eth1' is referenced by aliases, and so DTC complains as below.

ERROR (path_references): Reference to non-existent node or label "eth1".

Please test before submitting.

Shawn

Quoted 36 lines

arch/arm/boot/dts/imx6q-gw5400-a.dts +0 -0

 };
 
 &ssi1 {

arch/arm/boot/dts/imx6qdl-gw53xx.dtsi +0 -4

index a208e7e..420a2f6 100644
@@ -342,10 +342,6 @@
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
 	status = "okay";
-
-	eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
-		compatible = "marvell,sky2";
-	};
 };
 
 &pwm2 {

arch/arm/boot/dts/imx6qdl-gw54xx.dtsi +0 -4

index 968fda9..e742153 100644
@@ -379,10 +379,6 @@
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
 	status = "okay";
-
-	eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
-		compatible = "marvell,sky2";
-	};
 };
 
 &pwm1 {

Signature · 1 line

2.7.4

Tim Harvey

author

2017-04-10 20:58 UTC #2 lore raw

PATCH v2 1/1 ARM: dts: imx: ventana: fix DTC warnings

In reply to Tim Harvey

Remove the sky2 ethernet device node from the pcie controller which was invalid to begin with.

Signed-off-by Tim Harvey <[email protected]>

---
v2:
- remove eth1 aliases

Signed-off-by Tim Harvey <[email protected]>

---
 arch/arm/boot/dts/imx6q-gw5400-a.dts  | 5 -----
 arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 5 -----
 arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 5 -----
 3 files changed, 15 deletions(-)

arch/arm/boot/dts/imx6q-gw5400-a.dts +0 -5

index 8e84713..687ab91 100644
@@ -19,7 +19,6 @@
 
 	/* these are used by bootloader for disabling nodes */
 	aliases {
-		ethernet1 = &eth1;
 		i2c0 = &i2c1;
 		i2c1 = &i2c2;
 		i2c2 = &i2c3;

@@ -347,10 +346,6 @@
 &pcie {
 	reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
 	status = "okay";
-
-	eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
-		compatible = "marvell,sky2";
-	};
 };
 
 &ssi1 {

arch/arm/boot/dts/imx6qdl-gw53xx.dtsi +0 -5

index a208e7e..5bc6ed1 100644
@@ -14,7 +14,6 @@
 / {
 	/* these are used by bootloader for disabling nodes */
 	aliases {
-		ethernet1 = &eth1;
 		led0 = &led0;
 		led1 = &led1;
 		led2 = &led2;

@@ -342,10 +341,6 @@
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
 	status = "okay";
-
-	eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
-		compatible = "marvell,sky2";
-	};
 };
 
 &pwm2 {

arch/arm/boot/dts/imx6qdl-gw54xx.dtsi +0 -5

index 968fda9..66fcf838 100644
@@ -14,7 +14,6 @@
 / {
 	/* these are used by bootloader for disabling nodes */
 	aliases {
-		ethernet1 = &eth1;
 		led0 = &led0;
 		led1 = &led1;
 		led2 = &led2;

@@ -379,10 +378,6 @@
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
 	status = "okay";
-
-	eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
-		compatible = "marvell,sky2";
-	};
 };
 
 &pwm1 {

Signature · 1 line

2.7.4

Shawn Guo

Applied

2017-04-14 02:42 UTC #3 lore raw

PATCH v2 1/1 ARM: dts: imx: ventana: fix DTC warnings

Quoted 9 lines · Tim Harvey

Remove the sky2 ethernet device node from the pcie controller which was invalid to begin with.
The original intent was to allow the bootloader to populate the MAC via dt but this requires the PCI bus topology to be complete in dt as well and as these boards have an expansion connector that topology is dynamic and can't be represented here.
Signed-off-by Tim Harvey <[email protected]>

Applied, thanks.